-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation of the base platform #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes and it should be good to go. At some point we should thing about defining a structure in the variable for defining node in the nodepool as there is lots of duplicate code that can be refactor to a simple TF script with a foreach loop.
platforms/gke/base/core/workloads/kueue/dashboards/kueue-monitoring-dashboard.json
Outdated
Show resolved
Hide resolved
Yes, I've tried to keep the code as WET as possible since it is for reference purposes. Other solutions will more than likely have their own node pool requirements so they will probably skip the container_node_pool Terraservice and implement their own. That is the intended use of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.