Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of the base platform #24

Merged
merged 4 commits into from
Nov 1, 2024
Merged

Conversation

arueth
Copy link
Collaborator

@arueth arueth commented Oct 31, 2024

No description provided.

Copy link
Collaborator

@laurentgrangeau laurentgrangeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes and it should be good to go. At some point we should thing about defining a structure in the variable for defining node in the nodepool as there is lots of duplicate code that can be refactor to a simple TF script with a foreach loop.

@arueth
Copy link
Collaborator Author

arueth commented Nov 1, 2024

Some minor changes and it should be good to go. At some point we should thing about defining a structure in the variable for defining node in the nodepool as there is lots of duplicate code that can be refactor to a simple TF script with a foreach loop.

Yes, I've tried to keep the code as WET as possible since it is for reference purposes. Other solutions will more than likely have their own node pool requirements so they will probably skip the container_node_pool Terraservice and implement their own. That is the intended use of the platforms/gke/base/use-cases and platforms/gke/base/features folders.

@laurentgrangeau laurentgrangeau self-requested a review November 1, 2024 16:02
Copy link
Collaborator

@laurentgrangeau laurentgrangeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arueth arueth merged commit a4e6c1b into int-base-platform Nov 1, 2024
6 checks passed
@arueth arueth deleted the rueth-base branch November 1, 2024 17:16
arueth added a commit that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants