Skip to content

fix(lapis): also return CSV header when there are no data #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

fengelniederhammer
Copy link
Contributor

resolves #1090

PR Checklist

- [ ] All necessary documentation has been adapted.

  • The implemented feature is covered by an appropriate test.

Copy link

vercel bot commented Mar 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lapis ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 31, 2025 8:08am

Copy link
Contributor

github-actions bot commented Mar 25, 2025

This is a preview of the changelog of the next release. If this branch is not up-to-date with the current main branch, the changelog may not be accurate. Rebase your branch on the main branch to get the most accurate changelog.

Note that this might contain changes that are on main, but not yet released.

Changelog:

0.4.2 (2025-03-31)

Features

  • lapis: return empty lineage definitions when SILO returns an empty file (#1126) (64651ad)

Bug Fixes

  • lapis-docs: mention how arrays must be supplied in form urlencoded requests (#1128) (4f24a76), closes #1089
  • lapis: also return CSV header when there are no data (af52497), closes #1090

Copy link
Contributor

@JonasKellerer JonasKellerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. There was more refactoring going on than I would have expected, but it looks good.
Only some minor issues.

@fengelniederhammer fengelniederhammer force-pushed the 1090-return-csvtsv-headers-even-when-there-are-no-data branch from 183c2c8 to af52497 Compare March 31, 2025 08:08
@fengelniederhammer fengelniederhammer merged commit aba1320 into main Mar 31, 2025
9 checks passed
@fengelniederhammer fengelniederhammer deleted the 1090-return-csvtsv-headers-even-when-there-are-no-data branch March 31, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return CSV/TSV headers even when there are no data
2 participants