Add tests for migration-manager #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breml
force-pushed
the
migration-manager-tests
branch
2 times, most recently
from
47a658a to
d710e92
Compare
|
Can you split this PR up a bit into more commits? I'd at likely have done:
|
breml
force-pushed
the
migration-manager-tests
branch
from
d710e92 to
7d390ab
Compare
gibmat
reviewed
Dec 10, 2024
breml
commented
Dec 11, 2024
breml
force-pushed
the
migration-manager-tests
branch
from
7d390ab to
4b29320
Compare
breml
force-pushed
the
migration-manager-tests
branch
2 times, most recently
from
f737152 to
9233656
Compare
breml
force-pushed
the
migration-manager-tests
branch
2 times, most recently
from
83ce777 to
9df76bc
Compare
breml
force-pushed
the
migration-manager-tests
branch
2 times, most recently
from
851f816 to
d5d5577
Compare
gibmat
reviewed
Dec 12, 2024
Ensure generated code is up to date Signed-off-by: Lucas Bremgartner <[email protected]>
Signed-off-by: Lucas Bremgartner <[email protected]>
Signed-off-by: Lucas Bremgartner <[email protected]>
Signed-off-by: Lucas Bremgartner <[email protected]>
breml
force-pushed
the
migration-manager-tests
branch
from
d5d5577 to
29d8011
Compare
for communication with sources Signed-off-by: Lucas Bremgartner <[email protected]>
Signed-off-by: Lucas Bremgartner <[email protected]>
Add tests for error cases. Remove unnecessary code in render CSV. Signed-off-by: Lucas Bremgartner <[email protected]>
Signed-off-by: Lucas Bremgartner <[email protected]>
Signed-off-by: Lucas Bremgartner <[email protected]>
Signed-off-by: Lucas Bremgartner <[email protected]>
Signed-off-by: Lucas Bremgartner <[email protected]>
breml
force-pushed
the
migration-manager-tests
branch
from
29d8011 to
78e059f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@stgraber , @gibmat
I added some first tests for the
sourcecommand inmigration-manager. For this I used the vCenter Simulator from https://github.com/vmware/govmomi/simulator for the connection test to the source. This works pretty well.