Merge pull request #8 from FuturFusion/migration-manager-tests

Add tests for migration-manager

Author: breml

.golangci.yml

@@ -29,6 +29,9 @@ issues:
     # Most of the code of internal/migratekit was copied from the excellent project
     # https://github.com/vexxhost/migratekit, Apache-2.0 license.
     - internal/migratekit
+    # Copied from the Go standard library
+    # https://github.com/golang/go/blob/master/src/net/http/internal/testcert/testcert.go, BSD-3-Clause license
+    - internal/testcert
 linters-settings:
   gci:
     sections:

cmd/migration-manager/cmds/ask.go

@@ -0,0 +1,5 @@
+package cmds
+
+import "github.com/lxc/incus/v6/shared/ask"
+
+var askPasswordFunc = ask.AskPassword

cmd/migration-manager/cmds/asker_mock_gen_test.go

@@ -12,15 +12,23 @@ import (
 	"path"
 
 	"github.com/lxc/incus/v6/shared/api"
-	"github.com/lxc/incus/v6/shared/ask"
 	"github.com/lxc/incus/v6/shared/util"
 	"github.com/spf13/cobra"
 
 	"github.com/FuturFusion/migration-manager/cmd/migration-manager/config"
 )
 
+//go:generate go run github.com/matryer/moq -fmt goimports -out asker_mock_gen_test.go -rm . Asker
+
+type Asker interface {
+	AskBool(question string, defaultAnswer string) (bool, error)
+	AskChoice(question string, choices []string, defaultAnswer string) (string, error)
+	AskInt(question string, minValue int64, maxValue int64, defaultAnswer string, validate func(int64) error) (int64, error)
+	AskString(question string, defaultAnswer string, validate func(string) error) (string, error)
+}
+
 type CmdGlobal struct {
-	Asker ask.Asker
+	Asker Asker
 
 	config *config.Config
 	Cmd    *cobra.Command

cmd/migration-manager/cmds/global.go

@@ -2,6 +2,7 @@ package cmds
 
 import (
 	"context"
+	"crypto/tls"
 	"encoding/json"
 	"errors"
 	"fmt"
@@ -10,7 +11,6 @@ import (
 	"strconv"
 	"strings"
 
-	"github.com/lxc/incus/v6/shared/ask"
 	"github.com/spf13/cobra"
 
 	"github.com/FuturFusion/migration-manager/internal/source"
@@ -63,6 +63,8 @@ type cmdSourceAdd struct {
 
 	flagInsecure         bool
 	flagNoTestConnection bool
+
+	additionalRootCertificate *tls.Certificate
 }
 
 func (c *cmdSourceAdd) Command() *cobra.Command {
@@ -119,7 +121,7 @@ func (c *cmdSourceAdd) Run(cmd *cobra.Command, args []string) error {
 			return err
 		}
 
-		sourcePassword := ask.AskPassword("Please enter password for endpoint '" + sourceEndpoint + "': ")
+		sourcePassword := askPasswordFunc("Please enter password for endpoint '" + sourceEndpoint + "': ")
 
 		s := api.VMwareSource{
 			CommonSource: api.CommonSource{
@@ -147,6 +149,10 @@ func (c *cmdSourceAdd) Run(cmd *cobra.Command, args []string) error {
 			return err
 		}
 
+		if c.additionalRootCertificate != nil {
+			internalSource.WithAdditionalRootCertificate(c.additionalRootCertificate)
+		}
+
 		if !c.flagNoTestConnection {
 			err = internalSource.Connect(ctx)
 			if err != nil {
@@ -366,7 +372,7 @@ func (c *cmdSourceUpdate) Run(cmd *cobra.Command, args []string) error {
 			return err
 		}
 
-		specificSource.Password = ask.AskPassword("Password: ")
+		specificSource.Password = askPasswordFunc("Password: ")
 
 		isInsecure := "no"
 		if specificSource.Insecure {