Use the streaming data from MWEB to avoid SABR-only responses #7327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
1 task
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Apr 30, 2025
6 tasks
ChunkyProgrammer
approved these changes
May 1, 2025
PikachuEXE
approved these changes
May 1, 2025
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
May 1, 2025
* development: Bump package version from 0.23.4 to 0.23.5 (FreeTubeApp#7328) Use the streaming data from MWEB to avoid SABR-only responses (FreeTubeApp#7327) Translated using Weblate (Norwegian Bokmål) Translated using Weblate (Spanish (Mexico))
OothecaPickle
pushed a commit
to OothecaPickle/FreeTube
that referenced
this pull request
May 1, 2025
efb4f5ff-1298-471a-8973-3d47447115dc
pushed a commit
that referenced
this pull request
May 1, 2025
|
Can't you make switching the client into an option in the settings so when youtube is tweaking something again users can try this? |
That would increase maintenance requirements and not be as simple as switching between clients with a flag. It also wouldn't have the benefit you are imagining it would have. You can not predict what clients will break at any given time. It makes more sense to just wait, see and hotfix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the streaming data from MWEB to avoid SABR-only responses
Pull Request Type
Related issue
Audio formats are not available for this video/ 360p only streams - SABR #7119Description
This pull request temporarily switches to using the streaming data from the MWEB client to avoid SABR-only responses, as the SABR implemenation still has various issues and this allows us to do a quick hotfix. The only known downside is that we lose support for multiple audio tracks (you'll only get the original one now) but Stable Volume is still available.
Testing
Open a few videos and check that they work.
Desktop