Add 50fps and live support to frame by frame keyboard shortcuts #3420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
|
Invidious live streams seem to be working for me (i only tried going to the watch page, not watching it in freetube). |
|
Local API: all fine
|
|
the 50fps -> 60fps is apparently a known Invidious issue and will be fixed by iv-org/invidious#3620 |
ChunkyProgrammer
approved these changes
Apr 15, 2023
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Apr 15, 2023
PikachuEXE
approved these changes
Apr 17, 2023
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Apr 17, 2023
* development: Add 50fps and live support to frame by frame keyboard shortcuts (FreeTubeApp#3420) Remove invidious.namazso.eu in dev branch (FreeTubeApp#3425) Cleanup polyfills (FreeTubeApp#3383) Small community post fixes (FreeTubeApp#3401) Bump rimraf from 4.4.1 to 5.0.0 (FreeTubeApp#3409) Bump peter-evans/create-pull-request from 4 to 5 (FreeTubeApp#3414) Bump eslint from 8.37.0 to 8.38.0 (FreeTubeApp#3416) Bump lefthook from 1.3.8 to 1.3.9 (FreeTubeApp#3410) Bump webpack from 5.77.0 to 5.78.0 (FreeTubeApp#3411) Bump youtubei.js from 4.1.1 to 4.2.0 (FreeTubeApp#3412) Bump sass from 1.60.0 to 1.61.0 (FreeTubeApp#3413) Update Channel age restricted key (FreeTubeApp#3237) Fix some translation entries sometimes not used when rendered (FreeTubeApp#3337) Reset current chapter index when changing videos (FreeTubeApp#3400)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 50fps and live support to frame by frame keyboard shortcuts
Pull Request Type
Description
This pull request refactors the frame by frame code to support videos that have framerates other than 60 or 30 and adds support for live streams too. Additionally I was able to get rid of the part where it read the DASH manifest from the disk, so it should now work properly in the web (and cordova if someone has a keyboard hooked up to their phone) builds too.
Live streams seem to be broken for Invidious at the moment, so I wasn't able to test if my changes work for that (the HLS manifests provided by Invidious return 429 errors for all live streams and instances I tried).
Testing
Unfortunately live streams don't seem to be working with Invidious at the moment and always return 429 errors for the HLS manifests, so that test can't be done with the Invidious API enabled, all others can.
50/25fps https://youtu.be/U4DVfOmcwuk
60/30fps https://youtu.be/HJDMo__4JAg
30fps https://youtu.be/g7oNuP83VXs
live 30fps (144p is 15fps) https://youtu.be/jfKfPfyJRdk
Desktop