Fix some translation entries sometimes not used when rendered #3337

PikachuEXE · 2023-03-21T02:07:11Z

Pull Request Type

Bugfix
Feature Implementation
Documentation
Other

Related issue

Found this issue when testing #3327

Description

Screenshots

Before

After

Testing

Go https://youtube.com/live
Find a stream with live chat but no comment (e.g. Pick one from https://www.youtube.com/@KTN_news)
Watch it to ensure the translation entry for live chat Live chat is enabled. Chat messages will appear here once sent. is translated

Desktop

OS: 12.6.3
OS Version: MacOS
FreeTube version: 2f87fff

Additional context

efb4f5ff-1298-471a-8973-3d47447115dc · 2023-03-21T23:12:29Z

Now im having trouble with finding streams with no comments :(

PikachuEXE · 2023-03-22T01:00:51Z

I just test again and picked one from https://www.youtube.com/@KTN_news
Testing section updated

ChunkyProgrammer · 2023-03-22T02:31:23Z

Is this related to #3101 ?

PikachuEXE · 2023-03-22T02:50:05Z

@ChunkyProgrammer
Yes
If I turn off #3101 then it also works
I guess either only the key in code or only the key in generated translation file got whitespace condensed

static/locales/ar.yaml

absidue · 2023-03-22T14:40:44Z

static/locales/ar.yaml

@@ -831,10 +831,10 @@ Shuffle is now disabled: 'تم تعطيل التبديل العشوائي'
 Shuffle is now enabled: 'تم تمكين التبديل العشوائي'
 Playing Next Video: 'جاري تشغيل الفيديو التالي'
 Playing Previous Video: 'جاري تشغيل الفيديو السابق'
-Playing next video in 5 seconds.  Click to cancel: 'سيتم تشغيل الفيديو التالي في 5
+Playing next video in 5 seconds. Click to cancel: 'سيتم تشغيل الفيديو التالي في 5


I can't find any reference to this string in the code, so it can probably be removed.

PikachuEXE · 2023-03-23T01:07:39Z

Updated code reference for This profile has a large number of subscriptions. Forcing RSS to avoid rate limiting
Removed unused entry

github-actions · 2023-03-23T02:47:05Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2023-03-23T02:54:54Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions · 2023-03-23T09:44:13Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2023-03-24T01:22:36Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

efb4f5ff-1298-471a-8973-3d47447115dc

BUG🐛

VirtualBoxVM_1520ilgQqk.mp4

github-actions · 2023-04-03T21:24:27Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

PikachuEXE · 2023-04-04T01:01:09Z

Me crying

github-actions · 2023-04-04T06:11:21Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions · 2023-04-04T08:06:56Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Avoid not being translated when rendering

github-actions · 2023-04-04T09:37:03Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

PikachuEXE · 2023-04-08T06:25:06Z

@efb4f5ff-1298-471a-8973-3d47447115dc

efb4f5ff-1298-471a-8973-3d47447115dc · 2023-04-08T22:39:27Z

rip cant find a good stream to test this :(

* development: Add 50fps and live support to frame by frame keyboard shortcuts (FreeTubeApp#3420) Remove invidious.namazso.eu in dev branch (FreeTubeApp#3425) Cleanup polyfills (FreeTubeApp#3383) Small community post fixes (FreeTubeApp#3401) Bump rimraf from 4.4.1 to 5.0.0 (FreeTubeApp#3409) Bump peter-evans/create-pull-request from 4 to 5 (FreeTubeApp#3414) Bump eslint from 8.37.0 to 8.38.0 (FreeTubeApp#3416) Bump lefthook from 1.3.8 to 1.3.9 (FreeTubeApp#3410) Bump webpack from 5.77.0 to 5.78.0 (FreeTubeApp#3411) Bump youtubei.js from 4.1.1 to 4.2.0 (FreeTubeApp#3412) Bump sass from 1.60.0 to 1.61.0 (FreeTubeApp#3413) Update Channel age restricted key (FreeTubeApp#3237) Fix some translation entries sometimes not used when rendered (FreeTubeApp#3337) Reset current chapter index when changing videos (FreeTubeApp#3400)

PikachuEXE mentioned this pull request Mar 21, 2023

Show message when the live chat is unavailable #3327

Merged

1 task

FreeTubeBot enabled auto-merge (squash) March 21, 2023 02:07

github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Mar 21, 2023

PikachuEXE requested review from absidue, ChunkyProgrammer and efb4f5ff-1298-471a-8973-3d47447115dc March 21, 2023 02:07

ChunkyProgrammer previously approved these changes Mar 22, 2023

View reviewed changes

efb4f5ff-1298-471a-8973-3d47447115dc previously approved these changes Mar 22, 2023

View reviewed changes

absidue reviewed Mar 22, 2023

View reviewed changes

PikachuEXE dismissed stale reviews from efb4f5ff-1298-471a-8973-3d47447115dc and ChunkyProgrammer via 3bc7484 March 23, 2023 01:07

github-actions bot added PR: merge conflicts / rebase needed and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Mar 23, 2023

PikachuEXE force-pushed the fix/translation-keys-extra-space branch from 3bc7484 to 70ef107 Compare March 23, 2023 02:54

github-actions bot removed the PR: merge conflicts / rebase needed label Mar 23, 2023

github-actions bot added the PR: merge conflicts / rebase needed label Mar 23, 2023

PikachuEXE force-pushed the fix/translation-keys-extra-space branch from 70ef107 to 4d11836 Compare March 24, 2023 01:22

github-actions bot removed the PR: merge conflicts / rebase needed label Mar 24, 2023

efb4f5ff-1298-471a-8973-3d47447115dc added the PR: waiting for review For PRs that are complete, tested, and ready for review label Mar 25, 2023

efb4f5ff-1298-471a-8973-3d47447115dc requested changes Mar 25, 2023

View reviewed changes

efb4f5ff-1298-471a-8973-3d47447115dc removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Mar 25, 2023

ChunkyProgrammer previously approved these changes Apr 2, 2023

View reviewed changes

github-actions bot added PR: merge conflicts / rebase needed and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Apr 3, 2023

PikachuEXE dismissed stale reviews from ChunkyProgrammer and absidue via 1b5f5a1 April 4, 2023 06:11

PikachuEXE force-pushed the fix/translation-keys-extra-space branch from d6b603b to 1b5f5a1 Compare April 4, 2023 06:11

github-actions bot added PR: merge conflicts / rebase needed and removed PR: merge conflicts / rebase needed labels Apr 4, 2023

PikachuEXE added 2 commits April 4, 2023 17:36

* Update all translation keys with 2 spaces to have 1 space only

e6f59b6

Avoid not being translated when rendering

- Remove unused translation entry

0a7a128

PikachuEXE force-pushed the fix/translation-keys-extra-space branch from 1b5f5a1 to 0a7a128 Compare April 4, 2023 09:36

github-actions bot removed the PR: merge conflicts / rebase needed label Apr 4, 2023

PikachuEXE requested review from absidue, efb4f5ff-1298-471a-8973-3d47447115dc and ChunkyProgrammer and removed request for efb4f5ff-1298-471a-8973-3d47447115dc April 4, 2023 09:37

absidue approved these changes Apr 7, 2023

View reviewed changes

ChunkyProgrammer approved these changes Apr 7, 2023

View reviewed changes

efb4f5ff-1298-471a-8973-3d47447115dc added the PR: waiting for review For PRs that are complete, tested, and ready for review label Apr 8, 2023

efb4f5ff-1298-471a-8973-3d47447115dc approved these changes Apr 8, 2023

View reviewed changes

FreeTubeBot merged commit 454534a into FreeTubeApp:development Apr 8, 2023

github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Apr 8, 2023

Fix some translation entries sometimes not used when rendered #3337

Fix some translation entries sometimes not used when rendered #3337

Uh oh!

Conversation

PikachuEXE commented Mar 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Type

Related issue

Description

Screenshots

Testing

Desktop

Additional context

Uh oh!

efb4f5ff-1298-471a-8973-3d47447115dc commented Mar 21, 2023

Uh oh!

PikachuEXE commented Mar 22, 2023

Uh oh!

ChunkyProgrammer commented Mar 22, 2023

Uh oh!

PikachuEXE commented Mar 22, 2023

Uh oh!

Uh oh!

absidue Mar 22, 2023

Choose a reason for hiding this comment

Uh oh!

PikachuEXE commented Mar 23, 2023

Uh oh!

github-actions bot commented Mar 23, 2023

Uh oh!

github-actions bot commented Mar 23, 2023

Uh oh!

github-actions bot commented Mar 23, 2023

Uh oh!

github-actions bot commented Mar 24, 2023

Uh oh!

efb4f5ff-1298-471a-8973-3d47447115dc left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 3, 2023

Uh oh!

PikachuEXE commented Apr 4, 2023

Uh oh!

github-actions bot commented Apr 4, 2023

Uh oh!

github-actions bot commented Apr 4, 2023

Uh oh!

github-actions bot commented Apr 4, 2023

Uh oh!

PikachuEXE commented Apr 8, 2023

Uh oh!

efb4f5ff-1298-471a-8973-3d47447115dc commented Apr 8, 2023

Uh oh!

Uh oh!

PikachuEXE commented Mar 21, 2023 •

edited

Loading