-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Allow Unsubscribing from Deleted Channels #2283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Unsubscribing from Deleted Channels #2283
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
errorChannels_section_disappears.mp4
seems to be an issue with having fallbacks enabled, I'll look into that. Edit: nvm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like how u have implemented this PR. LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few suggestions, happy to discuss the "Error Channels" vs "channels with errors". I don't have any channels with erros so I can't test this, however the rest of the code looks good to me.
Co-authored-by: absidue <[email protected]>
Co-authored-by: absidue <[email protected]>
If you want to test this, I included a txt file in additional context (if you change the extension to db then you should be able to import the subscription) |
Co-Authored-By: absidue <[email protected]> Co-Authored-By: PikachuEXE <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything LGTM! @ChunkyProgrammer I have one last question though before i approve. I know that only using the Invidious API doesnt show the blocked channels banner. Is it possible to show the banner when the Invidious API is primary and u have a fallback to the Local API?
This won't happen. Invidious only returns an empty video list when rss is not being used and won't throw an error so it won't fallback. I don't think adding channels with no videos to the error list would be the best idea. Clicking on the channel on the side will still allow them to unsubscribe they just won't be notified of that channel causing errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fair. LGTM!
Allow Unsubscribing from Deleted Channels
Pull Request Type
Please select what type of pull request this is:
Related issue
closes #2133
closes #1231
closes #1590
closes #555
Description
This PR will try to find channels that may have been deleted when your subscriptions get loaded (except when using Invidious that's not in RSS) and it allows you to load the subscription information that is saved when viewing a channel page
Screenshots (if appropriate)

Testing (for code that is not small enough to be easily understandable)
Has this pull request been testedZ
I was able to get the links of two channels that were deleted for different reasons and I tested:
refreshing the Subscription page with
I also tested navigating to the channels with invidious and local api and was able to unsubscribe
Desktop (please complete the following information):
Additional context
Test Subscription File (change extension from txt to db):
Test Subscriptions.txt