Skip to content

Allow Unsubscribing from Deleted Channels #2283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ChunkyProgrammer
Copy link
Member

@ChunkyProgrammer ChunkyProgrammer commented Jun 1, 2022


Allow Unsubscribing from Deleted Channels

Pull Request Type
Please select what type of pull request this is:

  • Bugfix
  • Feature Implementation

Related issue
closes #2133
closes #1231
closes #1590
closes #555

Description
This PR will try to find channels that may have been deleted when your subscriptions get loaded (except when using Invidious that's not in RSS) and it allows you to load the subscription information that is saved when viewing a channel page

Screenshots (if appropriate)
image

image

Testing (for code that is not small enough to be easily understandable)
Has this pull request been testedZ

I was able to get the links of two channels that were deleted for different reasons and I tested:
refreshing the Subscription page with

  • Local API + RSS
  • Local API + RSS Disabled
  • Invidious + RSS
  • Invidious + RSS Disabled (not currently useful)

I also tested navigating to the channels with invidious and local api and was able to unsubscribe

Desktop (please complete the following information):

  • OS: Windows
  • OS Version: 10
  • FreeTube version: 0.16.0

Additional context
Test Subscription File (change extension from txt to db):
Test Subscriptions.txt

@PrestonN PrestonN enabled auto-merge (squash) June 1, 2022 02:58
@ChunkyProgrammer ChunkyProgrammer added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 1, 2022
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

errorChannels_section_disappears.mp4

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Jun 1, 2022
@ChunkyProgrammer
Copy link
Member Author

ChunkyProgrammer commented Jun 1, 2022

seems to be an issue with having fallbacks enabled, I'll look into that. Edit: nvm

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like how u have implemented this PR. LGTM!

Copy link
Member

@absidue absidue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few suggestions, happy to discuss the "Error Channels" vs "channels with errors". I don't have any channels with erros so I can't test this, however the rest of the code looks good to me.

@ChunkyProgrammer
Copy link
Member Author

I left a few suggestions, happy to discuss the "Error Channels" vs "channels with errors". I don't have any channels with erros so I can't test this, however the rest of the code looks good to me.

If you want to test this, I included a txt file in additional context (if you change the extension to db then you should be able to import the subscription)

@ChunkyProgrammer ChunkyProgrammer added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: changes requested labels Jun 3, 2022
absidue
absidue previously approved these changes Jun 3, 2022
Co-Authored-By: absidue <[email protected]>
Co-Authored-By: PikachuEXE <[email protected]>
Copy link
Member

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything LGTM! @ChunkyProgrammer I have one last question though before i approve. I know that only using the Invidious API doesnt show the blocked channels banner. Is it possible to show the banner when the Invidious API is primary and u have a fallback to the Local API?

@ChunkyProgrammer
Copy link
Member Author

Everything LGTM! @ChunkyProgrammer I have one last question though before i approve. I know that only using the Invidious API doesnt show the blocked channels banner. Is it possible to show the banner when the Invidious API is primary and u have a fallback to the Local API?

This won't happen. Invidious only returns an empty video list when rss is not being used and won't throw an error so it won't fallback. I don't think adding channels with no videos to the error list would be the best idea. Clicking on the channel on the side will still allow them to unsubscribe they just won't be notified of that channel causing errors

@PrestonN PrestonN merged commit da095ad into FreeTubeApp:development Jun 3, 2022
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fair. LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants