Skip to content

fix: Avoid properties added in dart_style v2.3.7 #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix: Avoid properties added in dart_style v2.3.7 #652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be49371
fix: Avoid properties added in dart_style v2.3.7
koji-1009 Feb 8, 2025
71bffb4
fix: dart_style: '>=2.2.4 <3.0.0'
koji-1009 Feb 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/core/lib/flutter_generator.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ class FlutterGenerator {
final output = config.pubspec.flutterGen.output;
final lineLength = config.pubspec.flutterGen.lineLength;
final formatter = DartFormatter(
languageVersion: DartFormatter.latestLanguageVersion,
pageWidth: lineLength,
lineEnding: '\n',
);
Expand Down
2 changes: 1 addition & 1 deletion packages/core/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ dependencies:
json_annotation: ^4.4.0
glob: ^2.0.0

dart_style: '>=2.2.4 <4.0.0'
dart_style: '>=2.2.4 <3.0.0'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. I had overlooked that languageVersion is optional in v2.3.7 but requierd in v3.0.0.

https://github.com/dart-lang/dart_style/blob/v2.3.7/lib/src/dart_formatter.dart#L83
https://github.com/dart-lang/dart_style/blob/v3.0.0/lib/src/dart_formatter.dart#L82

archive: '>=3.4.0 <5.0.0'
args: ^2.0.0
pub_semver: ^2.0.0
Expand Down
1 change: 0 additions & 1 deletion packages/core/test/assets_gen_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ void main() {
final pubspec = File('test_resources/pubspec_assets_no_list.yaml');
final config = loadPubspecConfig(pubspec);
final formatter = DartFormatter(
languageVersion: dartFormatterLanguageVersion,
pageWidth: config.pubspec.flutterGen.lineLength,
lineEnding: '\n',
);
Expand Down
2 changes: 0 additions & 2 deletions packages/core/test/colors_gen_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ void main() {
final pubspec = File('test_resources/pubspec_colors_no_inputs.yaml');
final config = loadPubspecConfig(pubspec);
final formatter = DartFormatter(
languageVersion: dartFormatterLanguageVersion,
pageWidth: config.pubspec.flutterGen.lineLength,
lineEnding: '\n',
);
Expand All @@ -42,7 +41,6 @@ void main() {
final pubspec = File('test_resources/pubspec_colors_no_inputs_list.yaml');
final config = loadPubspecConfig(pubspec);
final formatter = DartFormatter(
languageVersion: dartFormatterLanguageVersion,
pageWidth: config.pubspec.flutterGen.lineLength,
lineEnding: '\n',
);
Expand Down
1 change: 0 additions & 1 deletion packages/core/test/fonts_gen_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ void main() {
File('test_resources/pubspec_fonts_no_family.yaml'),
);
final formatter = DartFormatter(
languageVersion: dartFormatterLanguageVersion,
pageWidth: config.pubspec.flutterGen.lineLength,
lineEnding: '\n',
);
Expand Down
5 changes: 0 additions & 5 deletions packages/core/test/gen_test_helper.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ import 'package:flutter_gen_core/settings/config.dart';
import 'package:path/path.dart' as p;
import 'package:test/test.dart';

final dartFormatterLanguageVersion = DartFormatter.latestLanguageVersion;

Future<void> clearTestResults() async {}

Future<List<String>> runAssetsGen(
Expand All @@ -36,7 +34,6 @@ Future<List<String>> runAssetsGen(
stdout.writeln('[DEBUG] test: Generate from API...');
final config = loadPubspecConfig(pubspecFile, buildFile: buildFile);
final formatter = DartFormatter(
languageVersion: dartFormatterLanguageVersion,
pageWidth: config.pubspec.flutterGen.lineLength,
lineEnding: '\n',
);
Expand Down Expand Up @@ -80,7 +77,6 @@ Future<List<String>> runColorsGen(
final pubspecFile = File(pubspec);
final config = loadPubspecConfig(pubspecFile);
final formatter = DartFormatter(
languageVersion: dartFormatterLanguageVersion,
pageWidth: config.pubspec.flutterGen.lineLength,
lineEnding: '\n',
);
Expand Down Expand Up @@ -124,7 +120,6 @@ Future<List<String>> runFontsGen(
final pubspecFile = File(pubspec);
final config = loadPubspecConfig(pubspecFile);
final formatter = DartFormatter(
languageVersion: dartFormatterLanguageVersion,
pageWidth: config.pubspec.flutterGen.lineLength,
lineEnding: '\n',
);
Expand Down
Loading