-
-
Notifications
You must be signed in to change notification settings - Fork 168
fix: Avoid properties added in dart_style v2.3.7 #652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We have two options to solve the problem, as I thought:
If 1 is inapplicable, then we should go with 2. |
And 3: raise the constraint to |
@@ -24,7 +24,7 @@ dependencies: | |||
json_annotation: ^4.4.0 | |||
glob: ^2.0.0 | |||
|
|||
dart_style: '>=2.2.4 <4.0.0' | |||
dart_style: '>=2.2.4 <3.0.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry. I had overlooked that languageVersion
is optional in v2.3.7 but requierd in v3.0.0.
https://github.com/dart-lang/dart_style/blob/v2.3.7/lib/src/dart_formatter.dart#L83
https://github.com/dart-lang/dart_style/blob/v3.0.0/lib/src/dart_formatter.dart#L82
I'm closing this as #653 should resolve the issue without removing the field. Thanks for the contribution! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #652 +/- ##
=========================================
- Coverage 97.55% 0 -97.56%
=========================================
Files 21 0 -21
Lines 819 0 -819
=========================================
- Hits 799 0 -799
+ Misses 20 0 -20 ☔ View full report in Codecov by Sentry. |
What does this change?
Removed
DartFormatter.latestLanguageVersion
and modified it to work with dart_style 2.2.4.Fixes #651 🎯
Type of change
Please delete options that are not relevant.
Checklist:
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
melos run test
)melos run format
to automatically apply formatting)