-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Move the user is typing and other metadata back below the composer box #9276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
npm has a |
1 similar comment
npm has a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have 2 questions, but they aren't blockers, and overall it looks great. Thanks!
@neil-marcellini Thanks for the review, I responded, let me know if you happy with it and we can merge. |
Yep, good to go! Merging. |
Thanks! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @neil-marcellini in version: 1.1.72-0 🚀
|
🚀 Deployed to production by @yuwenmemon in version: 1.1.73-2 🚀
|
Thanks for the review!
Basically, this does not introduce much of a new code. I am just reverting these 2 PRs:
But I am keeping some things from the original refactoring as its own component for the
OfflineIndicator
as that is handy.Details
We have decided to move the metadata back to above and below the composer box and make sure that the text is vertically aligned.
I am still using some of the refactoring introduced when the changes were made as they seemed appropriate and handy.
Fixed Issues
$ #9251
Tests / QA Steps
First set of test
Second set of tests
Third set of tests
go offline
make sure the offline indicator appears below the composer box
Copy some large text and paste it in so that you get more than 60000 character
Confirm that the maximum character limit message shows up below the composer box too
Verify that no errors appear in the JS console
Screenshots
Group chat - notice the padding at the bottom of the chat to the composer box is back to normal:

Web
Mobile Web
Desktop
iOS
Android