Skip to content

Padding seems off for the latest message with the typing indicator moved to the top #9251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mvtglobally opened this issue May 31, 2022 · 6 comments
Assignees
Labels
Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review Weekly KSv2

Comments

@mvtglobally
Copy link

mvtglobally commented May 31, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Open any chat
  2. check padding below last chat and compose box

Expected Result:

We should have the metadata above and below the compose box as before and make sure it is vertically aligned. Decided in Slack here.

Actual Result:

Padding seems too high for the latest message with the typing indicator moved to the top

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web

Version Number: 1.1.69-2
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

image

Expensify/Expensify Issue URL:
Issue reported by: @AndrewGable
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1653937814767159

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented May 31, 2022

Triggered auto assignment to @mountiny (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label May 31, 2022
@melvin-bot
Copy link

melvin-bot bot commented May 31, 2022

Triggered auto assignment to @arielgreen (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@mountiny
Copy link
Contributor

I could find that this is related to two PRs recently

I dont think this needs to be a deploy blocker since it is mainly a small styling problem.

@mountiny mountiny removed the External Added to denote the issue can be worked on by a contributor label May 31, 2022
@mountiny
Copy link
Contributor

Sorry @arielgreen for the ping, I will actually wait to first refine how it should look like exactly and all the expected behaviours as there seems to be some discussion about it in the Slack thread.

@mountiny mountiny added Weekly KSv2 and removed Daily KSv2 labels Jun 1, 2022
@mountiny
Copy link
Contributor

mountiny commented Jun 1, 2022

Making this weekly for now, we need to find some consensus on what would be the best way to render these.

image
from #9205

@mountiny
Copy link
Contributor

mountiny commented Jun 1, 2022

Asked in Slack here, giving it some time.

We would like to get it close to this state #9094, but I will try to keep the refacotring that Tim has introduced in here #9095

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants