Skip to content

Match status bar color in android with the background of app #7751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

sobitneupane
Copy link
Contributor

Details

Solves the issue "Android - Status bar color is not same as the main background color"

Fixed Issues

$ #7075

Tests

  • Open App and compare background color of the app with status bar.
  • Go to settings page and compare background color of the app with status bar.

QA Steps

  • Open App and compare background color of the app with status bar.
  • Go to settings page and compare background color of the app with status bar.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

LHN Settings

Android

LHN Settings

@sobitneupane sobitneupane requested a review from a team as a code owner February 15, 2022 07:10
@MelvinBot MelvinBot requested review from deetergp and rushatgabhane and removed request for a team February 15, 2022 07:10
Copy link
Member

@rushatgabhane rushatgabhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deetergp LGTM! 💪

Copy link
Contributor

@deetergp deetergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and does the job. Thanks!

@deetergp deetergp merged commit a98df64 into Expensify:main Feb 15, 2022
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @deetergp in version: 1.1.40-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Mar 1, 2022

🚀 Deployed to production by @yuwenmemon in version: 1.1.40-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants