Skip to content

Deploy Checklist: New Expensify 2022-02-23 #7883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
69 tasks done
OSBotify opened this issue Feb 23, 2022 · 28 comments
Closed
69 tasks done

Deploy Checklist: New Expensify 2022-02-23 #7883

OSBotify opened this issue Feb 23, 2022 · 28 comments
Assignees
@applausebot
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Feb 23, 2022 •
edited by yuwenmemon
Loading

Release Version: 1.1.40-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

cc @Expensify/applauseleads
@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Feb 23, 2022
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.40-0 🚀

@luacmartins
Copy link
Contributor

I'm confused. I thought we had checked #7802 off the list yesterday. Checking it off again.

@mountiny
Copy link
Contributor

@luacmartins Yes! See created issue above! or here 😄

@nickmurray47
Copy link
Contributor

nickmurray47 commented Feb 24, 2022 •
edited by thienlnam
Loading

Going to check off #7663 for now since we will actually need to test on Prod and @thienlnam and I will test once it's there.

@nkuoch
Copy link
Contributor

nkuoch commented Feb 24, 2022

Checked off #7812

@mvtglobally
Copy link

Regression is completed
Deploy Blocker
#7900
#7888 - unable to verify in PROD, so added blocker label.

PRs failing
#7459 Issue raised #7884 - Checking off
#7633 - Not fixed #7633 (comment)
#7748 is failing due to #7888.
#7765 is failing #7928. We may need a new Staging build to re-verify this issue

Internal QA
#7766 (comment)

Additional issues logged
#7885
#7893
#7899
#7903
#7919

@marcaaron
Copy link
Contributor

checked #7888 as the issue was closed.

@MelvinBot MelvinBot added the Monthly KSv2 label Feb 28, 2022
@roryabraham
Copy link
Contributor

We identified that #7900 was caused by #7723 (shoutout to @kidroca for pointing this out), and as such a revert PR for #7723 is being CP'd to staging.

@roryabraham
Copy link
Contributor

Before shipping this deploy, I think we'll want to revert #7633 because it failed QA.

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.40-1 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.40-1 has been deployed to staging 🎉

@mvtglobally
Copy link

@roryabraham aside of retesting blocker, How should be confirm issue is reverted? Just check if loading is no longer appearing?

@roryabraham
Copy link
Contributor

@mvtglobally You shouldn't really need to verify anything beyond the fix for the deploy blocker. But if you want to, then yes checking if the loading spinner on uploading attachments is no longer appearing should be sufficient.

@mvtglobally
Copy link

@roryabraham #7900 is fixed

@yuwenmemon
Copy link
Contributor

Checking off #7663 because it is productionQA

@yuwenmemon
Copy link
Contributor

Checking off #7752 because even though it is not working, it is not a blocker: #7752 (comment)

@yuwenmemon
Copy link
Contributor

Checking off #7765 because it is not a blocker (see #7928 (comment))

@roryabraham
Copy link
Contributor

Just merged a revert for #7633

@OSBotify
Copy link
Contributor Author

OSBotify commented Mar 1, 2022

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.40-2 🚀

@OSBotify
Copy link
Contributor Author

OSBotify commented Mar 1, 2022

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.40-2 has been deployed to staging 🎉

@yuwenmemon
Copy link
Contributor

Checking off #7633 because it was reverted

@yuwenmemon
Copy link
Contributor

@mvtglobally Looks like we just need to re-QA #7748! Any update on that?

@mvtglobally
Copy link

@yuwenmemon will have update early in the morning on this retest

@mvtglobally
Copy link

Checking off #7748 (comment)

@yuwenmemon
Copy link
Contributor

Thanks! Just ran the accessibility check-off train

@yuwenmemon
Copy link
Contributor

:shipit:

@Stutikuls
Copy link

Stutikuls commented Mar 9, 2022 •
edited
Loading

Checked all PRs and added comments on all PRs where accessibility issue were found.
The non-applicable PRs are - #7565, #7522, #7742, #7748, #7751, #7762

@SumitDiyora
Copy link

SumitDiyora commented Mar 15, 2022 •
edited
Loading

Checked all PRs and added comments to all PRs where accessibility issues were found.
The non-applicable PRs are - #7765, #7771, #7782, #7817, #7819, #7828, #7830, #7845, #7865
Impossibility to verify (After client confirmation) #7812

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@applausebot applausebot

Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests