Skip to content

Adding support for chunked chats #6673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 10, 2021
Merged

Adding support for chunked chats #6673

merged 6 commits into from
Dec 10, 2021

Conversation

danieldoglas
Copy link
Contributor

Details

Adding new events for pusher with chunked push notifications.

Fixed Issues

$ #3797

Tests

  1. Run new.E locally pointing to production Web-E
  2. Open two different accounts and start a chat with each other
  3. Write (or paste) any messages that are bigger than 10240 characters
  4. Verify that the message will appear for the receiver without needing to reload the chat.

QA Steps

  1. Run new.E locally pointing to production Web-E
  2. Open two different accounts and start a chat with each other
  3. Write (or paste) any messages that are bigger than 10240 characters
  4. Verify that the message will appear for the receiver without needing to reload the chat.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web/Desktop/iOS/Android

Screen.Recording.2021-12-09.at.15.48.03.mov

@danieldoglas danieldoglas requested a review from a team as a code owner December 9, 2021 18:53
@danieldoglas danieldoglas changed the title Added new treatments for chunked-reportComment and chunked-reportComm… Adding support for chunked chats Dec 9, 2021
@MelvinBot MelvinBot requested review from yuwenmemon and removed request for a team December 9, 2021 18:53
@danieldoglas danieldoglas self-assigned this Dec 9, 2021
@danieldoglas danieldoglas added the Improvement Item broken or needs improvement. label Dec 9, 2021
@danieldoglas
Copy link
Contributor Author

Fixed JS Lints.

yuwenmemon
yuwenmemon reviewed Dec 9, 2021
View reviewed changes
Copy link
Contributor

@yuwenmemon yuwenmemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! But one question for ya

@danieldoglas
Copy link
Contributor Author

Fixed flag for comment edit.

@yuwenmemon yuwenmemon merged commit 4c8a8ba into main Dec 10, 2021
@yuwenmemon yuwenmemon deleted the dsilva-chunkedPushs branch December 10, 2021 18:55
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

parasharrajat
parasharrajat reviewed Dec 10, 2021
View reviewed changes
Copy link
Member

@parasharrajat parasharrajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should also clean the duplicate call at L149 in pusher.js.

@OSBotify OSBotify mentioned this pull request Dec 10, 2021
Closed
38 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @yuwenmemon in version: 1.1.19-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@kavimuru kavimuru mentioned this pull request Dec 11, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Julesssss in version: 1.1.21-1 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parasharrajat parasharrajat parasharrajat left review comments

@yuwenmemon yuwenmemon yuwenmemon approved these changes

Assignees

@danieldoglas danieldoglas

Labels
Improvement Item broken or needs improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danieldoglas @OSBotify @yuwenmemon @parasharrajat