Skip to content

Chat - Message that are bigger than 10240 characters does not appear without reload #6710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kavimuru opened this issue Dec 11, 2021 · 15 comments
Assignees

Comments

@kavimuru
Copy link

kavimuru commented Dec 11, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue was found when executing #6673

Action Performed:

  1. Launch the app and login
  2. Open two different accounts and start a chat with each other
  3. Write any messages that are bigger than 10240 characters

Expected Result:

Verify that the message will appear for the receiver without needing to reload the chat.

Actual Result:

The message will appear for the receiver after reload of the chat.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.20-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Recording.1156.mp4

Issue was found when executing #6673

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Dec 11, 2021
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @mountiny (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@mountiny
Copy link
Contributor

I think this is quite edge case so it does not have to be a deploy blocker. Gonna remove the label and make this an External issue

@mountiny mountiny added External Added to denote the issue can be worked on by a contributor Weekly KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Dec 11, 2021
@MelvinBot
Copy link

Triggered auto assignment to @NicMendonca (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@MelvinBot MelvinBot added Daily KSv2 and removed Weekly KSv2 labels Dec 11, 2021
@mountiny
Copy link
Contributor

cc @danieldoglas as it is related to the issue you worked on: #3797

It should not work on production as the linked PR has been only deployed only to staging so far, but the issue body says it also happens in Staging.

@mountiny mountiny removed the External Added to denote the issue can be worked on by a contributor label Dec 12, 2021
@mountiny mountiny self-assigned this Dec 12, 2021
@mountiny mountiny added the Weekly KSv2 label Dec 12, 2021
@mountiny
Copy link
Contributor

Sorry @NicMendonca for a ping, upon further investigation, this should not be external yet. This issue is about merged PR not behaving as expected.

@mountiny mountiny removed the Daily KSv2 label Dec 12, 2021
@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@danieldoglas
Copy link
Contributor

Thanks for tagging me @mountiny .

@mvtglobally , you could not reproduce this issue too? I downloaded the branch and it was working as expected.

@mvtglobally
Copy link

mvtglobally commented Dec 15, 2021

@danieldoglas i was able to repro the issue on Desktop app yesterday with the build 1.1.20-2. It seems to be inconsistent and not always repro.
See tread https://expensify.slack.com/archives/C01GTK53T8Q/p1639532748263800

@mountiny mountiny assigned danieldoglas and unassigned mountiny Dec 15, 2021
@mountiny
Copy link
Contributor

Assigning Daniel after chatting in DM together.

@danieldoglas
Copy link
Contributor

Ok, so I just downloaded the latest code in Main and tested this locally to check if it was happening.

This video has the production verion (1.18) and the one in Mani (1.21).

Seems to be working as expected.

Screen.Recording.2021-12-15.at.18.32.37.mov

Also, testing staging.new.expensify produced the same results:

Screen.Recording.2021-12-15.at.18.36.20.mov

I'll try to install the specific version you're testing.

@danieldoglas
Copy link
Contributor

@mvtglobally Can you run a quick test for me? Can you logout and login the application again and see if this continues?
I may have found the reason.

@mvtglobally
Copy link

@danieldoglas, sorry missed this earlier. I am still able to reproduce this issue after log out.

@danieldoglas
Copy link
Contributor

I see.

Seems like we've deployed version 1.1.22 version in prod now. I just tested the Lorem Ipsum generated text and it did work. I've tried from 10 to 50 thousand bytes.

For some reason I cant simulate what's happening to you. Are you trying a specific text, or any text with 10240+ chars are not working for you?

if it's a specific test, can you provide it so I can see if it's something specific?

@danieldoglas danieldoglas added the Monthly KSv2 label Jan 4, 2022
@MelvinBot MelvinBot removed the Overdue label Jan 4, 2022
@danieldoglas danieldoglas removed the Weekly KSv2 label Jan 4, 2022
@danieldoglas
Copy link
Contributor

@mvtglobally please tell me if this continues happening. I'm changing it to monthly for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants