Suggested Search

[JS00001]

Explanation of Change

Implemented suggested search! See below for the expected behavior.

Fixed Issues

$ #61112
$ #61114
$ #61116
$ #61117
$ #61189

Tests

Test all variations of search. The following are supposed to be in the LHN:
Expenses, Reports, Chats: Always in LHN
'Submit' - Only in LHN when user is in a workspace
'Approve' - Only when a user is the policys 'approver', OR the user is the 'submitsTo' value for another user
'Pay' - Only when the user is a workspace admin
'Export' - Only when the user is an exporter for one of the accounting integrations

Ensure that all expected results show up, ensure that all new 'filter dropdowns' show the expected behavior and behave as expected, ensure that the new 'Filters' button works & has the expected behavior

Similarly, the following should be tested and verified to be working/not broken or buggy:

• Opening the 'From' dropdown in search on mobile, including native, safari, and chrome. This should especially be verified when focusing the search input. Test with no users, a bunch of users to search, selecting users, unselecting users, filtering users down to a smaller list, etc.
• Ensure when the keyboard is visible in the 'From' dropdown, that you can still select a user and keep the keyboard open.
• Ensure that when theres a lot of thing selected in the filter chips, that the caret never overflows on native mobile.
• Ensure the 'From' dropdown includes your own email
• Ensure that when we follow the following steps are taken: Search > Submit (Suggested search item) > Change 'Type' to 'Chat', that 'group-by:reports' gets cleared
• Ensure that when using 'group-by:reports', the 'unreported' status does not show in the dropdown
• Ensure that Searches 'clear' button is not visible when there is no text visible in the searchbar
• Ensure that typing random strings like ajnsdjkaskj and then clicking the 'clear' button actually clears the input
• Ensure that when saving a suggested search as a saved search, that only one is highlighted at a time. The saved search should take priority to be highlighted.

• Verify that no errors appear in the JS console

QA Steps

Same as Tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I verified that similar component doesn't exist in the codebase
• I verified that all props are defined accurately and each prop has a /** comment above it */
• I verified that each file is named correctly
• I verified that each component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
• I verified that the only data being stored in component state is data necessary for rendering and nothing else
• In component if we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
• For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
• I verified that component internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
• I verified that all JSX used for rendering exists in the render method
• I verified that each component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

Screenshots/Videos

Android: Native

iOS: Native

Screen.Recording.2025-05-09.at.11.59.29.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-05-09.at.11.42.49.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-05-09.at.11.35.58.AM.mov

[melvin-bot]

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

[melvin-bot]

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[github-actions]

🚧 @JS00001 has triggered a test app build. You can view the workflow run here.

[dubielzyk-expensify]

Wow this is very exciting 😄

I'll get started on some, but I'm sure @Expensify/design will find other things.

The mobile menu has one of the section headlines in bold (it should be regular and this doesn't happen on desktop):

[getusha]

blockers i am able to reproduce:

#62679

Screen.Recording.2025-05-28.at.8.28.55.in.the.evening.mov

#62735

Screen.Recording.2025-05-28.at.8.32.00.in.the.evening.mov

#62697

Screen.Recording.2025-05-28.at.9.42.32.at.night.mov

[JS00001]

#62679 and #62697 we decided to ignore, I'm looking at the third

The other issue I just pushed a fix for

[jponikarchuk]

Reports - Search panel automatically closes on tapping Reset button

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.51-9 Adhoc
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught during regression testing, add the test name, ID and link from TestRail: Exploratory
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Windows 11/Chrome, iPhone 16/iOS 18.3.1, Pixel 8a/Android 15
App Component: undefined

Action Performed:

1. Navigate to https://62851.pr-testing.expensify.com/ or launch hybrid app
2. Log in with an account that has a long list of contacts (Expensifail account).
3. Go to Reports.
4. Tap on From filter
5. Tap on Search field
6. Enter few keywords to search some users (Or select few users from the list displayed)
7. Tap on Reset button

Expected Result:

Tapping on Reset button should clear the search field (or should uncheck the selected users) & the search panel should remain opened so user can continue perform searching other users.

Actual Result:

Search panel automatically closes on tapping Reset button

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

[jponikarchuk]

Reports - Search field gets hidden at top, not easily accessible

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.51-9 Adhoc
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught during regression testing, add the test name, ID and link from TestRail: Exploratory
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: iPhone 16/iOS 18.3.1/Safari & Pixel 8a/Android 15/Chrome
App Component: undefined

Action Performed:

1. Navigate to https://62851.pr-testing.expensify.com/
2. Log in with an account that has a long list of contacts (Expensifail account).
3. Go to Reports.
4. Tap on From filter
5. Tap on Search field (Note: Search field gets hidden at top)
6. Tap on done button on keypad
7. Tap on search field again
8. Try scrolling the panel to access the search field

Expected Result:

Search field in From modal should be easily accessible so user can easily perform search function

Actual Result:

Search field get hidden at top, not easily accessible

On iOS - Search field is somewhat visible when scrolling the search panel
On Android - Search field gets completely hidden at top & not visible at all (Videos for both environments attached)

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

2.mp4

View all open jobs on GitHub

[getusha]

Newly created saved search isn't highlighted.

Screen.Recording.2025-05-29.at.12.08.48.in.the.afternoon.mov

[getusha]

Lets create empty state for reports page https://docs.google.com/document/d/1LL4nk5iVvFy9yNThXYcYUy9N3PQvkYqp8IOINsHBWSM/edit?tab=t.0#bookmark=id.m9n81wfqrcva

[getusha]

Can we reuse the same components as SearchDateFilterBase for consistency?

[JS00001]

For this, we decided we wanted to match the popover's style

[JmillsExpensify]

For this one. I don't think it's an issue, it's where we landed based on internal discussion. Do you agree @shawnborton?

[JS00001]

#62851 (comment) This should be fixed, its just not on the adhoc build yet

[shawnborton]

For this one. I don't think it's an issue, it's where we landed based on internal discussion. Do you agree @shawnborton?

Yup, agree! This is the conclusion that the design team came to, cc @Expensify/design

[github-actions]

🚧 @JS00001 has triggered a test app build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/62851-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/62851-hybrid/index.html
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/62851/NewExpensify.dmg	https://62851.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[shawnborton]

Feeling good to me so far!

Very minor nitpick: for the From filter, I would love it if we put your own account first in the list like Slack does:

[shawnborton]

Should I be able to save any search that isn't a default search? I would think yes, right? For instance, I have a search here for type:task, but I can't save it from filters:

However as soon as I change the assignee, I get the option to save it:

[shawnborton]

Same thing here - I can't save a search for Drafts for instance:

Have we considered putting all of the exposed filters into the advanced filters section too? That would make the most sense to me, personally... I vaguely remember chatting about this at one point with @JmillsExpensify I think.

[JS00001]

Sould I be able to save any search that isn't a default search? I would think yes, right? For instance, I have a search here for type:task, but I can't save it from filters:

This could be changed in the future, but this behavior matches what is currently on prod

[JS00001]

ave we considered putting all of the exposed filters into the advanced filters section too? That would make the most sense to me, personally... I vaguely remember chatting about this at one point

I thought we had discussed this, and I thought an external contributor had already done this, was this not implemented @JmillsExpensify ?

[dannymcclain]

Have we considered putting all of the exposed filters into the advanced filters section too? That would make the most sense to me, personally... I vaguely remember chatting about this at one point with @JmillsExpensify I think.

Yeah I also thought this was the plan?

[shawnborton]

I had this adhoc PR in one of my browser tabs and when I went back to it, I saw this 😱

The URL I was on was https://62851.pr-testing.expensify.com/search?q=type%3Aexpense%20status%3Aall%20sortBy%3Adate%20sortOrder%3Adesc