[Better Expense Report View] Update the go to parent logic in Reports tab #61774

WojtekBoman · 2025-05-09T11:56:46Z

Explanation of Change

This PR adds support for navigating to the parent report in the Reports tab. With this change, when clicking a link in the report header, users are redirected to the screen displayed in the current tab.

Note: This change only applies to expense reports.

Fixed Issues

$ #60441
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Go to the Reports tab.
Open the expense report.
Click the parent report link.
Verify that the displayed report page is opened in the Reports tab.

Offline tests

QA Steps

Verify that no errors appear in the JS console

Go to the Reports tab.
Open the expense report.
Click the parent report link.
Verify that you are redirected to the report page in the current tab.

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-05-13.at.16.22.18.mov

Android: mWeb Chrome

Screen.Recording.2025-05-13.at.16.24.44.mov

iOS: Native

Screen.Recording.2025-05-13.at.15.46.46.mov

iOS: mWeb Safari

Screen.Recording.2025-05-13.at.15.47.22.mov

MacOS: Chrome / Safari

Screen.Recording.2025-05-13.at.16.31.06.mov

MacOS: Desktop

Screen.Recording.2025-05-13.at.16.27.50.mov

Kicu

hey left some comments 👍

src/components/ParentNavigationSubtitle.tsx

Kicu · 2025-05-09T12:36:08Z

src/pages/home/ReportScreen.tsx

@@ -352,6 +352,7 @@ function ReportScreen({route, navigation}: ReportScreenProps) {
                policy={policy}
                parentReportAction={parentReportAction}
                onBackButtonPress={onBackButtonPress}
+                openParentReportInCurrentTab


I'm kinda confused.

<MoneyRequestHeader> is used only 2 times in the app:

in ReportScreen

in MoneyRequestReportView - which is the child of SearchMoneyRequestReportPage

and this component is basically only ever used for the report that is actually the transaction thread view. So don't we always want to have this flag set to true?

src/components/ParentNavigationSubtitle.tsx

WojtekBoman · 2025-05-09T13:55:14Z

@Expensify/design @trjExpensify @mountiny

Feel free to run new builds and test if it works fine :)

Here's a video showing how it works now:

Screen.Recording.2025-05-09.at.15.53.49.mov

github-actions · 2025-05-09T14:00:21Z

🚧 @shawnborton has triggered a test app build. You can view the workflow run here.

github-actions · 2025-05-09T14:39:34Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/61774-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/61774-hybrid/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/61774/NewExpensify.dmg	https://61774.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

shawnborton · 2025-05-09T15:05:55Z

Okay, seems to work when you navigate from Expense to Expense Report.

However, many times the RHP is actually showing a report... like this case for instance, where we have a one-expense-report:

And at which point, clicking on the small blue text opens up the Inbox.

This is maybe a separate consideration for @Expensify/design (cc Tom & Jason) - maybe we should make it so that if you are actually opening a full report from Reports > Expenses, it should show in the main pane and not the RHP?

dannymcclain · 2025-05-09T15:39:33Z

Yeah I think that makes sense to me. (And as a side note, I cannot wait for all reports to get the updated header treatment!)

trjExpensify · 2025-05-09T17:38:12Z

maybe we should make it so that if you are actually opening a full report from Reports > Expenses, it should show in the main pane and not the RHP?

Mhm.. I'm in two minds about it, because I think it makes it a bit unpredictable. That list of expenses is a mixture of expenses on multi-expense reports, and one expense reports. So if some open main pane, others open in the RHP, but they look identical.. that's pretty confusing.

So I think I lean towards all rows in Expenses open in the RHP.

shawnborton · 2025-05-09T18:06:52Z

Ok that's fair. What are your thoughts about opening up Expense/workspace chats right from Reports though? Basically this way we can try to keep most of the small blue links' navigation right within the Reports page.

trjExpensify · 2025-05-09T19:47:17Z

For now, I'd go with:

If it's an expense report URL in the header, open it in the new main pane report view when clicked now.
If it's a chat report, still open it in Inbox for now.

I'm open to changing that latter to open the parent chat report in the main pane, but I think it probably needs more discussion... like maybe some consideration for having chat results in the Chat search follow suit to align. It might also have overlap with this whole resurgence of the the "3Panez" thing too.

WojtekBoman · 2025-05-12T15:24:58Z

For now, I'd go with:

If it's an expense report URL in the header, open it in the new main pane report view when clicked now.

If it's a chat report, still open it in Inbox for now.

I'm open to changing that latter to open the parent chat report in the main pane, but I think it probably needs more discussion... like maybe some consideration for having chat results in the Chat search follow suit to align. It might also have overlap with this whole resurgence of the the "3Panez" thing too.

So I want to make sure, does the current version work fine?

shawnborton · 2025-05-12T16:10:58Z

I believe this means the current version works fine, yes. Let's move this into final review then, thanks!

melvin-bot · 2025-05-13T15:32:15Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2025-05-15T10:14:02Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-05-15.at.17.12.24.mov

Android: mWeb Chrome

Screen.Recording.2025-05-15.at.17.08.27.mov

iOS: HybridApp

Screen.Recording.2025-05-15.at.17.09.50.mov

iOS: mWeb Safari

Screen.Recording.2025-05-15.at.17.04.20.mov

MacOS: Chrome / Safari

Screen.Recording.2025-05-15.at.17.01.16.mov

MacOS: Desktop

Screen.Recording.2025-05-15.at.17.05.07.mov

DylanDylann

LGTM

mountiny

Thanks, looking good

mountiny · 2025-05-15T15:15:55Z

src/components/ParentNavigationSubtitle.tsx

@@ -43,6 +61,31 @@ function ParentNavigationSubtitle({parentNavigationSubtitleData, parentReportAct
            onPress={() => {
                const parentAction = getReportAction(parentReportID, parentReportActionID);
                const isVisibleAction = shouldReportActionBeVisible(parentAction, parentAction?.reportActionID ?? CONST.DEFAULT_NUMBER_ID, canUserPerformWriteAction);
+
+                if (openParentReportInCurrentTab && isReportInRHP) {
+                    // If the report is displayed in RHP in Reports tab, we want to stay in the current tab after opening the parent report


Thank you for adding these comments, always better to add more with this logic

OSBotify · 2025-05-15T15:36:17Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…xpense-report-view/go-to-parent" This reverts commit d4347a6, reversing changes made to 060c78b.

Kicu reviewed May 9, 2025

View reviewed changes

WojtekBoman force-pushed the better-expense-report-view/go-to-parent branch from 84a6228 to f60de22 Compare May 12, 2025 07:56

adamgrzybowski approved these changes May 13, 2025

View reviewed changes

WojtekBoman marked this pull request as ready for review May 13, 2025 15:32

WojtekBoman requested a review from a team as a code owner May 13, 2025 15:32

melvin-bot bot requested review from DylanDylann and removed request for a team May 13, 2025 15:32

WojtekBoman force-pushed the better-expense-report-view/go-to-parent branch from f60de22 to 42fef5f Compare May 13, 2025 17:08

WojtekBoman added 5 commits May 14, 2025 09:22

Handle opening parent reports in the current tab

5209365

Adjust comments in ParentNavigationSubtitle

40caafa

Remove openParentReportInCurrentTab prop from MoneyRequestHeader

07d3bd4

Show animation when opening SCREENS.SEARCH.MONEY_REQUEST_REPORT from RHP

0bbc879

Fix imports order

485074d

WojtekBoman force-pushed the better-expense-report-view/go-to-parent branch from 9ab79c7 to 485074d Compare May 14, 2025 07:36

DylanDylann approved these changes May 15, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny May 15, 2025 10:14

mountiny assigned WojtekBoman May 15, 2025

mountiny approved these changes May 15, 2025

View reviewed changes

mountiny merged commit d4347a6 into Expensify:main May 15, 2025
18 checks passed

francoisl mentioned this pull request May 16, 2025

Deploy Checklist: New Expensify 2025-05-15 #62161

Open

86 tasks

IuliiaHerets mentioned this pull request May 16, 2025

Reports - Self DM opened from Reports tab does not show expenses, Download is not working #62193

Open

8 tasks

jponikarchuk mentioned this pull request May 16, 2025

Reports - Composer is blocked by bottom tab when expense report is opened from transaction thread #62196

Open

8 tasks

francoisl added a commit that referenced this pull request May 16, 2025

Revert "Merge pull request #61774 from software-mansion-labs/better-e…

bf6c26e

…xpense-report-view/go-to-parent" This reverts commit d4347a6, reversing changes made to 060c78b.

francoisl mentioned this pull request May 16, 2025

[CP Staging] Revert "[Better Expense Report View] Update the go to parent logic in Reports tab" #62243

Draft

51 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Better Expense Report View] Update the go to parent logic in Reports tab #61774

[Better Expense Report View] Update the go to parent logic in Reports tab #61774

WojtekBoman commented May 9, 2025 •

edited

Loading

Kicu left a comment

Kicu May 9, 2025

WojtekBoman commented May 9, 2025

github-actions bot commented May 9, 2025

github-actions bot commented May 9, 2025

shawnborton commented May 9, 2025

dannymcclain commented May 9, 2025

trjExpensify commented May 9, 2025

shawnborton commented May 9, 2025

trjExpensify commented May 9, 2025

WojtekBoman commented May 12, 2025

shawnborton commented May 12, 2025

melvin-bot bot commented May 13, 2025

DylanDylann commented May 15, 2025

DylanDylann left a comment

mountiny left a comment

mountiny May 15, 2025

OSBotify commented May 15, 2025

[Better Expense Report View] Update the go to parent logic in Reports tab #61774

[Better Expense Report View] Update the go to parent logic in Reports tab #61774

Conversation

WojtekBoman commented May 9, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Kicu left a comment

Choose a reason for hiding this comment

Kicu May 9, 2025

Choose a reason for hiding this comment

WojtekBoman commented May 9, 2025

github-actions bot commented May 9, 2025

github-actions bot commented May 9, 2025

shawnborton commented May 9, 2025

dannymcclain commented May 9, 2025

trjExpensify commented May 9, 2025

shawnborton commented May 9, 2025

trjExpensify commented May 9, 2025

WojtekBoman commented May 12, 2025

shawnborton commented May 12, 2025

melvin-bot bot commented May 13, 2025

DylanDylann commented May 15, 2025

Reviewer Checklist

Screenshots/Videos

DylanDylann left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

mountiny May 15, 2025

Choose a reason for hiding this comment

OSBotify commented May 15, 2025

WojtekBoman commented May 9, 2025 •

edited

Loading