Skip to content

Reports - Composer is blocked by bottom tab when expense report is opened from transaction thread #62196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
4 of 8 tasks
jponikarchuk opened this issue May 16, 2025 · 12 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@jponikarchuk
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.46-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: #61774
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.4
App Component: Search

Action Performed:

  1. Launch Expensify app.
  2. Go to workspace chat.
  3. Submit two expenses to the workspace chat.
  4. Go to Reports.
  5. Open one of the expenses from Step 3.
  6. Tap on the report header subtitle.

Expected Result:

The composer in the expense report will not be blocked by the bottom tab.

Actual Result:

The composer in the expense report is blocked by the bottom tab.
We can see a small part of the composer above the bottom tab, which shows that it is blocked.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

1.mp4
Image

View all open jobs on GitHub

@jponikarchuk jponikarchuk added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels May 16, 2025
Copy link

melvin-bot bot commented May 16, 2025

Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented May 16, 2025

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented May 16, 2025

💬 A slack conversation has been started in #expensify-open-source

@melvin-bot melvin-bot bot added the Daily KSv2 label May 16, 2025
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels May 16, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@adamgrzybowski
Copy link
Contributor

I will take a look at that

@adamgrzybowski
Copy link
Contributor

@jponikarchuk I can't reproduce this problem. I tried on the web and iOS native. Is there something missing from my reproduction steps?

Screen.Recording.2025-05-16.at.14.43.21.mov

@jponikarchuk
Copy link
Author

jponikarchuk commented May 16, 2025

@adamgrzybowski I still can reproduce this issue in build 9.1.46-0. Android app record added
Did you use Expensify account, not Gmail?

1.mp4

@adamgrzybowski
Copy link
Contributor

I will check Android. What about other marked platforms? I have gmail account

@adamgrzybowski
Copy link
Contributor

I reproduced this on Android. Could you please check other platforms on your end? I think this description may be wrong but let's make sure

Image

@jponikarchuk
Copy link
Author

@adamgrzybowski Reproduced with Expensify account on iOS app and mWeb/Chrome too

iOS.app.MP4
mWeb.mp4

@shawnborton
Copy link
Contributor

Let's make sure we don't show a bottom tab bar when we are loading the report either:

Image

@mountiny mountiny removed the DeployBlockerCash This issue or pull request should block deployment label May 19, 2025
@mountiny
Copy link
Contributor

This is coming from the LHB changes so no need for payment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants