-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[NoQA] Add CSpell
for spelling checks [Part 4]
#61768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/libs/SearchQueryUtils.ts
Outdated
@@ -43,6 +43,7 @@ const operatorToCharMap = { | |||
/** | |||
* A mapping object that maps filter names from the internal codebase format to user-friendly names. | |||
*/ | |||
// cspell:disable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to do this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To disable for this line reportid
:
App/src/libs/SearchQueryUtils.ts
Line 66 in 3d2b44f
reportID: 'reportid', |
But I think cspell:disable-next-line
is enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me so far. There still are some ESLint errors 👀
Since these PRs touch too many files, I got a 🟢 light from @mountiny to skip fixing these lints #59249 (comment). |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-05-16.at.12.21.28.AM.movAndroid: mWeb ChromeScreen.Recording.2025-05-16.at.12.23.25.AM.moviOS: HybridAppScreen.Recording.2025-05-16.at.12.04.42.AM.moviOS: mWeb SafariScreen.Recording.2025-05-16.at.12.07.02.AM.movMacOS: Chrome / SafariScreen.Recording.2025-05-15.at.11.55.09.PM.movMacOS: DesktopScreen.Recording.2025-05-16.at.2.20.52.AM.mov |
Yeah the failing eslint checks are optional and its not feasible to fix them in this PR as it would increase the chance for some regression a lot |
@ishpaul777 can you please complete the checklist? |
@ishpaul777 @dominictb how is this looking? |
@mountiny i'll prioritize and finish this today |
@dominictb looks like test passed but the operation was cancelled ![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! We have some merge conflicts, however.
All yours @mountiny ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
We touched many files in this change so this is mainly to avoid more regressions we did not fix all the lint changes |
🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.47-0 🚀
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.1.47-6 🚀
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.1.47-6 🚀
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.1.47-6 🚀
|
cc @mountiny @ishpaul777
Explanation of Change
Fix spellings in
src/libs
. Github Action for CSpell has not been integrated here.Fixed Issues
$ #54810
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectioncanBeMissing
param foruseOnyx
toggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop