[Due for payment 2025-05-30] [$250] Investigate spell checking action for App codebase

[mountiny]

Coming from here

Problem

We have typos/misspells across the codebase. For example, I saw following typos in a single file: TASK_TITLE_WITH_OPTONAL_SHORT_MENTION, reportRecipientAcountIDs, incoke

Background

We accept many contributions from all over the world, and sometimes, it can be difficult to spot such typos during code review. This is especially true when PRs need to be merged urgently to fix important bugs or if PRs are big enough (we can't simply go through each letter in changes to assure that the codebase doesn't have typos).

Solution

We can enable tools for spell checking. The most know one is cspell . We can integrate it as a part of our eslint pipeline (https://www.npmjs.com/package/@cspell/eslint-plugin) or we can integrate it via GitHub actions as a standalone check using https://github.com/streetsidesoftware/cspell-action.

Lets investigate how long would such action run if we run it on each commit on PRs only on the files that changed.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021876644443513097620
• Upwork Job ID: 1876644443513097620
• Last Price Increase: 2025-01-07
• Automatic offers:
• dominictb | Contributor | 106642648

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot]

Current assignee @mountiny is eligible for the AutoAssignerNewDotQuality assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @alexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[kirillzyusko]

Hi, I'm Kiryl from Margelo expert agency and I'd like to work on this issue 🙌

[parasharrajat]

I would like to be C+ reviewer of this if needed. @mountiny

[parasharrajat]

I think we can add this as git Hook to check spellings. That should save us action hours and time.

[kirillzyusko]

git Hook to check spellings

Git hooks can be easily bypassed locally (with --no-verify flag). We should integrate it to CI process in my opinion (eslint or separate job)

[parasharrajat]

Aha, yeah. Maybe server-side hooks. But the ESlint check looks good too if it does not take more time. We can add an ESLint parallel job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021876644443513097620

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

[mountiny]

@parasharrajat thanks! But I think we can follow the process here as its not part of any project where you have worked before. Dont want to set a precedence where C+ comment on new issues

[shubham1206agra]

@parasharrajat thanks! But I think we can follow the process here as its not part of any project where you have worked before. Dont want to set a precedence where C+ comment on new issues

@mountiny I am afraid, but that ship sailed a long time ago. Not going to name anyone here.

[mountiny]

Does not matter, lets just not make it a norm

[parasharrajat]

Works for me. I just noticed this happening and wasn't getting any work so I followed one or two.

After a discussion internally, I can say this should not be followed on for post-initial project issues. After the main implementation for a project is done. The follow-up should be auto assigned unless planning beforehand.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [NoQA] Add CSpell for spelling checks [Part 4]  #61768

If no regressions arise, payment will be issued on 2025-05-28. 🎊

For reference, here are some details about the assignees on this issue:

• @kirillzyusko does not require payment (Contractor)
• @ishpaul777 requires payment through NewDot Manual Requests
• @dominictb requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ishpaul777 / @dominictb] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[dominictb]

Not due for payment yet. But we're almost there!!!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.50-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [NoQA] Add CSpell for spelling checks [Part 5] #61835

If no regressions arise, payment will be issued on 2025-05-30. 🎊

For reference, here are some details about the assignees on this issue:

• @kirillzyusko does not require payment (Contractor)
• @ishpaul777 requires payment through NewDot Manual Requests
• @dominictb requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ishpaul777 / @dominictb] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.