-
Notifications
You must be signed in to change notification settings - Fork 3.2k
do not show 1 selected button in one transaction thread #60334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@nkdengineer Can you resolve the lint errors for us? Thanks. |
It's on my list, I'll come back here to review it ASAP |
Reviewer Checklist
Screenshots/VideosAndroid: Native60334_android_native.movAndroid: mWeb Chrome60334_android_web.moviOS: Native60334_ios_native.moviOS: mWeb Safari60334_ios_web.movMacOS: Chrome / Safari60334_web_chrome.movMacOS: Desktop60334_web_desktop.mov |
@nkdengineer could you update the steps to test this PR? In step 8 of the section "No educational modal for held expense when expense is held in new expense report view" (maybe also remove the "no" there) it should be something like "there will be educational modal for held expense..." and end there, I believe we don't need step 9 onwards. What do you think? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just pay attention to this comment before the QA team tests this PR. Thanks.
@nkdengineer Can you update the QA steps with @brunovjk comment before I merge? Otherwise, we will forget |
@pecanoro Updated the test step. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/pecanoro in version: 9.1.32-0 🚀
|
🚀 Deployed to production by https://github.com/thienlnam in version: 9.1.32-8 🚀
|
Explanation of Change
Fixed Issues
$ #60100
PROPOSAL: #60100 (comment)
Tests
Offline tests
Same as tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2025-04-16.at.13.54.17.mov
Android: mWeb Chrome
Screen.Recording.2025-04-16.at.13.41.11.mov
iOS: Native
Screen.Recording.2025-04-16.at.13.53.30.mov
iOS: mWeb Safari
Screen.Recording.2025-04-16.at.13.45.21.mov
MacOS: Chrome / Safari
Screen.Recording.2025-04-16.at.13.33.38.mov
MacOS: Desktop
Screen.Recording.2025-04-16.at.13.59.37.mov