[$250] [Better Expense Report View] No educational modal for held expense when expense is held in new expense report view

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.27-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Log in with a new Expensifail account.

1. Go to staging.new.expensify.com
2. Create a new workspace.
3. Go to FAB > Create report.
4. On Reports page, click + > Create expense.
5. Create a manual expense.
6. Click on the report header > Hold.
7. Enter reason and save it.
8. Note that there is no educational modal for held expense.
9. Go back to Inbox.
10. Open the workspace chat.
11. Go to the transaction thread,
12. Note that now the educational modal for held expense appeaers.

Expected Result:

In Step 8, there will be educational modal for held expense.

Actual Result:

In Step 8, there is no educational modal for held expense.
It only appears when the transaction thread is opened in Inbox.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6798961_1744334492818.20250411_090542.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021912590101525031358
• Upwork Job ID: 1912590101525031358
• Last Price Increase: 2025-04-16

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @DylanDylann

[melvin-bot]

Triggered auto assignment to @lydiabarclay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The hold educational modal doesn't show in search report page.

What is the root cause of that problem?

We check whether the transaction is on hold or not before opening the hold modal.

App/src/components/MoneyReportHeader.tsx

Lines 486 to 490 in 8cf3e2c

	if (isLoadingHoldUseExplained || dismissedHoldUseExplanation || !isOnHold) {
	return;
	}
	Navigation.navigate(ROUTES.PROCESS_MONEY_REQUEST_HOLD.getRoute(Navigation.getReportRHPActiveRoute()));
	}, [dismissedHoldUseExplanation, isLoadingHoldUseExplained, isOnHold]);

However, it's always false because the transaction here is undefined.

App/src/components/MoneyReportHeader.tsx

Line 142 in 8cf3e2c

const [transaction] = useOnyx(`${ONYXKEYS.COLLECTION.TRANSACTION}${isMoneyRequestAction(requestParentReportAction) && getOriginalMessage(requestParentReportAction)?.IOUTransactionID}`);

App/src/components/MoneyReportHeader.tsx

Lines 130 to 137 in 8cf3e2c

	const [transactionThreadReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${transactionThreadReportID}`);
	const [session] = useOnyx(ONYXKEYS.SESSION);
	const requestParentReportAction = useMemo(() => {
	if (!reportActions || !transactionThreadReport?.parentReportActionID) {
	return null;
	}
	return reportActions.find((action): action is OnyxTypes.ReportAction<typeof CONST.REPORT.ACTIONS.TYPE.IOU> => action.reportActionID === transactionThreadReport.parentReportActionID);
	}, [reportActions, transactionThreadReport?.parentReportActionID]);

It's undefined because we pass an undefined transactionThreadReportID.

App/src/components/MoneyRequestReportView/MoneyRequestReportView.tsx

Lines 174 to 178 in 8cf3e2c

	<MoneyReportHeader
	report={report}
	policy={policy}
	reportActions={reportActions}
	transactionThreadReportID={undefined}

What changes do you think we should make in order to solve the problem?

Pass the transactionThreadReportID.
transactionThreadReportID={transactionThreadReportID}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[lydiabarclay]

@Expensify/design what do y'all think? do you want that modal in every single view?

[dubielzyk-expensify]

Yeah this seems like a bug to me. We want the Hold modal to show for the first time when an expense is held and in the video, that's not happening.

cc @Expensify/design for gut check

[shawnborton]

Yup, I agree with that Jon. cc @mountiny

[DylanDylann]

@mountiny Should we handle this issue external or internal?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021912590101525031358

[melvin-bot]

Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new.

[nkdengineer]

It will be fixed here

[mountiny]

ok putting it on hold for #60334, could you add the test steps there too please?

[nkdengineer]

Will update tomorrow.

[melvin-bot]

@mountiny, @DylanDylann Eep! 4 days overdue now. Issues have feelings too...

[lydiabarclay]

still on hold for #60334

[mountiny]

The linked PR was merged, lets confirm this is also fixed now in main @DylanDylann

[DylanDylann]

Can't reproduce

Screen.Recording.2025-04-23.at.11.49.22.mov

[mountiny]

Thanks we can close then!