-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[Better Expense Reports] Carousel does not show the last expense when the last dot is clicked #59716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Better Expense Reports] Carousel does not show the last expense when the last dot is clicked #59716
Conversation
…-fork into Guccio163/CarouselFollowUps
…-fork into Guccio163/CarouselFollowUps
@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
🚧 @mountiny has triggered a test app build. You can view the workflow run here. |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪 |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2025-04-07.at.5.15.53.PM.moviOS: NativeScreenRecording_04-07-2025.17-16-20_1.MP4iOS: mWeb SafariScreen.Recording.2025-04-07.at.5.12.10.PM.movMacOS: Chrome / SafariScreen.Recording.2025-04-07.at.5.08.41.PM.movMacOS: DesktopScreen.Recording.2025-04-07.at.5.14.25.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.24-2 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.24-10 🚀
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.24-10 🚀
|
Explanation of Change
FlatList elements need their keys dependent on their resizable width to ensure rerendering and hence correct navigation through them - resizing the window doesn't necessarily triggers it without the key change.
Fixed Issues
$ #59466
$ #59463
PROPOSAL:
Tests
Resizing wide -> narrow:
Expected result: navigation works properly - flatlist scrolls to the last expense
Resizing narrow -> wide:
>
button)Expected result: navigation works properly - flatlist scrolls to the last expense,
>
button disablesOffline tests
QA Steps
"Same as tests"
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
DO NOT APPLY
Android: mWeb Chrome
DO NOT APPLY
iOS: Native
DO NOT APPLY
iOS: mWeb Safari
DO NOT APPLY
MacOS: Chrome / Safari
Screen.Recording.2025-04-07.at.11.38.40.mov
MacOS: Desktop
Screen.Recording.2025-04-07.at.11.51.16.mov