Skip to content

[Due for payment 2025-04-16] [Better Expense Report View] button is not disabled when the carousel is at the end of the expense preview #59466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 8 tasks
lanitochka17 opened this issue Apr 1, 2025 · 8 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Apr 1, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.22-0
Reproducible in staging?: Y
Reproducible in production?: No, New feature
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #58479
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • Log in with Expensifail account
  1. Go to staging.new.expensify.com
  2. Go to workspace chat
  3. Create 11 expenses
  4. Resize the window to narrow screen
  5. Refresh the page
  6. Click on the last dot in the expense preview
  7. Resize the window to wide screen
  8. Click > button

Expected Result:

button should be disabled because the carousel is at the end of the expense preview

Actual Result:

button is not disabled when the carousel is at the end of the expense preview. It has click effect when clicking on it

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6789035_1743523360118.20250401_235953.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @laurenreidexpensify
@lanitochka17 lanitochka17 added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Apr 1, 2025
Copy link

melvin-bot bot commented Apr 1, 2025

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@Guccio163
Copy link
Contributor

Guccio163 commented Apr 1, 2025

I can just fix it in the desired follow-up: #59452, WDYT @allgandalf @mountiny ?

@mountiny
Copy link
Contributor

mountiny commented Apr 1, 2025

@Guccio163 I think its fine to just keep these individual issues open, it makes it easier to track

@mountiny mountiny moved this to Second Cohort - CRITICAL in [#whatsnext] #migrate Apr 1, 2025
@mountiny mountiny changed the title Expense - button is not disabled when the carousel is at the end of the expense preview [Better Expense Report View] button is not disabled when the carousel is at the end of the expense preview Apr 1, 2025
Copy link

melvin-bot bot commented Apr 7, 2025

@Guccio163 Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot melvin-bot bot added Overdue Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 Overdue labels Apr 7, 2025
@mountiny
Copy link
Contributor

mountiny commented Apr 7, 2025

PR merged, no need for payment or regression test at this point (will be added as part of the project)

@mountiny mountiny closed this as completed Apr 7, 2025
@github-project-automation github-project-automation bot moved this from Second Cohort - CRITICAL to Done in [#whatsnext] #migrate Apr 7, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Apr 9, 2025
@melvin-bot melvin-bot bot changed the title [Better Expense Report View] button is not disabled when the carousel is at the end of the expense preview [Due for payment 2025-04-16] [Better Expense Report View] button is not disabled when the carousel is at the end of the expense preview Apr 9, 2025
Copy link

melvin-bot bot commented Apr 9, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 9, 2025
Copy link

melvin-bot bot commented Apr 9, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.24-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-04-16. 🎊

For reference, here are some details about the assignees on this issue:

  • @Guccio163 does not require payment (Contractor)
  • @allgandalf requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Apr 9, 2025

@allgandalf @laurenreidexpensify @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2
Projects
Development

No branches or pull requests

5 participants