fix: persist selection in room members page #59648

daledah · 2025-04-04T08:07:14Z

Explanation of Change

Fixed Issues

$ #59426
PROPOSAL: #59426 (comment)

Tests

Create a room
Invite some members
Room details in the new chat > Members
Select a couple of members, click on a single member outside the checkbox area
Click back button
Verify that: the selection is not reset

Verify that no errors appear in the JS console

Offline tests

QA Steps

Create a room
Invite some members
Room details in the new chat > Members
Select a couple of members, click on a single member outside the checkbox area
Click back button
Verify that: the selection is not reset

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-04-04.at.15.00.26.mov

Android: mWeb Chrome

Screen.Recording.2025-04-04.at.15.02.23.mov

iOS: Native

Screen.Recording.2025-04-04.at.15.03.50.mov

iOS: mWeb Safari

Screen.Recording.2025-04-04.at.15.04.45.mov

MacOS: Chrome / Safari

Screen.Recording.2025-04-04.at.15.05.32.mov

MacOS: Desktop

Screen.Recording.2025-04-04.at.15.05.59.mp4

melvin-bot · 2025-04-04T08:31:51Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

s77rt

Please fix the same bug in other pages e.g. distance rates and ws members

src/pages/RoomMembersPage.tsx

daledah · 2025-04-08T10:51:53Z

@s77rt I updated the logics for: Group chat, WS Distance rate page and WS Members page.

src/pages/ReportParticipantsPage.tsx

s77rt · 2025-04-08T17:02:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mweb-chrome.mov

iOS: Native

JS bundle issue. NAB.

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

s77rt · 2025-04-08T17:04:48Z

Report fields and Multi level tags still not persisting the selection

Screen.Recording.2025-04-08.at.6.01.43.PM.mov

Screen.Recording.2025-04-08.at.6.01.57.PM.mov

daledah · 2025-04-09T10:39:26Z

@s77rt I updated.

src/pages/workspace/tags/WorkspaceViewTagsPage.tsx

src/pages/ReportParticipantsPage.tsx

src/pages/RoomMembersPage.tsx

src/pages/workspace/WorkspaceMembersPage.tsx

src/pages/workspace/distanceRates/PolicyDistanceRatesPage.tsx

src/pages/workspace/reportFields/WorkspaceReportFieldsPage.tsx

src/pages/workspace/tags/WorkspaceViewTagsPage.tsx

mountiny · 2025-04-14T16:14:56Z

@daledah how is this looking?

daledah · 2025-04-14T16:27:18Z

@mountiny Currently there's a difference in the selection data between screens, for example: RoomMembersPage uses Array while WorkspaceReportFieldsPage uses Record, which makes generalizing the logics much more difficult. So here we have two options:

Simply clear the eslint-disable-next-line on the effects in this PR and move on, or
Refactor logics from RoomMembersPage to use Record instead and proceed with the new hook.

Which approach do you prefer in this case?

mountiny · 2025-04-15T09:14:28Z

I think that unifying the approach is better and we should also not use the edlint rule if not needed so sounds like using the Record and DRY hook is the way to go

daledah · 2025-04-15T17:48:09Z

Thanks for the feedback, I'll update soon.

mountiny · 2025-04-25T10:50:19Z

Thank you for confirming, appreciate it! 🙇

src/pages/workspace/WorkspaceMembersPage.tsx

src/libs/ReportUtils.ts

src/pages/workspace/reportFields/WorkspaceReportFieldsPage.tsx

daledah · 2025-04-29T12:14:05Z

@s77rt I updated.

s77rt

Overall this is looking almost done just found 2 more bugs that we should handle first

src/pages/workspace/distanceRates/PolicyDistanceRatesPage.tsx

src/pages/workspace/reportFields/ReportFieldsListValuesPage.tsx

daledah · 2025-04-30T10:00:44Z

@s77rt I updated.

src/pages/workspace/distanceRates/PolicyDistanceRatesPage.tsx

mountiny

Lgtm, thanks for improving this one

OSBotify · 2025-05-04T16:41:52Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

ChavdaSachin · 2025-05-05T22:48:46Z

This PR has a regression - select all checkbox is not working as expected on report fields page.
cc. @daledah @s77rt

s77rt · 2025-05-05T23:30:32Z

@ChavdaSachin Thanks!

@daledah Can you please raise a quick PR as this will hit staging soon

diff --git a/src/pages/workspace/reportFields/WorkspaceReportFieldsPage.tsx b/src/pages/workspace/reportFields/WorkspaceReportFieldsPage.tsx
index 294ada570e3..229f8a7c373 100644
--- a/src/pages/workspace/reportFields/WorkspaceReportFieldsPage.tsx
+++ b/src/pages/workspace/reportFields/WorkspaceReportFieldsPage.tsx
@@ -154,8 +154,13 @@ function WorkspaceReportFieldsPage({
     };
 
     const toggleAllReportFields = () => {
-        const availableReportFields = Object.values(selectionFieldList).filter((reportField) => reportField.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE);
-        setSelectedReportFields(selectedReportFields.length > 0 ? [] : Object.keys(availableReportFields));
+        setSelectedReportFields((prevSelectedReportFields) =>
+            prevSelectedReportFields.length > 0
+                ? []
+                : Object.entries(selectionFieldList)
+                      .filter(([, reportField]) => reportField.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE)
+                      .map(([key]) => key),
+        );
     };
 
     const navigateToReportFieldsSettings = (reportField: ReportFieldForList) => {

daledah · 2025-05-06T00:54:59Z

@s77rt Here's the followup PR

github-actions · 2025-05-06T01:26:05Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.40-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-05-07T00:06:48Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.1.40-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

marcaaron · 2025-05-14T21:43:00Z

src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

-        setSelectedCategories({});
-        deleteWorkspaceCategories(policyId, selectedCategoriesArray);
+        setSelectedCategories([]);
+        deleteWorkspaceCategories(policyId, selectedCategories);


Can we make sure that there are no null values in selectedCategories? We saw some cases where this was happening. I'm guessing it has to do with the logic on 160-170 above.

I think this is the PR that might have introduced the issue here though not sure cc @mountiny

Yeah we should cover this here too! @daledah Could you please take a look and make sure the category list only includes non-empty strings and no other types? thanks!

fix: persist selection in room members page

561def7

daledah marked this pull request as ready for review April 4, 2025 08:31

daledah requested a review from a team as a code owner April 4, 2025 08:31

melvin-bot bot requested review from s77rt and removed request for a team April 4, 2025 08:31

s77rt suggested changes Apr 4, 2025

View reviewed changes

src/pages/RoomMembersPage.tsx Outdated Show resolved Hide resolved

src/pages/RoomMembersPage.tsx Outdated Show resolved Hide resolved

daledah added 2 commits April 8, 2025 17:33

Merge branch 'main' into fix/59426

fb5f4fd

fix: preserve selection in other pages

6b821e5

fix: lint

944bba8

s77rt suggested changes Apr 8, 2025

View reviewed changes

src/pages/ReportParticipantsPage.tsx Outdated Show resolved Hide resolved

daledah added 2 commits April 9, 2025 15:43

Merge branch 'main' into fix/59426

cf6136e

fix: persist selection on report fields page, multi level tags page

4190dfa

s77rt suggested changes Apr 9, 2025

View reviewed changes

src/pages/workspace/tags/WorkspaceViewTagsPage.tsx Outdated Show resolved Hide resolved

fix: check for exist tags

fe709dd

s77rt approved these changes Apr 10, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny April 10, 2025 09:08

mountiny assigned daledah Apr 10, 2025

mountiny requested changes Apr 10, 2025

View reviewed changes

Merge branch 'main' into fix/59426

c3d8f0e

daledah added 2 commits April 16, 2025 15:16

Merge branch 'main' into fix/59426

f1880f5

fix: create hook to unify selection persist logic

598d174

s77rt suggested changes Apr 25, 2025

View reviewed changes

daledah added 2 commits April 29, 2025 19:06

Merge branch 'main' into fix/59426

6bc0bf1

fix: apply suggestions

b1fc61b

mountiny requested a review from s77rt April 29, 2025 12:36

s77rt suggested changes Apr 29, 2025

View reviewed changes

src/pages/workspace/distanceRates/PolicyDistanceRatesPage.tsx Outdated Show resolved Hide resolved

src/pages/workspace/reportFields/ReportFieldsListValuesPage.tsx Show resolved Hide resolved

daledah added 2 commits April 30, 2025 16:22

Merge branch 'main' into fix/59426

3d42bf2

fix: app crash and incorrect selected items

9b40a16

s77rt suggested changes Apr 30, 2025

View reviewed changes

src/pages/workspace/distanceRates/PolicyDistanceRatesPage.tsx Outdated Show resolved Hide resolved

daledah added 2 commits May 2, 2025 00:51

Merge branch 'main' into fix/59426

2bbd6be

fix: filter pending action for toggle all distance rates

8f0452d

s77rt approved these changes May 1, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny May 1, 2025 22:40

Merge branch 'main' into fix/59426

7f1429c

mountiny approved these changes May 4, 2025

View reviewed changes

mountiny merged commit f3a3470 into Expensify:main May 4, 2025
16 checks passed

dukenv0307 mentioned this pull request May 5, 2025

[Due for payment 2025-05-28] [$250] Incorrect behavior when clicking on the member to uncheck the checkbox #60546

Open

18 tasks

github-actions bot mentioned this pull request May 6, 2025

Deploy Checklist: New Expensify 2025-05-06 #61424

Closed

77 tasks

s77rt mentioned this pull request May 6, 2025

[CP Staging] fix: persist selection followups #61423

Merged

51 tasks

daledah mentioned this pull request May 6, 2025

[Due for payment 2025-05-14] [Due for payment 2025-05-14] Tags - App crashes after renaming tag and enabling tag from the dropdown button #61455

Closed

8 tasks

melvin-bot bot mentioned this pull request May 7, 2025

[Due for payment 2025-05-14] [Due for payment 2025-05-14] [$250] AU - Room Invite - App auto-deselects all members after returning from member details page #59426

Closed

8 tasks

marcaaron reviewed May 14, 2025

View reviewed changes

fix: persist selection in room members page #59648

fix: persist selection in room members page #59648

Uh oh!

Conversation

daledah commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Apr 4, 2025

Uh oh!

s77rt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

daledah commented Apr 8, 2025

Uh oh!

Uh oh!

s77rt commented Apr 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

s77rt commented Apr 8, 2025

Uh oh!

daledah commented Apr 9, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mountiny commented Apr 14, 2025

Uh oh!

daledah commented Apr 14, 2025

Uh oh!

mountiny commented Apr 15, 2025

Uh oh!

daledah commented Apr 15, 2025

Uh oh!

mountiny commented Apr 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

daledah commented Apr 29, 2025

Uh oh!

s77rt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

daledah commented Apr 30, 2025

Uh oh!

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented May 4, 2025

Uh oh!

ChavdaSachin commented May 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

s77rt commented May 5, 2025

Uh oh!

daledah commented May 6, 2025

Uh oh!

daledah commented Apr 4, 2025 •

edited

Loading

s77rt commented Apr 8, 2025 •

edited

Loading

ChavdaSachin commented May 5, 2025 •

edited

Loading