Skip to content

[Due for payment 2025-05-14] [Due for payment 2025-05-14] Tags - App crashes after renaming tag and enabling tag from the dropdown button #61455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 8 tasks
mitarachim opened this issue May 6, 2025 · 12 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@mitarachim
Copy link

mitarachim commented May 6, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.40-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Workspace has dependent tags.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Tags.
  3. Click on any main tag.
  4. Select a subtag via checkbox.
  5. Click on the selected tag.
  6. Click Name.
  7. Edit the name and save it.
  8. Click RHP back button.
  9. Click on the dropdown.
  10. Click Enable.

Expected Result:

In Step 9, after renaming the subtag, the dropdown will not appear because the tag is no longer selected.

Actual Result:

In Step 9, after renaming the subtag, the dropdown persists when the tag is no longer selected.
In Step 10, after clicking Enable from the dropdown, app crashes.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6822817_1746514903584!Dependent_-_Multi_Level_tags_NEW (1).csv

Bug6822817_1746514829044.20250506_145452.mp4

Bug6822817_1746514829004!tag.txt

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @strepanier03
@mitarachim mitarachim added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels May 6, 2025
Copy link

melvin-bot bot commented May 6, 2025

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented May 6, 2025

Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented May 6, 2025

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

github-actions bot commented May 6, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@daledah
Copy link
Contributor

daledah commented May 6, 2025

This comes from my PR, and I'll include the fix for this issue in #61423.

@luacmartins
Copy link
Contributor

PR merged, requesting CP.

@luacmartins luacmartins added the Reviewing Has a PR in review label May 6, 2025
@luacmartins
Copy link
Contributor

This was a regression and issue is fixe din staging. Closing.

@luacmartins luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label May 6, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Hourly KSv2 labels May 7, 2025
@melvin-bot melvin-bot bot changed the title Tags - App crashes after renaming tag and enabling tag from the dropdown button [Due for payment 2025-05-14] Tags - App crashes after renaming tag and enabling tag from the dropdown button May 7, 2025
Copy link

melvin-bot bot commented May 7, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label May 7, 2025
Copy link

melvin-bot bot commented May 7, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.40-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-05-14. 🎊

Copy link

melvin-bot bot commented May 7, 2025

@luacmartins @strepanier03 @luacmartins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels May 7, 2025
@melvin-bot melvin-bot bot changed the title [Due for payment 2025-05-14] Tags - App crashes after renaming tag and enabling tag from the dropdown button [Due for payment 2025-05-14] [Due for payment 2025-05-14] Tags - App crashes after renaming tag and enabling tag from the dropdown button May 7, 2025
Copy link

melvin-bot bot commented May 7, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.41-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-05-14. 🎊

Copy link

melvin-bot bot commented May 7, 2025

@luacmartins @strepanier03 @luacmartins The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants