fix: remove markdown symbol in report header and report details page #59328

daledah · 2025-03-31T04:39:12Z

Explanation of Change

Fixed Issues

$ #59733
$ #59793
$ #58553
PROPOSAL: #58553 (comment)

Tests

Go to 1:1 Chat
Submit 2 expenses with markdown description
Go to the transaction thread of the expense
Verify that: The header title does not have html tags
Click on header to open details page
Verify that: The report name does not have html tags

Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to 1:1 Chat
Submit 2 expenses with markdown description
Go to the transaction thread of the expense
Verify that: The header title does not have html tags
Click on header to open details page
Verify that: The report name does not have html tags

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-03-31.at.11.29.25.mov

Android: mWeb Chrome

Screen.Recording.2025-03-31.at.11.31.48.mov

iOS: Native

Screen.Recording.2025-03-31.at.11.32.34.mov

iOS: mWeb Safari

Screen.Recording.2025-03-31.at.11.33.12.mov

MacOS: Chrome / Safari

Screen.Recording.2025-03-31.at.11.33.29.mov

MacOS: Desktop

Screen.Recording.2025-03-31.at.11.34.02.mov

melvin-bot · 2025-03-31T04:54:21Z

@suneox Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

daledah · 2025-03-31T04:56:17Z

Asked on slack whether we should fix the Money request preview content.

daledah · 2025-04-07T15:54:46Z

We got confirmation, I'll update the PR soon. Also I will implement the fix for #59733 in this PR as well.

daledah · 2025-04-08T11:51:58Z

@suneox I updated with the fix for:

MoneyRequestPreviewContent

ReportPreview

TransactionPreviewContent

daledah · 2025-04-09T09:37:59Z

Added fix for #59793

suneox · 2025-04-14T00:53:00Z

Thanks for the update. I'll review this PR today

suneox · 2025-04-14T14:08:01Z

@daledah Could you please update the reference issues into the Fixed Issue section for #59733 and #59793?

suneox · 2025-04-14T15:01:28Z

@daledah We have an issue with #59793 where the text is truncated on the duplicate review screen on Android native.
This issue doesn’t occur on the latest main.

Current PR	Latest main

suneox · 2025-04-14T15:42:02Z

@daledah We have an issue with #59793 where the text is truncated on the duplicate review screen on Android native.

We've encountered another issue on iOS native, the duplicate review screen only displays one line of text.
Meanwhile, other platforms show multiple lines

iOS Native	iOS Safari

suneox · 2025-04-14T16:15:28Z

@daledah I think we should be to confirm expected behavior in case we have a multiple lines, due to on current latest main just only show 1 line and i've put the confirmation at this comment

suneox · 2025-04-17T15:07:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

MacOS: Chrome / Safari

review duplicate

expense preview

report title

LHN

MacOS: Desktop

review duplicate

expense preview

report title

LHN

Android: Native

review duplicate

expense preview

report title

LHN

Android: mWeb Chrome

review duplicate

expense preview

report title
LHN

iOS: Native

review duplicate

expense preview

report title

LHN

iOS: mWeb Safari

review duplicate

expense preview

report title

LHN

daledah · 2025-04-19T15:19:00Z

@daledah We have an issue with #59793 where the text is truncated on the duplicate review screen on Android native. This issue doesn’t occur on the latest main.

@suneox Could you provide the description that causes this bug? I tried with very long text link and can't reproduce

Screen.Recording.2025-04-19.at.22.18.27.mov

daledah · 2025-04-19T16:27:51Z

I updated to match the review description with the production behavior

daledah · 2025-04-19T16:33:12Z

Not sure what happened to the Changed files ESLint check.

suneox · 2025-04-20T09:17:59Z

@daledah We have an issue with #59793 where the text is truncated on the duplicate review screen on Android native. This issue doesn’t occur on the latest main.

@suneox Could you provide the description that causes this bug? I tried with very long text link and can't reproduce

Screen.Recording.2025-04-19.at.22.18.27.mov

I'm using md text multiple lines

[Link](https://github.com/Expensify/App)
*Bold*
`Quote`
#58553
![image](https://d2k5nsl2zxldvw.cloudfront.net/images/animations/animation_setupguide.gif)

But it looks like doesn't happen after you change to single line for review dupplicates flow

suneox · 2025-04-20T11:29:26Z

@daledah We still have an issue on iOS Native where the report title is being split due to this data test

Screen.Recording.2025-04-20.at.18.20.02.mp4

see it at second 6

daledah · 2025-04-21T03:53:06Z

@suneox I updated.

suneox · 2025-04-21T15:31:23Z

@daledah Although this issue has been fixed but currently, the developer experience on this PR is quite poor due to the eslint fix. Since the current documentation around canBeMissing is still unclear and we don’t have any concrete guidance or required actions to handle missing data so I suggest we set canBeMissing: true for all entries on this PR, what do you think about this one?

Screen.Recording.2025-04-21.at.22.18.41.mp4

daledah · 2025-04-21T15:35:00Z

Must've been caused by the latest commit that I pushed to fix the default ID rule. I'll do a proper check and update soon.

suneox · 2025-04-21T15:51:32Z

Ok. I also left a comment and waiting for feedback from the author of the new eslint rule regarding the approach to handle legacy features vs new features.

daledah · 2025-04-22T10:58:59Z

I updated.

suneox

The change set LGTM. The alert issue was caused because we need to update canBeMissing as per the documentation. I think it's fine

Screen.Recording.2025-04-23.at.22.44.06.mp4

src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx

src/components/ReportActionItem/ReportPreview.tsx

src/pages/ReportDetailsPage.tsx

src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx

src/pages/ReportDetailsPage.tsx

iwiznia · 2025-04-24T17:38:06Z

src/pages/TransactionDuplicate/ReviewDescription.tsx

-    const [reviewDuplicates] = useOnyx(ONYXKEYS.REVIEW_DUPLICATES);
-    const compareResult = TransactionUtils.compareDuplicateTransactionFields(transactionID, reviewDuplicates?.reportID ?? '-1');
+    const transactionID = getTransactionID(route.params.threadReportID);
+    const [reviewDuplicates] = useOnyx(ONYXKEYS.REVIEW_DUPLICATES, {canBeMissing: false});


Given this key is set in line 46, I think this can be missing no?

reviewDuplicates is first created here:

App/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx

Line 336 in 069891a

setReviewDuplicatesKey({...comparisonResult.keep, duplicates, transactionID: transaction?.transactionID, reportID: transaction?.reportID});

So in ReviewDescription it's guaranteed to exist.

github-actions · 2025-04-28T20:20:55Z

🚀 Deployed to staging by https://github.com/iwiznia in version: 9.1.33-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-29T19:54:49Z

🚀 Deployed to staging by https://github.com/iwiznia in version: 9.1.35-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

github-actions · 2025-04-29T20:49:51Z

🚀 Deployed to staging by https://github.com/iwiznia in version: 9.1.36-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-04-29T22:15:52Z

🚀 Deployed to staging by https://github.com/iwiznia in version: 9.1.37-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	success ✅

github-actions · 2025-04-30T00:43:55Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.1.37-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

s77rt · 2025-05-07T20:05:40Z

src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx

Hey I think this PR is generating a canBeMissing error related to changes in this file

fix: remove markdown symbol in report header and report details page

ec047d8

daledah marked this pull request as ready for review March 31, 2025 04:54

daledah requested a review from a team as a code owner March 31, 2025 04:54

melvin-bot bot requested review from suneox and removed request for a team March 31, 2025 04:54

daledah mentioned this pull request Mar 31, 2025

[$250] Expense - Transaction thread header shows HTML tag when description has mark down #58553

Closed

8 tasks

daledah mentioned this pull request Apr 8, 2025

Expense - Choose which description to select shown as tag when description entered with markdown #59793

Closed

8 tasks

daledah added 2 commits April 8, 2025 18:30

Merge branch 'main' into fix/58553

fc97a95

fix: remove markdown symbol in money request preview

939b866

daledah added 2 commits April 9, 2025 16:36

Merge branch 'main' into fix/58553

b3630b2

fix: remove markdown symbol in duplicate review description

b29eb07

daledah added 2 commits April 9, 2025 16:40

fix: lint

3fae7b8

fix: lint

93535fc

Merge branch 'main' into fix/58553

a2ec38f

daledah added 2 commits April 19, 2025 23:15

fix: remove line breaks on transaction filter

1c111ab

fix: lint

2752f7b

fix: show single line on display names

a371d91

daledah added 2 commits April 21, 2025 15:39

Merge branch 'main' into fix/58553

11192c3

fix: lint

b2a5cb0

daledah added 2 commits April 22, 2025 17:54

Merge branch 'main' into fix/58553

87dfc9f

fix: update canBeMissing value

c88fbfa

suneox approved these changes Apr 23, 2025

View reviewed changes

melvin-bot bot requested a review from iwiznia April 23, 2025 15:52

iwiznia reviewed Apr 23, 2025

View reviewed changes

Merge branch 'main' into fix/58553

700716f

iwiznia reviewed Apr 24, 2025

View reviewed changes

daledah added 2 commits April 25, 2025 14:41

Merge branch 'main' into fix/58553

e277fe2

fix: correct canBeMissing

3a39132

iwiznia approved these changes Apr 28, 2025

View reviewed changes

iwiznia merged commit 0c53d76 into Expensify:main Apr 28, 2025
18 checks passed

github-actions bot mentioned this pull request Apr 28, 2025

Deploy Checklist: New Expensify 2025-04-28 #60971

Closed

mitarachim mentioned this pull request Apr 28, 2025

[$125] Hybrid- Code markdown have square shape #60998

Closed

8 tasks

nkdengineer mentioned this pull request May 2, 2025

Expense - Share code title shows HTML tags when expense description has mark down #61305

Closed

8 tasks

s77rt reviewed May 7, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: remove markdown symbol in report header and report details page #59328

fix: remove markdown symbol in report header and report details page #59328

daledah commented Mar 31, 2025 •

edited

Loading

melvin-bot bot commented Mar 31, 2025

daledah commented Mar 31, 2025

daledah commented Apr 7, 2025 •

edited

Loading

daledah commented Apr 8, 2025

daledah commented Apr 9, 2025

suneox commented Apr 14, 2025

suneox commented Apr 14, 2025

suneox commented Apr 14, 2025 •

edited

Loading

suneox commented Apr 14, 2025 •

edited

Loading

suneox commented Apr 14, 2025

suneox commented Apr 17, 2025 •

edited

Loading

daledah commented Apr 19, 2025

daledah commented Apr 19, 2025

daledah commented Apr 19, 2025

suneox commented Apr 20, 2025

suneox commented Apr 20, 2025

daledah commented Apr 21, 2025

suneox commented Apr 21, 2025

daledah commented Apr 21, 2025

suneox commented Apr 21, 2025

daledah commented Apr 22, 2025

suneox left a comment

iwiznia Apr 24, 2025

daledah Apr 25, 2025

github-actions bot commented Apr 28, 2025

github-actions bot commented Apr 29, 2025

github-actions bot commented Apr 29, 2025

github-actions bot commented Apr 29, 2025

github-actions bot commented Apr 30, 2025

s77rt May 7, 2025

fix: remove markdown symbol in report header and report details page #59328

fix: remove markdown symbol in report header and report details page #59328

Conversation

daledah commented Mar 31, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Mar 31, 2025

daledah commented Mar 31, 2025

daledah commented Apr 7, 2025 • edited Loading

daledah commented Apr 8, 2025

daledah commented Apr 9, 2025

suneox commented Apr 14, 2025

suneox commented Apr 14, 2025

suneox commented Apr 14, 2025 • edited Loading

suneox commented Apr 14, 2025 • edited Loading

suneox commented Apr 14, 2025

suneox commented Apr 17, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

daledah commented Apr 19, 2025

daledah commented Apr 19, 2025

daledah commented Apr 19, 2025

suneox commented Apr 20, 2025

suneox commented Apr 20, 2025

daledah commented Apr 21, 2025

suneox commented Apr 21, 2025

daledah commented Apr 21, 2025

suneox commented Apr 21, 2025

daledah commented Apr 22, 2025

suneox left a comment

Choose a reason for hiding this comment

iwiznia Apr 24, 2025

Choose a reason for hiding this comment

daledah Apr 25, 2025

Choose a reason for hiding this comment

github-actions bot commented Apr 28, 2025

github-actions bot commented Apr 29, 2025

github-actions bot commented Apr 29, 2025

github-actions bot commented Apr 29, 2025

github-actions bot commented Apr 30, 2025

s77rt May 7, 2025

Choose a reason for hiding this comment

daledah commented Mar 31, 2025 •

edited

Loading

daledah commented Apr 7, 2025 •

edited

Loading

suneox commented Apr 14, 2025 •

edited

Loading

suneox commented Apr 14, 2025 •

edited

Loading

suneox commented Apr 17, 2025 •

edited

Loading