Skip to content

[$125] Hybrid- Code markdown have square shape #60998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 8 tasks
mitarachim opened this issue Apr 28, 2025 · 19 comments
Closed
2 of 8 tasks

[$125] Hybrid- Code markdown have square shape #60998

mitarachim opened this issue Apr 28, 2025 · 19 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@mitarachim
Copy link

mitarachim commented Apr 28, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: v9.1.33-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #59328
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy s10/ Android 12, IPhone 11 / IOS 18.3.2
App Component: Chat Report View

Action Performed:

  1. Open Hybrid app
  2. Go to 1:1 Chat
  3. Write something in code markdown (eg. aaa ) or send a expense and add the markdown in description
  4. Send the message or Go to the transaction thread of the expense if you create expense

Expected Result:

The count markdown have curve at the edge.(other environments behavior)

Actual Result:

The count markdown is square in shape with no curve.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6815662_1745873867857.Screen_Recording_20250428_235301_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021918113780736378522
  • Upwork Job ID: 1918113780736378522
  • Last Price Increase: 2025-05-16
Issue OwnerCurrent Issue Owner: @jayeshmangwani
@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Apr 28, 2025
Copy link

melvin-bot bot commented Apr 28, 2025

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@thelullabyy
Copy link
Contributor

thelullabyy commented Apr 29, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

  • The count markdown is square in shape with no curve.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

  • We can update to:
            <View>
                <Text style={[boxModelStyle, textStyle]}>{data}</Text>
            </View>

or

            <View style={[boxModelStyle]}>
                <Text style={[ textStyle]}>{data}</Text>
            </View>

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

  • NA

What alternative solutions did you explore? (Optional)

@melvin-bot melvin-bot bot added the Overdue label May 1, 2025
@VictoriaExpensify
Copy link
Contributor

I think we should fix this, but it seems like a fairly low priority and a fairly easy fix, so I'm going to change the bounty to $125

@melvin-bot melvin-bot bot removed the Overdue label May 2, 2025
@VictoriaExpensify VictoriaExpensify changed the title Hybrid- Code markdown have square shape [$125] Hybrid- Code markdown have square shape May 2, 2025
Copy link

melvin-bot bot commented May 2, 2025

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@VictoriaExpensify VictoriaExpensify added the External Added to denote the issue can be worked on by a contributor label May 2, 2025
Copy link

melvin-bot bot commented May 2, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021918113780736378522

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 2, 2025
Copy link

melvin-bot bot commented May 2, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

@jayeshmangwani
Copy link
Contributor

@thelullabyy Both of your suggestions distort the text rendering. Try testing with a text message (Lorem ipsum dolor 🚀 sit amet, cons``ectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. 🚀)—you’ll see that the code markdown appears at the top of the line, while the normal text stays at the baseline.

Image

Copy link

melvin-bot bot commented May 8, 2025

@jayeshmangwani Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label May 8, 2025
@jayeshmangwani
Copy link
Contributor

Still awaiting proposals here. The one above didn’t work correctly.

@melvin-bot melvin-bot bot removed the Overdue label May 8, 2025
Copy link

melvin-bot bot commented May 9, 2025

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented May 12, 2025

@jayeshmangwani @VictoriaExpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label May 12, 2025
@linhvovan29546
Copy link
Contributor

@jayeshmangwani I think this is a duplicate of #57556

Copy link

melvin-bot bot commented May 12, 2025

@jayeshmangwani Whoops! This issue is 2 days overdue. Let's get this updated quick!

@jayeshmangwani
Copy link
Contributor

Yeeeees, both are the same.Thanks, @linhvovan29546, for linking the duplicate here.

@melvin-bot melvin-bot bot removed the Overdue label May 12, 2025
@jayeshmangwani
Copy link
Contributor

@VictoriaExpensify We can close this one—see the comment above for reference: #60998 (comment)

Copy link

melvin-bot bot commented May 16, 2025

@jayeshmangwani Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label May 16, 2025
Copy link

melvin-bot bot commented May 16, 2025

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@jayeshmangwani
Copy link
Contributor

@VictoriaExpensify bump for this comment #60998 (comment)

@melvin-bot melvin-bot bot removed the Overdue label May 19, 2025
@VictoriaExpensify
Copy link
Contributor

Closing as this is a dupe. Thanks for the bump @jayeshmangwani

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
Status: Done
Development

No branches or pull requests

5 participants