Update NewDot report action copy to make it clear when the action is automatically (vs manually) initiated #58977

twilight2294 · 2025-03-24T08:17:18Z

Explanation of Change

Similarly to OldDot, we now differentiate when a report action is done automatically by Expensify or manually by the user account

Fixed Issues

$ #53386
PROPOSAL: #53386 (comment)

Tests

Same as QA

Verify that no errors appear in the JS console

Offline tests

Cannot test offline

QA Steps

Precondition:

Workspace is connected to an integration

Testing Steps:

Create an expense report / expense
Pay it
Let it get automatically exported.

Verify that for Integrations: quickbooks, NetSuite, Xero & Intacct , the text Accounting Settings. is hyperlinked to the HelpDot page.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen_recording_20250224_195446.mp4

Android: mWeb Chrome

Screen_recording_20250224_195649.mp4

iOS: Native

Simulator.Screen.Recording.-.Expensify.testing.-.2025-02-24.at.19.50.07.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.Expensify.testing.-.2025-02-24.at.19.51.20.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-02-24.at.7.29.00.PM.mov

MacOS: Desktop

Screen.Recording.2025-02-24.at.7.39.25.PM.mov

melvin-bot · 2025-03-24T08:17:23Z

@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-03-24T13:00:45Z

🚧 @joekaufmanexpensify has triggered a test app build. You can view the workflow run here.

github-actions · 2025-03-24T17:20:41Z

🚧 @joekaufmanexpensify has triggered a test app build. You can view the workflow run here.

github-actions · 2025-03-24T18:01:20Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/58977/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Android Hybrid 🤖🔄	iOS Hybrid 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/58977-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/58977-hybrid/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/58977/NewExpensify.dmg	https://58977.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

joekaufmanexpensify · 2025-03-24T22:08:18Z

ran out of time to test today. Will test on the ad-hoc first thing tomorrow!

alitoshmatov · 2025-03-25T07:44:19Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

auto-android.mov

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

alitoshmatov

Changes looks good. Tested with my account, only export with integration is automatic and has help doc link

joekaufmanexpensify · 2025-03-25T14:18:36Z

Tested and works well for me too!

Accounting integration - manual export

No mention of exporting automatically.

2025-03-25_10-10-37.mp4

Accounting integration - automatic export

We say it was automatically exported.

2025-03-25_10-11-37.mp4

Manual export to an export file

No mention of exporting automatically.

OSBotify · 2025-03-25T15:39:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-03-26T06:14:09Z

🚀 Deployed to staging by https://github.com/cead22 in version: 9.1.19-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

nlemma · 2025-03-26T12:19:08Z

@twilight2294 This PR is failing because of issue #59146
This issue is reproducible in:
Android: HybridApp, Android: mWeb Chrome, MacOS: Chrome / Safari, MacOS: Desktop

Bug6782572_1742983331763.Screen_Recording_2025-03-26_at_3.00.34_AM.mp4

twilight2294 · 2025-03-26T14:55:25Z

Unrelated to this PR, this PR only changed the language used for stating the report action with no change to functionality

github-actions · 2025-03-27T13:31:18Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.1.19-5 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

Fix automatic exported report actions message

9361394

twilight2294 requested a review from a team as a code owner March 24, 2025 08:17

melvin-bot bot requested review from alitoshmatov and removed request for a team March 24, 2025 08:17

twilight2294 mentioned this pull request Mar 24, 2025

[Due for payment 2025-04-03] [$250] Update NewDot report action copy to make it clear when the action is automatically (vs manually) initiated #53386

Closed

joekaufmanexpensify added the Ready To Build label Mar 24, 2025

This comment has been minimized.

Sign in to view

alitoshmatov approved these changes Mar 25, 2025

View reviewed changes

melvin-bot bot requested a review from cead22 March 25, 2025 07:45

cead22 approved these changes Mar 25, 2025

View reviewed changes

cead22 merged commit 869cd0f into Expensify:main Mar 25, 2025
17 checks passed

github-actions bot mentioned this pull request Mar 26, 2025

Deploy Checklist: New Expensify 2025-03-26 #59127

Closed

50 tasks

nlemma mentioned this pull request Mar 26, 2025

Integration - Unable to Export Data from Connected Integration #59146

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update NewDot report action copy to make it clear when the action is automatically (vs manually) initiated #58977

Update NewDot report action copy to make it clear when the action is automatically (vs manually) initiated #58977

Uh oh!

twilight2294 commented Mar 24, 2025

Uh oh!

melvin-bot bot commented Mar 24, 2025

Uh oh!

github-actions bot commented Mar 24, 2025

Uh oh!

This comment has been minimized.

github-actions bot commented Mar 24, 2025

Uh oh!

github-actions bot commented Mar 24, 2025

Uh oh!

joekaufmanexpensify commented Mar 24, 2025

Uh oh!

alitoshmatov commented Mar 25, 2025

Uh oh!

alitoshmatov left a comment

Uh oh!

joekaufmanexpensify commented Mar 25, 2025

Uh oh!

Uh oh!

OSBotify commented Mar 25, 2025

Uh oh!

github-actions bot commented Mar 26, 2025

Uh oh!

nlemma commented Mar 26, 2025 •

edited

Loading

Uh oh!

twilight2294 commented Mar 26, 2025

Uh oh!

github-actions bot commented Mar 27, 2025

Uh oh!

Uh oh!

Update NewDot report action copy to make it clear when the action is automatically (vs manually) initiated #58977

Update NewDot report action copy to make it clear when the action is automatically (vs manually) initiated #58977

Uh oh!

Conversation

twilight2294 commented Mar 24, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 24, 2025

Uh oh!

github-actions bot commented Mar 24, 2025

Uh oh!

This comment has been minimized.

github-actions bot commented Mar 24, 2025

Uh oh!

github-actions bot commented Mar 24, 2025

Uh oh!

joekaufmanexpensify commented Mar 24, 2025

Uh oh!

alitoshmatov commented Mar 25, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

alitoshmatov left a comment

Choose a reason for hiding this comment

Uh oh!

joekaufmanexpensify commented Mar 25, 2025

Accounting integration - manual export

Accounting integration - automatic export

Manual export to an export file

Uh oh!

Uh oh!

OSBotify commented Mar 25, 2025

Uh oh!

github-actions bot commented Mar 26, 2025

Uh oh!

nlemma commented Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

twilight2294 commented Mar 26, 2025

Uh oh!

github-actions bot commented Mar 27, 2025

Uh oh!

Uh oh!

nlemma commented Mar 26, 2025 •

edited

Loading