fix: add sender name #58271

nkdengineer · 2025-03-12T10:31:17Z

Explanation of Change

Fixed Issues

$ #57038
PROPOSAL: #57038 (comment)

Tests

Open any DM or other chat that only has a single participant
Send a message in the chat
Verify that You also appears in LHN

Verify that no errors appear in the JS console

Offline tests

Same

QA Steps

Open any DM or other chat that only has a single participant
Send a message in the chat
Verify that You also appears in LHN

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-03-14T18:14:22Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

nkdengineer · 2025-03-14T18:17:25Z

@shawnborton this PR is opened

shawnborton · 2025-03-17T07:59:56Z

Thanks, cc @Expensify/design for viz. Going to run a test build now.

github-actions · 2025-03-17T08:00:31Z

🚧 @shawnborton has triggered a test app build. You can view the workflow run here.

shawnborton · 2025-03-17T08:54:23Z

cc @Expensify/design @JmillsExpensify @trjExpensify I was thinking that we wanted to add the "You" for DMs, but I didn't realize this change would also add the sender name for a DM preview if the message comes from the other person. For example, this:

shawnborton · 2025-03-17T08:55:02Z

That feels a little overkill, right? I think maybe we don't need that for the DM sender if it isn't yourself... but I can also see the argument for consistency and that we should show the sender name everywhere.

dubielzyk-expensify · 2025-03-17T10:43:39Z

Don't feel super strongly here but would agree that it feels a bit overkill

trjExpensify · 2025-03-17T10:53:13Z

If WhatsApp is the example, they don't include You: or <senderFirstName>: in DMs, only groups.

shawnborton · 2025-03-17T10:59:09Z

Yeah, that's kinda what I was thinking we'd follow too. Okay, @nkdengineer can you update please? No need to use the sender name in DMs unless it is You. Thanks!

dannymcclain · 2025-03-17T13:43:45Z

No need to use the sender name in DMs unless it is You.

This works for me, but I personally don't really hate it how it currently is. Y'all are probably right that it's a bit overkill though.

nkdengineer · 2025-03-18T08:22:53Z

@shawnborton i updated

shawnborton · 2025-03-18T08:48:56Z

Thanks! Running a new test build now.

github-actions · 2025-03-18T08:49:28Z

🚧 @shawnborton has triggered a test app build. You can view the workflow run here.

github-actions · 2025-03-18T09:24:11Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/58271/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/58271/index.html

Android Hybrid 🤖🔄	iOS Hybrid 🍎🔄
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Android Hybrid build failed	The QR code can't be generated, because the iOS Hybrid build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/58271/NewExpensify.dmg	https://58271.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

shawnborton · 2025-03-18T16:21:14Z

Feels pretty good to me, @allroundexperts please continue with getting this into final review - thanks!

allroundexperts · 2025-03-21T08:02:38Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Unable to build android

Android: mWeb Chrome

Screen.Recording.2025-03-21.at.1.51.06.PM.mov

iOS: Native

Screen.Recording.2025-03-21.at.1.40.28.PM.mov

iOS: mWeb Safari

Screen.Recording.2025-03-21.at.1.39.38.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-03-21.at.1.30.29.PM.mov

MacOS: Desktop

Screen.Recording.2025-03-21.at.1.35.45.PM.mov

allroundexperts

Looks good!

mountiny · 2025-03-21T13:13:24Z

@nkdengineer can you please merge main?

OSBotify · 2025-03-21T13:51:18Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-03-21T22:44:22Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.17-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-03-24T21:14:51Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.1.17-1 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

fix: add sender name in DM

2de13e7

nkdengineer mentioned this pull request Mar 12, 2025

[Due for payment 2025-03-31] [Due for payment 2025-03-21] [Due for payment 2025-03-17] [$250] Ensure Message Previews Always Include Sender Name, Even for Own Messages in Admin Room #57038

Closed

8 tasks

nkdengineer changed the title ~~fix: add sender name in DM~~ fix: add sender name Mar 14, 2025

nkdengineer added 2 commits March 15, 2025 00:28

revert useless code

87413e4

fix: add sender name

eaf9c8f

nkdengineer marked this pull request as ready for review March 14, 2025 18:14

nkdengineer requested a review from a team as a code owner March 14, 2025 18:14

melvin-bot bot requested a review from allroundexperts March 14, 2025 18:14

melvin-bot bot removed the request for review from a team March 14, 2025 18:14

fix lint

73450ef

shawnborton added the Ready To Build label Mar 17, 2025

This comment has been minimized.

Sign in to view

fix don't show sender name in case MD

a6f0413

allroundexperts approved these changes Mar 21, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny March 21, 2025 08:55

mountiny assigned nkdengineer Mar 21, 2025

mountiny approved these changes Mar 21, 2025

View reviewed changes

Merge branch 'main' into follow-up/57038

998b355

mountiny merged commit 1a2963c into Expensify:main Mar 21, 2025
16 checks passed

github-actions bot mentioned this pull request Mar 21, 2025

Deploy Checklist: New Expensify 2025-03-21 #58928

Closed

65 tasks

This was referenced Mar 24, 2025

LHN - Concierge does not show sender in LHN but it shows "Expensify" in search result #58943

Open

[Due for payment 2025-04-16] [$250] Track expense - LHN preview shows "Expensify: tracking x" after dismissing actionable whisper #58944

Closed

thelullabyy mentioned this pull request Apr 3, 2025

[Due for payment 2025-05-28] [Due for payment 2025-05-23] [$250] LHN - When paying someone, chat preview shows "You" and also user name before payment info. #59566

Closed

8 tasks

samranahm mentioned this pull request Apr 8, 2025

[Due for payment 2025-06-16] [Due for payment 2025-06-13] [$250] LHN - Email is displayed instead of user name on LHN message preview #59812

Open

8 tasks

joekaufmanexpensify mentioned this pull request Apr 15, 2025

[Due for payment 2025-04-14] [$250] Search - 1:1 DM preview in the search router does not display "You" as the sender #58939

Closed

8 tasks

fix: add sender name #58271

fix: add sender name #58271

Uh oh!

Conversation

nkdengineer commented Mar 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Mar 14, 2025

Uh oh!

nkdengineer commented Mar 14, 2025

Uh oh!

shawnborton commented Mar 17, 2025

Uh oh!

github-actions bot commented Mar 17, 2025

Uh oh!

This comment has been minimized.

shawnborton commented Mar 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shawnborton commented Mar 17, 2025

Uh oh!

dubielzyk-expensify commented Mar 17, 2025

Uh oh!

trjExpensify commented Mar 17, 2025

Uh oh!

shawnborton commented Mar 17, 2025

Uh oh!

dannymcclain commented Mar 17, 2025

Uh oh!

nkdengineer commented Mar 18, 2025

Uh oh!

shawnborton commented Mar 18, 2025

Uh oh!

github-actions bot commented Mar 18, 2025

Uh oh!

github-actions bot commented Mar 18, 2025

Uh oh!

shawnborton commented Mar 18, 2025

Uh oh!

allroundexperts commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allroundexperts left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny commented Mar 21, 2025

Uh oh!

Uh oh!

OSBotify commented Mar 21, 2025

Uh oh!

github-actions bot commented Mar 21, 2025

Uh oh!

github-actions bot commented Mar 24, 2025

Uh oh!

Uh oh!

nkdengineer commented Mar 12, 2025 •

edited

Loading

shawnborton commented Mar 17, 2025 •

edited

Loading

allroundexperts commented Mar 21, 2025 •

edited

Loading