[Due for payment 2025-04-16] [$250] Track expense - LHN preview shows "Expensify: tracking x" after dismissing actionable whisper

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.17-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Left Hand Navigation (LHN)

Action Performed:

Precondition:

• Account has self DM.

1. Go to staging.new.expensify.com
2. Go to self DM.
3. Track a manual expense.
4. Click Do nothing.

Expected Result:

LHN preview will show "You: tracking x" after dismissing actionable whisper.

Actual Result:

LHN preview shows "Expensify: tracking x" after dismissing actionable whisper.
It only shows "You: tracking x" after reopening the chat.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021904639203158747322
• Upwork Job ID: 1904639203158747322
• Last Price Increase: 2025-03-25

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @flaviadefaria

[melvin-bot]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Track expense - LHN preview shows "Expensify: tracking x" after dismissing actionable whisper

What is the root cause of that problem?

We are getting the lastActorAccountID from report but when we press nothing report.lastActorAccountID not update and lastActorDetails remain same

App/src/libs/SidebarUtils.ts

Line 507 in 8deddfa

let lastActorDetails: Partial<PersonalDetails> | null = report.lastActorAccountID && personalDetails?.[report.lastActorAccountID] ? personalDetails[report.lastActorAccountID] : null;

Then we call getLastActorDisplayName with same lastActorDetails

App/src/libs/SidebarUtils.ts

Line 519 in 8deddfa

const lastActorDisplayName = getLastActorDisplayName(lastActorDetails);

lastActorDetails.accountID was same as previous that make bellow condition remain true

App/src/libs/OptionsListUtils.ts

Line 541 in 8deddfa

return lastActorDetails.accountID !== currentUserAccountID

What changes do you think we should make in order to solve the problem?

We should get the lastActorAccountID from lastAction

    const lastActorAccountID = lastAction?.actorAccountID ?? report.lastActorAccountID;

and update this logic like this

let lastActorDetails: Partial<PersonalDetails> | null = lastActorAccountID && personalDetails?.[lastActorAccountID] ? personalDetails[lastActorAccountID] : null;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

RESULTS

Screen.Recording.2025-03-22.at.1.18.00.PM.mov

[flaviadefaria]

I was able to reproduce it. I don't think it should be a deploy blocker though. What are your thoughts @cristipaval?

[cristipaval]

I agree, it is a NAB. This is the offending PR

[cristipaval]

@nkdengineer could you please comment here so that I can assign you to this?

Also, I added @allroundexperts as the C+ since they reviewed the offending PR

[nkdengineer]

I'm here.

[samranahm]

@nkdengineer One of the solution is, pass the report param in function call here

App/src/libs/SidebarUtils.ts

Line 519 in b7f3f5b

const lastActorDisplayName = getLastActorDisplayName(lastActorDetails);

and update the function like this

function getLastActorDisplayName(lastActorDetails: Partial<PersonalDetails> | null, report?: OnyxEntry<Report>) {
if (!lastActorDetails || isSelfDM(report)) {
    return '';
}

WYT

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021904639203158747322

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.24-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: update the sender name in self DM and search router #59282

If no regressions arise, payment will be issued on 2025-04-16. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @nkdengineer requires payment (Needs manual offer from BZ)

[melvin-bot]

@allroundexperts @flaviadefaria @allroundexperts The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Current assignee @flaviadefaria is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[flaviadefaria]

Hi @abekkala, I'll be OOO during this time (I'm off until the 23rd) - would you mind finishing the payment here when due? Thank You 🙇‍♀

[abekkala]

@flaviadefaria did you send an offer already?

@nkdengineer requires payment (Needs manual offer from BZ)

I'm not seeing one in your previous posts above but don't want to send another

[abekkala]

PAYMENT SUMMARY FOR APRIL 16

• Fix: @nkdengineer [$250, if no regressions] OFFER If one was already sent to you by @flaviadefaria let me know and I can cancel this one.
• PR Review: @allroundexperts [$250, if no regressions] Payment via NewDot
  please complete checklist

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @allroundexperts owed $250 via NewDot
• ROLE: @nkdengineer paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@abekkala)

• I have verified the correct assignees and roles are listed above and updated the necessary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1904639203158747322/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[allroundexperts]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: The author is well aware of the issue and raised this follow up PR. No need for a comment.

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

• Account has self DM.

Test:

1. Go to self DM.
2. Track a manual expense.
3. Click Do nothing.

Verify that the LHN preview will show "You: tracking x" after dismissing actionable whisper.

Do we agree 👍 or 👎

[abekkala]

@nkdengineer can you please accept the upwork offer?
#58944 (comment)

[abekkala]

posting payment summary once more:

PAYMENT SUMMARY FOR APRIL 16

• Fix: @nkdengineer [$250] OFFER PAID and contract ended - thank you! 🎉
• PR Review: @allroundexperts [$250] Payment via NewDot

[nkdengineer]

@abekkala Accepted, thanks!!