[No QA] Unable to clear the RBR from the archived workspace chat - Add Unit test #57830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s77rt
suggested changes
Mar 5, 2025
tests/unit/SidebarUtilsTest.ts
Outdated
| private_isArchived: DateUtils.getDBTime(), | ||
| }; | ||
|
|
||
| await Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${MOCK_REPORT.reportID}`, MOCK_REPORT); |
There was a problem hiding this comment.
Suggested change
| await Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${MOCK_REPORT.reportID}`, MOCK_REPORT); |
Not needed
tests/unit/SidebarUtilsTest.ts
Outdated
| }; | ||
|
|
||
| await Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${MOCK_REPORT.reportID}`, MOCK_REPORT); | ||
| await Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${MOCK_REPORT.reportID}`, reportNameValuePairs); |
There was a problem hiding this comment.
Suggested change
| await Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${MOCK_REPORT.reportID}`, reportNameValuePairs); | |
| await Onyx.set(`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${MOCK_REPORT.reportID}`, reportNameValuePairs); |
NAB. Just so we don't confuse values that were set in other tests (if any)
tests/unit/SidebarUtilsTest.ts
Outdated
Comment on lines
421
to
436
| it('returns false when report is archived', () => { | ||
| const MOCK_REPORT: Report = { | ||
| reportID: '5', | ||
| errorFields: { | ||
| export: { | ||
| error: 'Some error occurred', | ||
| }, | ||
| }, | ||
| }; | ||
| const MOCK_REPORT_ACTIONS: OnyxEntry<ReportActions> = {}; | ||
| const MOCK_TRANSACTION_VIOLATIONS: OnyxCollection<TransactionViolation[]> = {}; | ||
|
|
||
| const result = SidebarUtils.shouldShowRedBrickRoad(MOCK_REPORT, MOCK_REPORT_ACTIONS, false, MOCK_TRANSACTION_VIOLATIONS); | ||
|
|
||
| expect(result).toBe(false); | ||
| }); |
There was a problem hiding this comment.
Can you set the report value pairs here too or add a comment that explains that this report is already archived from previous tests
|
@s77rt I updated PR. Please take a look. Thanks |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
@thelullabyy Please add |
thelullabyy
changed the title
s77rt
approved these changes
Mar 12, 2025
90 tasks
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.13-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.1.13-5 🚀
|
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$#56724
PROPOSAL:#56724 (comment)
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop