[Due for payment 2025-03-24] [Due for payment 2025-03-03] [$250] Unable to clear the RBR from the archived workspace chat

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: need reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation (hyperlinked to channel name): quality

Action Performed:

1. Have some expenses with RBR in the workspace chat
2. Archive the workspace chat
3. Open the expense and try to remove the RBR

Expected Result:

Should be able to clear the RBR

Actual Result:

Not able to clear the RBR from the workspace chat

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Please refer to OP in slack for screenshots

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021891200627941812784
• Upwork Job ID: 1891200627941812784
• Last Price Increase: 2025-02-16
• Automatic offers:
• thelullabyy | Contributor | 106153410

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @MariaHCD (AutoAssignerNewDotQuality)

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[s77rt]

I can reproduce. The only way to clear the RBR is to open all the RBR expenses

Screen.Recording.2025-02-12.at.1.11.51.PM.mov

[thelullabyy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Not able to clear the RBR from the workspace chat

What is the root cause of that problem?

• In the function responsible for displaying the RBR in the LHN, the current implementation
  

  App/src/libs/SidebarUtils.ts

  Line 336 in 4f3a2ee

  function getReasonAndReportActionThatHasRedBrickRoad(

  
  does not account for whether the report is archived.

• Currently, the only way to clear the RBR is by opening all expenses associated with it. The backend (BE) will then clear the transaction violation in the response of the OpenReport API call.

What changes do you think we should make in order to solve the problem?

• We can prevent displaying the RBR if the report is archived. So in this line we can return null if isArchivedReportWithID(report.reportID) is true.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• We can simulate the report with transaction violations and it is archived then verify whether the RBR is shown.

What alternative solutions did you explore? (Optional)

• We can also hide the RBR in the ReportPreview, MoneyRequestPreviewContent by checking whether the report is archived.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021891200627941812784

[melvin-bot]

Current assignee @s77rt is eligible for the External assigner, not assigning anyone new.

[mallenexpensify]

Contributor: @thelullabyy paid $250 via Upwork
Contributor+: @s77rt due $250 via NewDot.

@s77rt can you please fill out the Regression Test Proposal Template in the BZ checklist so I can get a test case created or updated? Thx

[s77rt]

@mallenexpensify Is a regression test still needed if an automated test is created? I think not as the automated test would be equally effective as a manual one

[s77rt]

cc @thelullabyy Can you prioritize the automated test PR on this?

[thelullabyy]

@s77rt I'm currently working on it and will be raising the PR soon.

[thelullabyy]

@s77rt I've created PR add automated test. Please help to check. Thanks

[s77rt]

test PR is merged. This should be ready for payment

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.13-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] Unable to clear the RBR from the archived workspace chat - Add Unit test #57830

If no regressions arise, payment will be issued on 2025-03-24. 🎊

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment through NewDot Manual Requests
• @thelullabyy requires payment automatic offer (Contributor)

[melvin-bot]

@s77rt @strepanier03 @s77rt The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[strepanier03]

@s77rt - Can you take care of the checklist for this one? Then I can do the payment summary.

@thelullabyy - Sorry I missed this sitting in weekly, not sure why it didn't flip over to daily. I'll handle the payment today so you'll be all set.

[strepanier03]

Hmmm, @thelullabyy - The contract was already paid and closed when I tried to action it, not sure how that happened. If you're seeing anything different let me know.

[s77rt]

@strepanier03 checklist done in #56724 (comment) and @thelullabyy has been already paid based on #56724 (comment)

[strepanier03]

Payment Summary

• $250 - @s77rt via NewDot Manual Requests
• $250 - @thelullabyy paid via Upwork

[JmillsExpensify]

$250 approved for @s77rt