[Fix] Create Expense - Submits To Display Name Missing #57426

JKobrynski · 2025-02-25T19:00:48Z

Explanation of Change

The conclusion based on my investigation is that the condition in getManagerAccountID util function was not detailed enough, it was missing a check for defaultApprover which prevented the function from reaching the default return in that scenario.

Fixed Issues

$ #56609
PROPOSAL: N/A

Tests

Add yourself to a workspace with very large group of members. (e.g. policyID: 8A152FCBCD316665)
Click on the FAB > Create Expense.
Go to the participant list and verify that all workspaces show the Submits to field (especially the one with a lot of members).

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Tests section above

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

iOS: Native

ios-compressed.mp4

MacOS: Chrome / Safari

web-compressed.mov

melvin-bot · 2025-02-25T19:02:19Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mananjadhav · 2025-02-25T19:50:33Z

@JKobrynski The results are still flaky for me. Submits to is missing until I go and select the workspace in the expense. Here too I need to select a few times before it starts showing up. Checkout the first and the second workspace in the list.

web-display-name.mov

JKobrynski · 2025-02-26T09:35:39Z

@mananjadhav got it, I am going to take a closer look at it today

mananjadhav · 2025-02-26T09:37:36Z

Yes, and I think for the QA I would recommend:

Signout and signin
and/or Clear cache and restart.

…9-display-name-missing

JKobrynski · 2025-02-27T09:31:11Z

@mananjadhav it's weird, because for me that participant's list looks different, it has more data fields. I wonder where the difference comes from 🤔

And I still can't reproduce the bug, I cleared cache and reloged on all platforms. Maybe we should trigger a test build? Wdyt?

mananjadhav · 2025-02-27T10:11:20Z

Yes we can trigger an adhoc build, but are you not added the Applause workspace? If yes you can filter in the search bar?

JKobrynski · 2025-02-27T11:33:05Z

It's the last item in the list on the screenshot 😄

JKobrynski · 2025-02-28T08:51:43Z

@mananjadhav wdyt? 😄

mananjadhav · 2025-02-28T08:58:43Z

Yeah. I am confused. I think let’s get an adhoc build and also may be test on a few accounts.

JKobrynski · 2025-02-28T09:03:06Z

Great, thanks! Let me know if you find anything!

mananjadhav · 2025-02-28T19:04:54Z

I think I had some code/branch mess up. It's deleted and forked the branch again, it seems to be working - with/without cache clear. I have all the screenshots except Android. Finishing the checklist.

mananjadhav · 2025-02-28T19:12:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web-submits-to.mov

MacOS: Desktop

mananjadhav · 2025-02-28T19:12:57Z

src/libs/PolicyUtils.ts

@@ -609,11 +609,11 @@ function getManagerAccountID(policy: OnyxEntry<Policy> | SearchPolicy, expenseRe
    }

    const employee = policy?.employeeList?.[employeeLogin];
-    if (!employee) {
+    if (!employee && !defaultApprover) {


@JKobrynski I think this is a good candidate for a unit test.

All right, I'm on it!

mananjadhav · 2025-02-28T19:13:33Z

@JKobrynski Can we add a unit test for the same and also sync with the latest main?

…9-display-name-missing

mananjadhav · 2025-03-03T16:19:40Z

@JKobrynski any updates on this?

JKobrynski · 2025-03-03T17:26:26Z

@mananjadhav I'm still on it, should be done today/tommorow morning

mananjadhav · 2025-03-03T17:53:26Z

thanks for the update.

…9-display-name-missing

JKobrynski · 2025-03-04T11:39:24Z

@mananjadhav done! Unit tests added

mananjadhav · 2025-03-04T19:15:13Z

Thanks @JKobrynski. @grgia All yours.

grgia

LGTM ! :)

OSBotify · 2025-03-05T11:55:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-03-06T23:15:08Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.1.10-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-03-10T21:10:40Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.10-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

fix the condition in getManagerAccountID

1872d70

JKobrynski changed the title ~~fix the condition in getManagerAccountID~~ [Fix] Create Expense - Submits To Display Name Missing Feb 25, 2025

JKobrynski mentioned this pull request Feb 25, 2025

[Due for payment 2025-03-17] [Create Expense] Submits To Display Name Missing #56609

Closed

JKobrynski marked this pull request as ready for review February 25, 2025 19:02

JKobrynski requested a review from a team as a code owner February 25, 2025 19:02

melvin-bot bot requested a review from mananjadhav February 25, 2025 19:02

melvin-bot bot removed the request for review from a team February 25, 2025 19:02

JKobrynski added 2 commits February 26, 2025 14:35

Merge remote-tracking branch 'upstream/main' into JKobrynski/fix/5660…

c7288ed

…9-display-name-missing

Merge remote-tracking branch 'upstream/main' into JKobrynski/fix/5660…

8bf4885

…9-display-name-missing

mananjadhav reviewed Feb 28, 2025

View reviewed changes

Merge remote-tracking branch 'upstream/main' into JKobrynski/fix/5660…

b75a0f2

…9-display-name-missing

JKobrynski added 2 commits March 4, 2025 12:31

add unit tests for getManagerAccountID util

982c6d4

Merge remote-tracking branch 'upstream/main' into JKobrynski/fix/5660…

4ce0268

…9-display-name-missing

mananjadhav approved these changes Mar 4, 2025

View reviewed changes

melvin-bot bot requested a review from grgia March 4, 2025 19:05

grgia approved these changes Mar 5, 2025

View reviewed changes

grgia merged commit ed75020 into Expensify:main Mar 5, 2025
17 checks passed

github-actions bot mentioned this pull request Mar 6, 2025

Deploy Checklist: New Expensify 2025-03-06 #57963

Closed

93 tasks

[Fix] Create Expense - Submits To Display Name Missing #57426

[Fix] Create Expense - Submits To Display Name Missing #57426

Uh oh!

Conversation

JKobrynski commented Feb 25, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Feb 25, 2025

Uh oh!

mananjadhav commented Feb 25, 2025

Uh oh!

JKobrynski commented Feb 26, 2025

Uh oh!

mananjadhav commented Feb 26, 2025

Uh oh!

JKobrynski commented Feb 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mananjadhav commented Feb 27, 2025

Uh oh!

JKobrynski commented Feb 27, 2025

Uh oh!

JKobrynski commented Feb 28, 2025

Uh oh!

mananjadhav commented Feb 28, 2025

Uh oh!

JKobrynski commented Feb 28, 2025

Uh oh!

mananjadhav commented Feb 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mananjadhav commented Feb 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mananjadhav Feb 28, 2025

Choose a reason for hiding this comment

Uh oh!

JKobrynski Mar 3, 2025

Choose a reason for hiding this comment

Uh oh!

mananjadhav commented Feb 28, 2025

Uh oh!

mananjadhav commented Mar 3, 2025

Uh oh!

JKobrynski commented Mar 3, 2025

Uh oh!

mananjadhav commented Mar 3, 2025

Uh oh!

JKobrynski commented Mar 4, 2025

Uh oh!

mananjadhav commented Mar 4, 2025

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Mar 5, 2025

Uh oh!

github-actions bot commented Mar 6, 2025

Uh oh!

github-actions bot commented Mar 10, 2025

Uh oh!

Uh oh!

JKobrynski commented Feb 27, 2025 •

edited

Loading

mananjadhav commented Feb 28, 2025 •

edited

Loading

mananjadhav commented Feb 28, 2025 •

edited

Loading