[Due for payment 2025-03-17] [Create Expense] Submits To Display Name Missing

[grgia]

Original Thread

Problem:

• getAccountsByID is failing to retrieve the "Submits To" display name in workspaces with a large number of members.
• Possible cause is Onyx might not fully load objects when an array (e.g., employeeList) contains many records, causing missing properties.

Repro Steps:

1. Add yourself to a workspace with very large group of members. (e.g. policyID: 8A152FCBCD316665)
2. Click on the FAB > Create Expense.
3. Go to the participant list and verify that for most workspaces it shows Submits to but ones with large members doesn't show.

Debug Findings:

• Adding debug logs in ReportUtils.ts confirms that submitsToAccountDetails is sometimes undefined.

Issue Owner

Current Issue Owner: @alexpensify / @slafortune

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[JKobrynski]

HI I'm Julian from Callstack and I'd like to work on this issue

[JKobrynski]

Update:

I started working on this issue today.

[JKobrynski]

Update:

I wanted to check if #56770 fixes this issue but unfortunately it doesn't. I am still able to reproduce it on that other branch, using a workspace that has many members on iOS.

[JKobrynski]

FYI I'm going to be OOO next week, coming back on Monday February 24th.

[mananjadhav]

Will be picked by @JKobrynski once they're back from OOO.

[grgia]

Making weekly until Julian's back

[melvin-bot]

@mananjadhav @alexpensify @grgia @JKobrynski this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[JKobrynski]

@grgia @mananjadhav I'm back, it can be daily again!

[grgia]

WOOP

[JKobrynski]

Update:

I spent some time on further debugging this issue, no clear solutions yet.

[JKobrynski]

Update:

I had more time today so I did a lot of testing and debugging on different platforms and accounts. It's interesting because it wouldn't reproduce for users who only have 1-2 workspaces (including Applause's Workspace 1).

Moreover, now it also reproduces for me on the web, not only iOS.

This is just an FYI, still looking for a fix!

[JKobrynski]

Update:

The PR is ready for review!

[mananjadhav]

Just finished with the review, it's working. Have asked for the tests.

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[alexpensify]

🚨 Heads up! 🚨
I’ll be offline until Wednesday, March 12, 2025, and won’t be actively monitoring this GitHub during that time.

@slafortune —This GitHub might require payment while I'm offline. I'm reassigning the label to avoid delays. Thanks!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.10-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Fix] Create Expense - Submits To Display Name Missing #57426

If no regressions arise, payment will be issued on 2025-03-17. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @JKobrynski does not require payment (Contractor)

[melvin-bot]

@mananjadhav @alexpensify / @slafortune @mananjadhav The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @mananjadhav owed $250 via NewDot
• Contributor: @JKobrynski is from an agency-contributor and not due payment

BugZero Checklist (@alexpensify)

• I have verified the correct assignees and roles are listed above and updated the necessary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[alexpensify]

Contributor: @JKobrynski no payment due - agency
Contributor+: @mananjadhav owed $250 via NewDot - please submit a request in Chat

[garrettmknight]

$250 approved for @mananjadhav