-
Notifications
You must be signed in to change notification settings - Fork 3.2k
play success sound on report approval #56455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2025-02-09.at.3.05.54.in.the.afternoon.movAndroid: mWeb ChromeScreen.Recording.2025-02-09.at.2.35.48.in.the.afternoon.moviOS: NativeScreen.Recording.2025-02-25.at.9.09.43.at.night.moviOS: mWeb SafariScreen.Recording.2025-02-09.at.2.40.45.in.the.afternoon.movMacOS: Chrome / SafariScreen.Recording.2025-02-09.at.2.32.00.in.the.afternoon.movMacOS: DesktopScreen.Recording.2025-02-09.at.2.49.34.in.the.afternoon.mov |
@allgandalf not able to get the sound on iOS native, could you try? also lets complete the screen recording in the checklist. |
Bump @allgandalf |
I totally missed your last message, I will check this tomorrow |
i can confirm that i can hear the sound on iOS native!, also recordings updated |
@allgandalf could you also pull main? somehow unti tests are failing. |
@getusha , done |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.1.9-0 🚀
|
🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.1.9-0 🚀
|
@allgandalf Failing on Android and iOS with original issue #55683 |
🚀 Deployed to production by https://github.com/puneetlath in version: 9.1.9-8 🚀
|
Explanation of Change
Fixed Issues
$ #55683
PROPOSAL: #55683 (comment)
Tests
Same as QA
Offline tests
Same as QA
QA Steps
Verify that
SUCCESS
sound is played everytime we approve a reportPR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2025-02-25.at.2.48.49.PM.mov
Android: mWeb Chrome
Screen.Recording.2025-02-25.at.2.49.58.PM.mov
iOS: Native
Screen.Recording.2025-02-25.at.2.42.09.PM.mov
iOS: mWeb Safari
Screen.Recording.2025-02-25.at.2.46.11.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2025-02-06.at.1.39.41.PM.mov
MacOS: Desktop
Screen.Recording.2025-02-25.at.2.43.22.PM.mov