Merge pull request #56455 from allgandalf/playsuccessSound

stitesExpensify · web-flow · commit ccf52d9d5b0f · 2025-03-03T14:38:42.000-05:00
play success sound on report approval
diff --git a/src/libs/actions/IOU.ts b/src/libs/actions/IOU.ts
@@ -8513,6 +8513,7 @@ function approveMoneyRequest(expenseReport: OnyxEntry<OnyxTypes.Report>, full?:
         optimisticHoldReportExpenseActionIDs,
     };
 
+    playSound(SOUNDS.SUCCESS);
     API.write(WRITE_COMMANDS.APPROVE_MONEY_REQUEST, parameters, {optimisticData, successData, failureData});
 }
 
diff --git a/src/libs/actions/Search.ts b/src/libs/actions/Search.ts
@@ -326,6 +326,7 @@ function approveMoneyRequestOnSearch(hash: number, reportIDList: string[], trans
     const failureData: OnyxUpdate[] = createOnyxData({errors: getMicroSecondOnyxErrorWithTranslationKey('common.genericErrorMessage')});
     const finallyData: OnyxUpdate[] = createOnyxData({isActionLoading: false});
 
+    playSound(SOUNDS.SUCCESS);
     API.write(WRITE_COMMANDS.APPROVE_MONEY_REQUEST_ON_SEARCH, {hash, reportIDList}, {optimisticData, failureData, finallyData});
 }
 

Original file line number	Diff line number	Diff line change
`@@ -8513,6 +8513,7 @@ function approveMoneyRequest(expenseReport: OnyxEntry<OnyxTypes.Report>, full?:`
`8513`	`8513`	`optimisticHoldReportExpenseActionIDs,`
`8514`	`8514`	`};`
`8515`	`8515`
	`8516`	`+ playSound(SOUNDS.SUCCESS);`
`8516`	`8517`	`API.write(WRITE_COMMANDS.APPROVE_MONEY_REQUEST, parameters, {optimisticData, successData, failureData});`
`8517`	`8518`	`}`
`8518`	`8519`
Original file line number	Diff line number	Diff line change
`@@ -326,6 +326,7 @@ function approveMoneyRequestOnSearch(hash: number, reportIDList: string[], trans`
`326`	`326`	`const failureData: OnyxUpdate[] = createOnyxData({errors: getMicroSecondOnyxErrorWithTranslationKey('common.genericErrorMessage')});`
`327`	`327`	`const finallyData: OnyxUpdate[] = createOnyxData({isActionLoading: false});`
`328`	`328`
	`329`	`+ playSound(SOUNDS.SUCCESS);`
`329`	`330`	`API.write(WRITE_COMMANDS.APPROVE_MONEY_REQUEST_ON_SEARCH, {hash, reportIDList}, {optimisticData, failureData, finallyData});`
`330`	`331`	`}`
`331`	`332`