[Copy update] VBA Throttled error

[aldo-expensify]

Details

Removed if statement here because I think it is always true

App/src/pages/ReimbursementAccount/ReimbursementAccountPage.js

Lines 164 to 165 in b37e87e

	const throttledEnd = moment().add(24, 'hours');
	if (moment() < throttledEnd) {

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/177017

Tests / QA

1. Create an account in OldDot and verify it.
2. In OldDot, while logged in, open the console in chrome developers tools and enter: API.setNameValuePair({name: 'expensify_ACHData_throttled', value: 'yes'})
3. Go to NewDot, log in
4. Create a workspace and start the VBA flow
5. You should see the error:

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

[aldo-expensify]

Update: removed unused import

[aldo-expensify]

About how to reproduce the throttle error

There were two slack conversations about this:

https://expensify.slack.com/archives/C020EPP9B9A/p1632955388190500
https://expensify.slack.com/archives/C6PHQ660K/p1633030710387500

As a summary, I understand the following:

• The throttle can happen when we get one of these two errors when verifying a bank account agains Giact.
• We call Giact_API::verifyWithdrawalAccount from here to verify a bank account against their API.
• We handle a verification error here

My plan was to find a bank account that would fail with BANK_ACCOUNT_NOT_GOOD_STANDING, but I could not move forward because the connection with Giact doesn't seem to be working. https://expensify.slack.com/archives/C03TQ48KC/p1633040741101300

[kevinksullivan]

@marcaaron I recall you finding this error here. This may be of help @aldo-expensify ? Ultimately I think if we cover the other cases, we can safely deprioiritze this case and put it in a follow up issue to ensure we're staying on top of more common/valuable polish.

[marcaaron]

Feels like we are maybe getting sidetracked with trying to do a local reproduction. We can just set the NVP manually so we can test the copy? Just my 2 cents but I don't think it's necessary to fully reproduce a throttled bank account on dev (pretty sure that when I saw that copy I forced it to appear and did not mess with KYC checks at all).

[aldo-expensify]

NVP

Makes sense, I'll try that. Thanks!

[aldo-expensify]

@marcaaron idea to use NVP worked perfectly fine. Added it to the Test / QA steps.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @Dal-Papa in version: 1.1.5-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @chiragsalian in version: 1.1.6-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅