[CP Staging] Fixed submit button behavior in search #54012

mjasikowski · 2024-12-12T10:54:05Z

Explanation of Change

Altered the button submit behaviour in search to mimic the report preview submit button.

Fixed Issues

$ #53989

Tests

Precondition:

Delayed submission is enabled.
Admin is the approver.
"Prevent self-approvals" is enabled.

Go to staging.new.expensify.com
Go to workspace chat.
Submit an expense.
Note that Submit button is disabled.
Go to Search.
Click Submit button on the same expense in Step 3.

Submit button should also be disabled in Search when "Prevent self-approvals" is enabled.n.
--->
// TODO: These must be filled out, or the issue title must include "[No QA]."

Offline tests

QA Steps

Explanation of Change

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-12-12T14:55:53Z

@eh2077 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allgandalf · 2024-12-12T15:27:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

src/components/SelectionList/Search/TransactionListItemRow.tsx

allgandalf · 2024-12-12T15:47:24Z

PR failing for small screens:

Co-authored-by: Gandalf <[email protected]>

allgandalf · 2024-12-12T16:32:28Z

and now conflicts 😞

luacmartins · 2024-12-12T18:18:12Z

src/components/SelectionList/Search/TransactionListItemRow.tsx

@@ -266,6 +267,10 @@ function TransactionListItemRow({
    const theme = useTheme();

    const isOnHold = useMemo(() => TransactionUtils.isOnHold(item), [item]);
+    const shouldDisableItemAction = useMemo(
+        () => item.action === CONST.SEARCH.ACTION_TYPES.SUBMIT && !ReportUtils.isAllowedToSubmitDraftExpenseReport(ReportUtils.getReport(item.reportID)),


This line might fail since the Search data is contained within the snapshot_ key and ReportUtils.getReport will try to look for data in the report_ key

We need to pass the snapshot data to it

I opened a new PR here that changes the behavior to show View instead of submit #54056

luacmartins · 2024-12-13T00:02:27Z

We can close this PR now

mjasikowski added 2 commits December 12, 2024 11:48

Added isDisabled prop for ActionCell

6ca283f

Fixed submit button behavior in search

36f2319

mjasikowski marked this pull request as ready for review December 12, 2024 14:55

mjasikowski requested a review from a team as a code owner December 12, 2024 14:55

mjasikowski self-assigned this Dec 12, 2024

melvin-bot bot requested review from eh2077 and removed request for a team December 12, 2024 14:55

This comment was marked as outdated.

Sign in to view

mountiny requested review from allgandalf and removed request for eh2077 December 12, 2024 15:24

mountiny changed the title ~~Fixed submit button behavior in search~~ [CP Staging] Fixed submit button behavior in search Dec 12, 2024

mountiny previously approved these changes Dec 12, 2024

View reviewed changes

allgandalf reviewed Dec 12, 2024

View reviewed changes

src/components/SelectionList/Search/TransactionListItemRow.tsx Outdated Show resolved Hide resolved

Update src/components/SelectionList/Search/TransactionListItemRow.tsx

4ad04e4

Co-authored-by: Gandalf <[email protected]>

mountiny dismissed their stale review via 4ad04e4 December 12, 2024 15:58

mountiny and others added 3 commits December 12, 2024 17:16

Update ExpenseItemHeaderNarrow.tsx

b2099b4

Update TransactionListItemRow.tsx

1e3f59b

Prettier

8fe53ca

Merge remote-tracking branch 'origin/main' into michal-fix-search-submit

112cb67

luacmartins requested changes Dec 12, 2024

View reviewed changes

luacmartins closed this Dec 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[CP Staging] Fixed submit button behavior in search #54012

[CP Staging] Fixed submit button behavior in search #54012

Uh oh!

mjasikowski commented Dec 12, 2024 •

edited

Loading

Uh oh!

melvin-bot bot commented Dec 12, 2024

Uh oh!

This comment was marked as outdated.

allgandalf commented Dec 12, 2024

Uh oh!

Uh oh!

allgandalf commented Dec 12, 2024

Uh oh!

allgandalf commented Dec 12, 2024

Uh oh!

luacmartins Dec 12, 2024

Uh oh!

luacmartins Dec 12, 2024

Uh oh!

luacmartins Dec 12, 2024

Uh oh!

luacmartins commented Dec 13, 2024

Uh oh!

Uh oh!

[CP Staging] Fixed submit button behavior in search #54012

[CP Staging] Fixed submit button behavior in search #54012

Uh oh!

Conversation

mjasikowski commented Dec 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

Explanation of Change

QA Steps

PR Author Checklist

Screenshots/Videos

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 12, 2024

Uh oh!

This comment was marked as outdated.

allgandalf commented Dec 12, 2024

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

allgandalf commented Dec 12, 2024

Uh oh!

allgandalf commented Dec 12, 2024

Uh oh!

luacmartins Dec 12, 2024

Choose a reason for hiding this comment

Uh oh!

luacmartins Dec 12, 2024

Choose a reason for hiding this comment

Uh oh!

luacmartins Dec 12, 2024

Choose a reason for hiding this comment

Uh oh!

luacmartins commented Dec 13, 2024

Uh oh!

Uh oh!

mjasikowski commented Dec 12, 2024 •

edited

Loading