[HOLD for payment 2024-12-20] Search - Submit button is not disabled in Search when "Prevent self-approvals" is enabled

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.75-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Search

Action Performed:

Precondition:

• Delayed submission is enabled.
• Admin is the approver.
• "Prevent self-approvals" is enabled.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit an expense.
4. Note that Submit button is disabled.
5. Go to Search.
6. Click Submit button on the same expense in Step 3.

Expected Result:

Submit button should also be disabled in Search when "Prevent self-approvals" is enabled.

Actual Result:

Submit button is not disabled in Search when "Prevent self-approvals" is enabled.
User can still submit expenses in Search.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6691772_1733977172282.20241212_121613.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @mjasikowski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

Not repro on production

bandicam.2024-12-12.06-31-56-649.mp4

[mjasikowski]

Looking into it

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Submit button is not disabled in Search when "Prevent self-approvals" is enabled.
User can still submit expenses in Search.

What is the root cause of that problem?

We only disabled the button while offline

App/src/components/SelectionList/Search/ActionCell.tsx

Line 113 in bf38806

isDisabled={isOffline}

What changes do you think we should make in order to solve the problem?

1. Add new props isDisabledButton to ActionCell component

   isDisabled={isOffline || isDisabledButton}

2. Change the background color while the button is disabled in getButtonInnerStyles function

App/src/components/SelectionList/Search/ActionCell.tsx

Lines 55 to 62 in bf38806

	const getButtonInnerStyles = useCallback(
	(shouldUseSuccessStyle: boolean) => {
	if (!isSelected) {
	return {};
	}
	return shouldUseSuccessStyle ? styles.buttonSuccessHovered : styles.buttonDefaultHovered;
	},
	[isSelected, styles],

3. Calculate isDisabledButton from TransactionListItemRow and pass it to ExpenseItemHeaderNarrow -> ActionCell

    const report = ReportUtils.getReport(item.reportID);
    const isDisabledButton = !ReportUtils.isAllowedToSubmitDraftExpenseReport(report);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Like we did in MoneyReportHeader here, we can add new props shouldShowButton and add new variable shouldShowSubmitButton in TransactionListItemRow

App/src/components/MoneyReportHeader.tsx

Lines 146 to 152 in bf38806

	const shouldShowSubmitButton =
	!!moneyRequestReport &&
	isDraft &&
	reimbursableSpend !== 0 &&
	!hasAllPendingRTERViolations &&
	!shouldShowBrokenConnectionViolation &&
	(moneyRequestReport?.ownerAccountID === currentUserAccountID || isAdmin || moneyRequestReport?.managerID === currentUserAccountID);

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[mjasikowski]

Discussing the expected behavior on Slack

[mjasikowski]

In the meantime I have a draft PR to replicate the behavior from report previews if we agree to follow that: https://github.com/Expensify/App/pull/54012/files

[luacmartins]

Fixed in staging

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.75-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix submit action #54056

If no regressions arise, payment will be issued on 2024-12-20. 🎊

For reference, here are some details about the assignees on this issue:

• @allgandalf requires payment (Needs manual offer from BZ)

[melvin-bot]

@allgandalf @sakluger @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[allgandalf]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: N/A This was a regression

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

No regression test, the original PR should cover the tests

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

[melvin-bot]

Payment Summary

Upwork Job

• C+: @allgandalf offered $250 via Upwork (https://www.upwork.com/nx/wm/offer/105455673)

BugZero Checklist (@sakluger)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[allgandalf]

♻️ Pending payment...

[melvin-bot]

@mjasikowski, @sakluger, @luacmartins, @allgandalf Whoops! This issue is 2 days overdue. Let's get this updated quick!

[allgandalf]

Checklist ✅ ♻️ Pending payment...

[sakluger]

Sorry @allgandalf for the delay, I was OOO the past few days due to holiday travel.

Here's the Upwork contract: https://www.upwork.com/nx/wm/offer/105455673. Please let me know once you've accepted the contract and I will complete payment. Thanks!

[allgandalf]

Accepted, thank you so much 😄 and happy holidays 🎁 🎄

[sakluger]

All paid, thanks again!