Attendee Tracking: Created AttendeeSelectionPage #48008

zfurtak · 2024-08-26T15:16:18Z

Details

Fixed Issues

$ #47171
$ #47172
PROPOSAL:

Tests

Click + -> Submit expense
Choose workspace, amount
On expense summary screen, expand options
Attendees menu item should be seen with displayName of the current user(who are creating the expanse)
Click on the attendees
Attendees selection page should appear with this user user selected
Also on the screen should be seen sections Recents and Contacts without workspaces in them
You should be able to choose someone, then they should appear in the top section
Click Save -> Attendees button should have now users who were chosen

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…tionList

…labs/expensify-app-fork into attendee-47171

src/pages/iou/request/step/IOURequestStepAttendees.tsx

src/libs/actions/IOU.ts

src/libs/OptionsListUtils.ts

blazejkustra · 2024-08-30T13:24:30Z

src/libs/OptionsListUtils.ts

@@ -1661,7 +1668,7 @@ function getUserToInviteOption({
        showChatPreviewLine,
    });
    userToInvite.isOptimisticAccount = true;
-    userToInvite.login = searchValue;
+    userToInvite.login = isValidEmail || isValidPhoneNumber ? searchValue : '';


Make sure it doesn't break filtering logic for participants screen and others (by looking at the usage)

src/components/MoneyRequestConfirmationListFooter.tsx

src/pages/iou/request/MoneyRequestAttendeeSelector.tsx

filip-solecki · 2024-09-04T07:39:06Z

@ZhenjaHorbach again all yours 😄

ZhenjaHorbach · 2024-09-04T08:22:06Z

I am not sure is it a bug or not
Since we need to wait recentAttendees
But I set includeRecentReports: true for testing

And when I open screen Recents list is empty, but when I unselect submitter of the Request
I have full Recents list

2024-09-04.10.18.18.mov

filip-solecki · 2024-09-04T08:25:01Z

Looks like a bug, let me check

ZhenjaHorbach · 2024-09-04T08:55:07Z

@filip-solecki
And I'm sorry 😅
But I found another issue
We can't find submitter of the Request using search

filip-solecki · 2024-09-04T09:07:38Z

@ZhenjaHorbach can you upload a video?

ZhenjaHorbach · 2024-09-04T09:09:47Z

But actually it works a bit strange

When we open screen, we couldn't find the submitter using search
But if we unselect, submitter will be always visible using search

2024-09-04.11.08.55.mov

…labs/expensify-app-fork into attendee-47171

blazejkustra

The diff just got hugee (we need to merge the newest main on the feature branch)

Also @zfurtak / @filip-solecki let's add test steps to the description 👀

Julesssss · 2024-09-04T12:44:41Z

Thanks all, this is looking good. As we haven't yet made the backend changes available to you I think we are in a good place to merge to the feature branch. Then we can create bugs for the remaining issues.

Once main is merged I'm going to add a C+ reviewer to try to locate other bugs that may have been mixed.

ZhenjaHorbach · 2024-09-04T13:14:01Z

In this case React Compiler left !

https://github.com/Expensify/App/actions/runs/10701554408/job/29667753333?pr=48008

ZhenjaHorbach · 2024-09-04T15:25:16Z

@zfurtak
Thanks for fixing !
But sorry for making you do extra work
We can ignore this particular problem following this comment 😅

But it's optional
In any case LGTM !

zfurtak · 2024-09-04T15:42:28Z

@ZhenjaHorbach don't worry! it was not very elegant but for sure quick fix 😊

And when I open screen Recents list is empty, but when I unselect submitter of the Request
I have full Recents list

About this bug, I couldn't reproduce it, did you do anything special? 😅

When we open screen, we couldn't find the submitter using search
But if we unselect, submitter will be always visible using search

This one I managed to reproduce and indeed it's very weird... I will look into this right now 🕵️‍♀️

ZhenjaHorbach · 2024-09-04T15:46:58Z

And when I open screen Recents list is empty, but when I unselect submitter of the Request
I have full Recents list

About this bug, I couldn't reproduce it, did you do anything special? 😅

Yeah
I set includeRecentReports: true for testing
But I think it's not critical
Since first of all we need to start using recentAttendees (which is not ready yet)
And then retest this issue

blazejkustra

LGTM!

Julesssss · 2024-09-05T11:36:16Z

Okay, this is looking good. Let's merge these changes to the feature branch so we can get the backend changes in place for you. Then we can handle the remaining bugs (recent empty, workspaces showing in list, ect)

zfurtak and others added 24 commits July 23, 2024 15:10

Enable name in the filter function

93edf8b

Blank commit

a53c355

Merge branch 'main' into @zfurtak/atendee-tracking-enable-names-selec…

34d58c6

…tionList

Added shouldAcceptName prop

fc456f3

Merge branch 'main' into @zfurtak/enables-plain-string

7b8649a

Merge branch 'main' into screen

cb2e4f0

create new route for attendee screen

d2bf2d5

create attendee screen + selector

a355c43

WIP: temporary access attendee from merchant option

ae38408

Added translations

d1eb72c

Merge branch 'main' into attendee-47171

79d0d00

Changed type to Attendee

1c248a1

Merge branch 'main' into attendee-47171

a6ae379

WIP

1d91de1

Fix TS and Lint

923df86

Fix not existing user selection

21d8a88

Merge branch 'main' into attendee-47171

da74588

Merge branch 'attendee-47171' of https://github.com/software-mansion-…

db64c0a

…labs/expensify-app-fork into attendee-47171

Adjusted requestMoney function

2318920

Added saving attendees

ea44c0c

Merge branch 'main' into attendee-47171

2d52cec

Adjusted submitting expense with attendees

0716dff

Fixed ts and lint errors

56e365d

Added per person to attendee title

29e2bfd

blazejkustra suggested changes Aug 30, 2024

View reviewed changes

zfurtak added 2 commits August 30, 2024 19:29

Added recents attendees

d001c91

Adjusted to review

a8e6354

zfurtak marked this pull request as ready for review August 30, 2024 19:10

zfurtak requested a review from a team as a code owner August 30, 2024 19:10

melvin-bot bot requested a review from ZhenjaHorbach August 30, 2024 19:10

filip-solecki added 2 commits September 4, 2024 09:35

Set max recent attendees value to 5

97dfef4

Move rest of recents to top of contacts

b048b80

zfurtak added 2 commits September 4, 2024 14:06

Merge branch 'main' into attendee-47171

dadb5c2

Merge branch 'attendee-47171' of https://github.com/software-mansion-…

50c006e

…labs/expensify-app-fork into attendee-47171

zfurtak requested a review from a team as a code owner September 4, 2024 12:22

blazejkustra suggested changes Sep 4, 2024

View reviewed changes

Fixed React Compiler issue

105bd76

zfurtak requested a review from blazejkustra September 4, 2024 15:16

ZhenjaHorbach approved these changes Sep 4, 2024

View reviewed changes

melvin-bot bot requested a review from Julesssss September 4, 2024 15:25

blazejkustra approved these changes Sep 5, 2024

View reviewed changes

Julesssss approved these changes Sep 5, 2024

View reviewed changes

Julesssss merged commit 7641012 into Expensify:feature-attendeeTracking Sep 5, 2024
18 checks passed

This was referenced Oct 25, 2024

[Tracking] [External] Attendee Tracking project #44725

Open

[HOLD for payment] Attendee Tracking feature C+ reviews #51484

Closed

melvin-bot bot mentioned this pull request Oct 29, 2024

[HOLD for payment 2024-11-05] [HIGH] [Attendee Tracking] Create Attendees item row for requests #47172

Closed

francoisl mentioned this pull request Mar 4, 2025

[Due for payment 2025-04-14] Move attendees from Transaction type to Comment #57717

Closed

zfurtak deleted the attendee-47171 branch April 4, 2025 13:07

Attendee Tracking: Created AttendeeSelectionPage #48008

Attendee Tracking: Created AttendeeSelectionPage #48008

Uh oh!

Conversation

zfurtak commented Aug 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

Uh oh!

blazejkustra Aug 30, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

filip-solecki commented Sep 4, 2024

Uh oh!

ZhenjaHorbach commented Sep 4, 2024

Uh oh!

filip-solecki commented Sep 4, 2024

Uh oh!

ZhenjaHorbach commented Sep 4, 2024

Uh oh!

filip-solecki commented Sep 4, 2024

Uh oh!

ZhenjaHorbach commented Sep 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blazejkustra left a comment

Choose a reason for hiding this comment

Uh oh!

Julesssss commented Sep 4, 2024

Uh oh!

ZhenjaHorbach commented Sep 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Sep 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zfurtak commented Sep 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Sep 4, 2024

Uh oh!

blazejkustra left a comment

Choose a reason for hiding this comment

Uh oh!

Julesssss commented Sep 5, 2024

Uh oh!

Uh oh!

Uh oh!

zfurtak commented Aug 26, 2024 •

edited

Loading

ZhenjaHorbach commented Sep 4, 2024 •

edited

Loading

ZhenjaHorbach commented Sep 4, 2024 •

edited

Loading

ZhenjaHorbach commented Sep 4, 2024 •

edited

Loading

zfurtak commented Sep 4, 2024 •

edited

Loading