Skip to content

[HOLD for payment 2024-11-05] [CRITICAL] [Attendee Tracking] Create AttendeeSelectionPage #47171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Julesssss opened this issue Aug 9, 2024 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Design Engineering Weekly KSv2

Comments

@Julesssss
Copy link
Contributor

Create the new AttendeeSelectionPage that will be shown when creating and editing a request. IAttendees are essentially names/emails of users that may or may not exist and are listed simply as a string. If recent attendees already exist (provided via NVP data that will be introduced by backend changes) up to 5 will be displayed in Recents at a higher priority than the contacts we typically display under 'Recents'. Attendee data will be passed to the API under this structure.

Screenshot 2024-08-09 at 15 33 23

Requirements

  • Display up to 5 recent attendees under the under Recents header
  • Display any excluded recent attendees under 'Contacts'
  • Allow new recent attendees to be created and passed to the server (optimistic with feedback API pattern) (data structure)
  • At least one attendee must be selected

More details here in the design document.

@Julesssss
Copy link
Contributor Author

Hey @zfurtak @filip-solecki, it would be great if you could make a start on this issue. I'm around for any questions and we'll be focusing on the backend issue for persisting and passing the attendee Onyx data back to the client.

I believe you should be able to workaround that in the meantime 🤞

Feel free to further break down these tasks, and we can merge these to a branch like this until the backend issues are completed feature-attendeeTracking. Let me know if you have any further questions.

@filip-solecki
Copy link
Contributor

Hi! I am Filip from SWM and I'd like to work on this!

@Julesssss Julesssss assigned filip-solecki and unassigned Julesssss Aug 20, 2024
@Julesssss
Copy link
Contributor Author

Hey @filip-solecki, just checking in to see if I can help with anything here?

@filip-solecki
Copy link
Contributor

Hi! I was focused on CSV Import and didn't make significant progress, but good news is that @robertKozik will help me here so it should speed up this project 🚀

@zfurtak
Copy link
Contributor

zfurtak commented Aug 27, 2024

Hello, I will take over this issue from Robert, since he's no longer working on this project 😊

@melvin-bot melvin-bot bot added the Overdue label Aug 27, 2024
@Julesssss Julesssss assigned zfurtak and unassigned filip-solecki Aug 27, 2024
@melvin-bot melvin-bot bot removed the Overdue label Aug 27, 2024
@Julesssss
Copy link
Contributor Author

Hey @zfurtak, that's great. Let me know if you have any questions! We're currently working on the second backend issue.

Copy link

melvin-bot bot commented Aug 30, 2024

@zfurtak Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Aug 30, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 Overdue labels Aug 30, 2024
@Julesssss
Copy link
Contributor Author

PR submitted and in review here

Copy link

melvin-bot bot commented Sep 2, 2024

Triggered auto assignment to @dubielzyk-expensify (Design), see these Stack Overflow questions for more details.

@Julesssss
Copy link
Contributor Author

Hey @dubielzyk-expensify. We're seeking your thoughts for how to implement the NewDot attendee tracking page. When the user deselect themselves we're not sure where they should appear in the list for re-selection. Vertical space is limited so I'm not convinced by a new section header personally. But Contacts, and Recents also aren't great categories to put the user under 😕

Screenshot 2024-09-02 at 13 38 06

Here is a comment on the PR that explains in more details.

@Julesssss Julesssss self-assigned this Sep 2, 2024
@dubielzyk-expensify
Copy link
Contributor

But Contacts, and Recents also aren't great categories to put the user under 😕

Why? Recents feels good to me? It was recently picked or unpicked? Feels like on the top of Recent is the right go without creating a new section (or replacing recents with a new section)

@Julesssss
Copy link
Contributor Author

Okay, thank you. We'll pin to the top of recent 👍

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 29, 2024
@melvin-bot melvin-bot bot changed the title [CRITICAL] [Attendee Tracking] Create AttendeeSelectionPage [HOLD for payment 2024-11-05] [CRITICAL] [Attendee Tracking] Create AttendeeSelectionPage Oct 29, 2024
Copy link

melvin-bot bot commented Oct 29, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 29, 2024
Copy link

melvin-bot bot commented Oct 29, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.54-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-05. 🎊

For reference, here are some details about the assignees on this issue:

  • @zfurtak does not require payment (Contractor)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Design Engineering Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

4 participants