-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[HOLD for payment 2024-11-05] [CRITICAL] [Attendee Tracking] Create AttendeeSelectionPage #47171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hey @zfurtak @filip-solecki, it would be great if you could make a start on this issue. I'm around for any questions and we'll be focusing on the backend issue for persisting and passing the attendee Onyx data back to the client. I believe you should be able to workaround that in the meantime 🤞 Feel free to further break down these tasks, and we can merge these to a branch like this until the backend issues are completed |
Hi! I am Filip from SWM and I'd like to work on this! |
Hey @filip-solecki, just checking in to see if I can help with anything here? |
Hi! I was focused on CSV Import and didn't make significant progress, but good news is that @robertKozik will help me here so it should speed up this project 🚀 |
Hello, I will take over this issue from Robert, since he's no longer working on this project 😊 |
Hey @zfurtak, that's great. Let me know if you have any questions! We're currently working on the second backend issue. |
@zfurtak Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
PR submitted and in review here |
Triggered auto assignment to @dubielzyk-expensify ( |
Hey @dubielzyk-expensify. We're seeking your thoughts for how to implement the NewDot attendee tracking page. When the user deselect themselves we're not sure where they should appear in the list for re-selection. Vertical space is limited so I'm not convinced by a new section header personally. But Contacts, and Recents also aren't great categories to put the user under 😕 Here is a comment on the PR that explains in more details. |
Why? Recents feels good to me? It was recently picked or unpicked? Feels like on the top of Recent is the right go without creating a new section (or replacing |
Okay, thank you. We'll pin to the top of recent 👍 |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.54-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-11-05. 🎊 For reference, here are some details about the assignees on this issue:
|
Create the new AttendeeSelectionPage that will be shown when creating and editing a request. IAttendees are essentially names/emails of users that may or may not exist and are listed simply as a string. If recent attendees already exist (provided via NVP data that will be introduced by backend changes) up to 5 will be displayed in Recents at a higher priority than the contacts we typically display under 'Recents'. Attendee data will be passed to the API under this structure.
Requirements
More details here in the design document.
The text was updated successfully, but these errors were encountered: