Show not found for invalid report or transaction in review duplicates confirmation page #45965

gijoe0295 · 2024-07-22T20:57:35Z

Details

Fixed Issues

$ #46179
$ #45835
PROPOSAL: #45835 (comment)

Tests

For Web & mWeb:

Submit 2 duplicated expenses
Press Review duplicates >> Keep this one (any)
Proceed to confirmation page
Modify the report ID in the URL to anything and navigate to it
Verify not found page appears

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

See Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-07-25.at.07.28.40-source.mov

Android: mWeb Chrome

Screen.Recording.2024-07-25.at.07.27.27-source.mov

iOS: Native

iOS: mWeb Safari

Untitled.mov

Screen.Recording.2024-07-25.at.07.31.59-source.mov

MacOS: Chrome / Safari

Screen.Recording.2024-07-25.at.07.08.14-source.mov

MacOS: Desktop

…cate confirmation page

melvin-bot · 2024-07-25T00:30:50Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

gijoe0295 · 2024-07-25T00:40:56Z

src/pages/TransactionDuplicate/Confirmation.tsx

+    }
+
+    // eslint-disable-next-line rulesdir/no-negated-variables
+    const shouldShowNotFoundPage = isEmptyObject(report) || ReportUtils.isReportNotFound(report) || (!isExiting && status === 'loaded' && !transaction?.transactionID);


When reportID is invalid, report can either be undefined or have errorFields.notFound (on large screens only since the underneath ReportScreen would fetch report data by OpenReport).

REVIEW_DUPLICATES entry takes a long time to load, we need to wait for it by status.

When we close the confirmation page RHP, it would be reset due to:

App/src/libs/Navigation/AppNavigator/Navigators/RightModalNavigator.tsx

Line 65 in 95f946a

abandonReviewDuplicateTransactions();

so not found page would briefly show when the RHP is closing. isExiting check was added for that.

I see. Is there a better way to manage the abandonReviewDuplicateTransactions(); without mixing navigation logic on this component? Maybe we delegate this function call when navigation is completed. For example, using transitionEnd event instead of blur if that go hand-in-hand replacement for that.

@parasharrajat As you've reviewed the duplicate confirmation PR, could you let me know what these lines are for?

App/src/libs/Navigation/AppNavigator/Navigators/RightModalNavigator.tsx

Lines 57 to 64 in 95f946a

if (

// @ts-expect-error There is something wrong with a types here and it's don't see the params list

navigation.getState().routes.find((routes) => routes.name === NAVIGATORS.RIGHT_MODAL_NAVIGATOR)?.params?.screen ===

SCREENS.RIGHT_MODAL.TRANSACTION_DUPLICATE ||

route.params?.screen !== SCREENS.RIGHT_MODAL.TRANSACTION_DUPLICATE

) {

return;

}

In other words, when exactly should abandonReviewDuplicateTransactions be called?

I just want to confirm if transitionEnd could replace blur.

This tells that If user is leaving from TRANSACTION_DUPLICATE Modal Stack from RHN view.

@parasharrajat transitionEnd does not fire when closing the RHP. Last resort may be setTimeout?

Even if transitionEnd worked, the page would unmount then so we couldn't find it in navigation state.

OK. I am fine with the approach for now.

gijoe0295 · 2024-07-25T00:42:36Z

src/pages/TransactionDuplicate/Confirmation.tsx

+    }, [navigation]);
+
+    if (status === 'loading') {
+        return <FullScreenLoadingIndicator />;


Due to the isExiting check as explained above, we should show a loading indicator when the data is loading, otherwise we would have empty data shows briefly.

parasharrajat

@gijoe0295 There is a comment above.

pecanoro

Looks good but there are conflicts

parasharrajat · 2024-07-30T10:55:21Z

@gijoe0295 There are some conflicts to resolve and I have a comment #45965 (comment).

gijoe0295 · 2024-07-30T11:10:15Z

Yeah I knew that. Been investigating since ytd.

src/pages/TransactionDuplicate/Confirmation.tsx

gijoe0295 · 2024-08-01T15:10:50Z

Updated.

parasharrajat · 2024-08-01T18:21:17Z

@gijoe0295 This PR is not solving #45835 properly. It takes some time before the not found page is shown.

01.08.2024_23.50.37_REC.mp4

gijoe0295 · 2024-08-01T22:01:01Z

@parasharrajat Solved it.

gijoe0295 · 2024-08-01T22:10:23Z

src/pages/TransactionDuplicate/Confirmation.tsx

+    // eslint-disable-next-line rulesdir/no-negated-variables
+    const shouldShowNotFoundPage =
+        isEmptyObject(report) ||
+        !ReportUtils.isValidReport(report) ||


When report has been loaded from Onyx but was still loading from the BE, it's prefilled with reportName without reportID.

…o reportID in route

gijoe0295 · 2024-08-12T06:32:55Z

@parasharrajat I updated. Detailed test steps for this case are:

In thread transaction report, press Review duplicates
Choose the other duplicate transaction that does not belong to the (current) report from step 1

It should not show not found page.

parasharrajat · 2024-08-13T14:43:32Z

Now, There is another issue where the confirm page data is shown for a moment while closing.

Steps:

make two sets of duplicates requests.
Open the review duplicate flow for the first set. Go to till Confirm page.
Copy the url.
Now Open the review duplicate flow for the second set and then reach till confirm page.
Close the confirm page.
Now open the copied URL directly from address bar.
Close the confirm page by clicking back area.
Notive the data is shown while page is closing.

13.08.2024_20.05.39_REC.mp4

gijoe0295 · 2024-08-13T14:59:22Z

Thanks, taking a look now.

parasharrajat · 2024-08-13T15:23:24Z

Please run the test cases from both issues and a couple of edge scenarios before requesting next review.

dylanexpensify · 2024-08-14T17:13:47Z

@gijoe0295 when can we expect this to be ready for another round of reviews, taking in @parasharrajat's comment above?

…isExitingPage check

gijoe0295 · 2024-08-14T17:48:39Z

@parasharrajat The minimal reproducible steps for your issue are:

Review duplicates till the confirmation page
Replace the reportID in URL with any valid transaction thread report ID (so it contains a valid transaction)
Verify not found page shows (✅ correct)
Close the RHP
Notice the transaction data from step 2 shows briefly ⛔️

Expected behavior: Keep showing not found page ✅

Reason is due to the isExitingPage check here where we do not show not found page if we're CLOSING the RHP.

So root cause leads back to the abandonReviewDuplicateTransactions getting called on blur event. The problem is that blur is triggered right when we close the RHP and the CLOSING transition is on going.

My proposed solution is to forcefully delay that function call by InteractionManager.runAfterInteractions so that it would only be called once the RHP is completely closed (i.e. the closing transition ends). By that we can eliminate isExitingPage check as well.

gijoe0295 · 2024-08-14T17:54:47Z

I found another issue that paid expenses are included in review duplicates and if we chose to keep it, we would have not found page:

However, paid expenses should not be there and would be handled in #46372. So NAB.

parasharrajat · 2024-08-14T19:57:56Z

Paid expenses will show on this page. That is expected. But we are changing the resolution behavior around them. Anyways, that is a separate issue. Does that affect your changes on this PR?

parasharrajat · 2024-08-14T19:58:34Z

Why can't we depend on the isExistingPage as we were doing before?

gijoe0295 · 2024-08-15T03:17:36Z

@parasharrajat

Does that affect your changes on this PR?

Yes it does. The current behavior on main is in #46372. But in this PR, it would show not found page if we press Keep this one on the paid expenses.

Paid expenses will show on this page.

Based on #46372 (comment), are we going to hide Keep this one for paid expenses? If so that wouldn't be a problem.

gijoe0295 · 2024-08-15T03:20:45Z

Why can't we depend on the isExistingPage as we were doing before?

isExitingPage will cause the bug we mentioned in #45965 (comment) and #45965 (comment). Because that makes NotFoundPage disappears when we're EXITING/CLOSING the page.

const shouldShowNotFoundPage = !isExtingPage && ...

parasharrajat · 2024-08-15T07:53:12Z

Ok so we used IsExistingPage to prevent `NotFound page from showing on close. Now this is a completely opposite case where we want to remain the notFoundpage if it has to be shown on the main page on closing.

gijoe0295 · 2024-08-15T08:43:01Z

@parasharrajat That's correct. But one problem is that abandonReviewDuplicateTransactions still needs to be called when we close the RHP. So I delay that function call by InteractionManager.runAfterInteractions. That makes sure it would only be called once the RHP is completely closed.

src/libs/Navigation/AppNavigator/Navigators/RightModalNavigator.tsx

parasharrajat · 2024-08-15T15:04:54Z

Screenshots

🔲 iOS / native

15.08.2024_20.48.25_REC.mp4

🔲 iOS / Safari

15.08.2024_20.51.04_REC.mp4

🔲 MacOS / Desktop

15.08.2024_20.41.26_REC.mp4

🔲 MacOS / Chrome

15.08.2024_20.38.13_REC.mp4

🔲 Android / Chrome

15.08.2024_21.00.31_REC.mp4

🔲 Android / native

15.08.2024_20.58.40_REC.mp4

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

parasharrajat · 2024-08-15T15:32:18Z

@gijoe0295 Good job on the PR. Thanks for your patience.

OSBotify · 2024-08-16T20:48:31Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-08-19T16:14:03Z

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.0.22-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-08-19T17:10:43Z

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.0.22-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-08-20T22:43:42Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.0.22-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

gijoe0295 added 5 commits July 23, 2024 03:52

show not found page for invalid report or transaction in review dupli…

dcfd9e7

…cate confirmation page

fix: not found briefly when data is loading

57113d5

fix: not found briefly when closing rhp

d0dec61

fix: empty data briefly when refresh page

25dd71a

Merge branch 'main' of https://github.com/gijoe0295/App into gijoe/45835

d235782

gijoe0295 marked this pull request as ready for review July 25, 2024 00:30

gijoe0295 requested a review from a team as a code owner July 25, 2024 00:30

melvin-bot bot removed the request for review from a team July 25, 2024 00:30

melvin-bot bot requested a review from parasharrajat July 25, 2024 00:30

show not found when report is undefined

b001f62

gijoe0295 commented Jul 25, 2024

View reviewed changes

gijoe0295 mentioned this pull request Jul 25, 2024

Dupe detection - Confirmation page RHP turns to not here page while dismissing #46179

Closed

6 tasks

parasharrajat suggested changes Jul 29, 2024

View reviewed changes

pecanoro previously approved these changes Jul 30, 2024

View reviewed changes

Merge branch 'main' of https://github.com/gijoe0295/App into gijoe/45835

a6f5190

gijoe0295 dismissed pecanoro’s stale review via a6f5190 July 31, 2024 06:53

Merge branch 'main' of https://github.com/gijoe0295/App into gijoe/45835

e854d85

parasharrajat suggested changes Jul 31, 2024

View reviewed changes

src/pages/TransactionDuplicate/Confirmation.tsx Outdated Show resolved Hide resolved

src/pages/TransactionDuplicate/Confirmation.tsx Outdated Show resolved Hide resolved

src/pages/TransactionDuplicate/Confirmation.tsx Outdated Show resolved Hide resolved

resolve feedbacks

e08a9bd

gijoe0295 added 2 commits August 2, 2024 04:34

Merge branch 'main' of https://github.com/gijoe0295/App into gijoe/45835

270ffd1

fix: not found when report is loading

9f2294e

show not found in case transaction and report does not match

37d8dd0

gijoe0295 commented Aug 1, 2024

View reviewed changes

gijoe0295 added 2 commits August 12, 2024 09:59

Merge branch 'main' of https://github.com/gijoe0295/App into gijoe/45835

f4e8685

fix: not found when select the other duplicate that does not belong t…

4d8ae30

…o reportID in route

delay abandonReviewDuplicateTransactions function call and eliminate …

b2ee36c

…isExitingPage check

parasharrajat reviewed Aug 15, 2024

View reviewed changes

src/libs/Navigation/AppNavigator/Navigators/RightModalNavigator.tsx Show resolved Hide resolved

parasharrajat approved these changes Aug 15, 2024

View reviewed changes

melvin-bot bot requested a review from stitesExpensify August 15, 2024 15:31

add comment

545d78e

stitesExpensify approved these changes Aug 16, 2024

View reviewed changes

stitesExpensify merged commit 6fd16ac into Expensify:main Aug 16, 2024
15 checks passed

github-actions bot mentioned this pull request Aug 19, 2024

Deploy Checklist: New Expensify 2024-08-19 #47639

Closed

77 tasks

daledah mentioned this pull request Sep 5, 2024

fix: Description review appears when distance expenses are created without description #48422

Merged

50 tasks

	if (
	// @ts-expect-error There is something wrong with a types here and it's don't see the params list
	navigation.getState().routes.find((routes) => routes.name === NAVIGATORS.RIGHT_MODAL_NAVIGATOR)?.params?.screen ===
	SCREENS.RIGHT_MODAL.TRANSACTION_DUPLICATE \|\|
	route.params?.screen !== SCREENS.RIGHT_MODAL.TRANSACTION_DUPLICATE
	) {
	return;
	}

Show not found for invalid report or transaction in review duplicates confirmation page #45965

Show not found for invalid report or transaction in review duplicates confirmation page #45965

Uh oh!

Conversation

gijoe0295 commented Jul 22, 2024 • edited by flodnv Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jul 25, 2024

Uh oh!

gijoe0295 Jul 25, 2024

Choose a reason for hiding this comment

Uh oh!

parasharrajat Jul 26, 2024

Choose a reason for hiding this comment

Uh oh!

gijoe0295 Jul 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

parasharrajat Jul 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gijoe0295 Jul 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gijoe0295 Jul 31, 2024

Choose a reason for hiding this comment

Uh oh!

parasharrajat Jul 31, 2024

Choose a reason for hiding this comment

Uh oh!

gijoe0295 Jul 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

parasharrajat left a comment

Choose a reason for hiding this comment

Uh oh!

pecanoro left a comment

Choose a reason for hiding this comment

Uh oh!

parasharrajat commented Jul 30, 2024

Uh oh!

gijoe0295 commented Jul 30, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gijoe0295 commented Aug 1, 2024

Uh oh!

parasharrajat commented Aug 1, 2024

Uh oh!

gijoe0295 commented Aug 1, 2024

Uh oh!

gijoe0295 Aug 1, 2024

Choose a reason for hiding this comment

Uh oh!

gijoe0295 commented Aug 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

parasharrajat commented Aug 13, 2024

Uh oh!

gijoe0295 commented Aug 13, 2024

Uh oh!

parasharrajat commented Aug 13, 2024

Uh oh!

dylanexpensify commented Aug 14, 2024

Uh oh!

gijoe0295 commented Aug 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gijoe0295 commented Jul 22, 2024 •

edited by flodnv

Loading

gijoe0295 Jul 31, 2024 •

edited

Loading

parasharrajat Jul 31, 2024 •

edited

Loading

gijoe0295 Jul 31, 2024 •

edited

Loading

gijoe0295 Jul 25, 2024 •

edited

Loading

gijoe0295 commented Aug 12, 2024 •

edited

Loading

gijoe0295 commented Aug 14, 2024 •

edited

Loading

gijoe0295 commented Aug 15, 2024 •

edited

Loading

gijoe0295 commented Aug 15, 2024 •

edited

Loading

parasharrajat commented Aug 15, 2024 •

edited

Loading