Skip to content

Dupe detection - Confirmation page RHP turns to not here page while dismissing #46179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
6 tasks done
m-natarajan opened this issue Jul 25, 2024 · 13 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented Jul 25, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Found when validating #45877
Version Number: 9.0.12.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Submit two same expenses (same amount and merchant).
  4. Go to transaction thread of any expense.
  5. Click Review duplicates.
  6. Select Keep this one (any).
  7. Proceed to confirmation page.
  8. Click outside the RHP to dismiss.
  9. Note that RHP turns to not here page while dismissing.
  10. Repeat Step 5 to 7.
  11. Click Confirm button.
  12. Note that RHP turns to not here page while dismissing.

Expected Result:

In Step 9 and 12, the confirmation page will not turn to not here page while dismissing.

Actual Result:

In Step 9 and 12, the confirmation page turns to not here page while dismissing.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6552268_1721883182475.20240725_124913.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @jliexpensify
@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Jul 25, 2024
Copy link

melvin-bot bot commented Jul 25, 2024

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jul 25, 2024

Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jul 25, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@m-natarajan
Copy link
Author

We think this bug might be related to #wave-collect - Release 2

@gijoe0295
Copy link
Contributor

Will be resolved in #45965

@roryabraham
Copy link
Contributor

Dupe detection is behind a beta, so NAB

@roryabraham roryabraham added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jul 25, 2024
@melvin-bot melvin-bot bot added the Overdue label Jul 29, 2024
@flodnv flodnv added the Reviewing Has a PR in review label Jul 29, 2024
@melvin-bot melvin-bot bot removed the Overdue label Jul 29, 2024
Copy link

melvin-bot bot commented Aug 5, 2024

@flodnv, @jliexpensify, @gijoe0295 Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Aug 7, 2024

@flodnv, @jliexpensify, @gijoe0295 Eep! 4 days overdue now. Issues have feelings too...

@jliexpensify
Copy link
Contributor

Could we switch this to Weekly or Monthly since it's behind a beta and will resolved by #45965? (and to stop the pings?)

@flodnv flodnv added Weekly KSv2 and removed Daily KSv2 labels Aug 12, 2024
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Sep 4, 2024
Copy link

melvin-bot bot commented Sep 4, 2024

This issue has not been updated in over 15 days. @flodnv, @jliexpensify, @gijoe0295 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 4, 2024
@flodnv
Copy link
Contributor

flodnv commented Sep 5, 2024

#45965 was deployed, we need a retest @jliexpensify @m-natarajan

@flodnv flodnv added Weekly KSv2 retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause and removed Reviewing Has a PR in review Monthly KSv2 labels Sep 5, 2024
@jliexpensify
Copy link
Contributor

Weird, I am not seeing a Resolve Duplicates option on v0.0.30-7 (staging)

@m-natarajan @gijoe0295 can you both verify this/confirm this isn't a bug anymore?

@melvin-bot melvin-bot bot added the Overdue label Sep 16, 2024
@jliexpensify
Copy link
Contributor

Going to close this as I couldn't repro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

5 participants