Skip to content

Show day of the week when other user is in a different date #4240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Show day of the week when other user is in a different date #4240

merged 1 commit into from
Jul 27, 2021

Conversation

rdjuric
Copy link
Contributor

@rdjuric rdjuric commented Jul 26, 2021

Details

Modifies our ParticipantLocalTime to also show the day of the week when the other user is in a different day.

Fixed Issues

$ #4118

Tests

  1. Open any chat
  2. Change your timezone so that you're one day ahead or one day behind the other user
  3. Above the composer you should see the day of the week that the other user is in

QA Steps

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web.mov

Mobile Web

mWeb

Desktop

desktop.mov

iOS

iOS.mp4

Android

android

@rdjuric rdjuric marked this pull request as ready for review July 27, 2021 00:47
@rdjuric rdjuric requested a review from a team as a code owner July 27, 2021 00:47
@MelvinBot MelvinBot requested review from Dal-Papa and removed request for a team July 27, 2021 00:47
@Dal-Papa Dal-Papa merged commit d35ab90 into Expensify:main Jul 27, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.80-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@isagoico
Copy link

Day of the week is not displayed

Action Performed

  1. Log in to New Expensify in Android / iOS or Desktop
  2. Change your timezone so that you're one day ahead or one day behind the other user
  3. Above the composer you should see the day of the week that the other user is in

Expected Result

Day of the week is displayed along with the current time of the user

Actual result

Day of the week is not displayed with the current time of the user.

Platform

iOS ✔️
Android ✔️
Desktop ✔️

Notes/images/video

image

@isagoico isagoico added the DeployBlockerCash This issue or pull request should block deployment label Jul 29, 2021
@rdjuric
Copy link
Contributor Author

rdjuric commented Jul 29, 2021

Hi @isagoico! I couldn't reproduce it on staging (see image). Can you give me more details, like the Timezone the testers were in?

Just to make sure: the day difference is calculated based on the timezones of the account, and not in relation to the time of the device/computer. In the screenshot, looks like one user is at 3:25 AM and the other at 7:21 AM. I can't be sure but looks like they might have been in the same day of the week.

Screen Shot 2021-07-29 at 4 14 43 PM

@isagoico
Copy link

@rdjuric this is only reproducible on mobile apps and in desktop. Web is a pass for this PR.

@rdjuric
Copy link
Contributor Author

rdjuric commented Jul 29, 2021

Thanks for the clarification, @isagoico! I still can't reproduce it anywhere
Screen Shot 2021-07-29 at 5 55 01 PM

@isagoico
Copy link

Weird 🤔 I'm not able to reproduce the issue anymore on Android or iOS but I'm still able to repro on Desktop 🤯
I checked with the same account in dekstop as in iOS and Android so it should be working there too.
image

image

@rdjuric
Copy link
Contributor Author

rdjuric commented Jul 29, 2021

Yes! It's specially weird since the Desktop has the same code as the Web 🤯

I'll keep looking for a way to reproduce this.

@isagoico
Copy link

isagoico commented Jul 29, 2021

mmm I did just update the desktop app and it's still showing build 1.0.81-2 instead of 1.0.81-3 so I think that's the main issue. I'll ask in contributor channel if anyone has been able to download build 1.0.81-3 in desktop.

Edit: Ignore me, this change was deployed in 1.0.80-3 and should be visible in 1.0.81-2

@isagoico isagoico removed the DeployBlockerCash This issue or pull request should block deployment label Jul 30, 2021
@isagoico
Copy link

Retest was a pass! Checking this one off the list

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.81-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants