-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Show day of the week when other user is in a different date #4240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging in version: 1.0.80-3🚀
|
Day of the week is not displayedAction Performed
Expected ResultDay of the week is displayed along with the current time of the user Actual resultDay of the week is not displayed with the current time of the user. PlatformiOS ✔️ Notes/images/video |
Hi @isagoico! I couldn't reproduce it on staging (see image). Can you give me more details, like the Timezone the testers were in? Just to make sure: the day difference is calculated based on the timezones of the account, and not in relation to the time of the device/computer. In the screenshot, looks like one user is at 3:25 AM and the other at 7:21 AM. I can't be sure but looks like they might have been in the same day of the week. |
@rdjuric this is only reproducible on mobile apps and in desktop. Web is a pass for this PR. |
Thanks for the clarification, @isagoico! I still can't reproduce it anywhere |
Yes! It's specially weird since the Desktop has the same code as the Web 🤯 I'll keep looking for a way to reproduce this. |
Edit: Ignore me, this change was deployed in 1.0.80-3 and should be visible in 1.0.81-2 |
Retest was a pass! Checking this one off the list |
🚀 Deployed to production in version: 1.0.81-4🚀
|
Details
Modifies our
ParticipantLocalTime
to also show the day of the week when the other user is in a different day.Fixed Issues
$ #4118
Tests
QA Steps
Tested On
Screenshots
Web
web.mov
Mobile Web
Desktop
desktop.mov
iOS
iOS.mp4
Android