[HOLD - for payment Aug 5th] Show Yesterday/Tomorrow when other user is in a different date

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Log in to e.cash and navigate to a conversation with a user that's on a different time zone (and it's a different day)

Expected Result:

There should be a notice for the user that the other chat member is currently on another date.

Actual Result:

There's no information in the time message that the user is in another date.

Workaround:

N/A

Platform:

Where is this issue occurring?

Web ✔️
iOS✔️
Android✔️
Desktop App✔️
Mobile Web✔️

Version Number: 1.0.79-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Expensify/Expensify Issue URL:

View all open jobs on Upwork

---

From @rafecolton https://expensify.slack.com/archives/C01GTK53T8Q/p1626308184300200

The message that shows the time of day for people outside your timezone should also show the date if it is not today where that person resides

[MelvinBot]

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[quinthar]

Hm, I think a day of the week would be more intuitive than "tomorrow". So "It is 5:23am Saturday for Bob" rather than "5:23am tomorrow for Bob"

…

On Fri, Jul 16, 2021 at 10:30 AM MelvinBot ***@***.***> wrote: Triggered auto assignment to @johnmlee101 <https://github.com/johnmlee101> (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#4118 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEMNUVSF5KGYDM3BTZQYKTTYBUEHANCNFSM5AP7AUPA> .

[johnmlee101]

Seems fairly straightforward! I agree with David's point in that having a day of the week is more clear.

https://github.com/Expensify/Expensify.cash/blob/f75961876aff1f6eb9dc3fec5430f7cd614c6854/src/pages/home/report/ParticipantLocalTime.js#L69-L74

Looks like this.state.localTime() should give us the day of the week so this is very straightforward. Going to assign external.

[MelvinBot]

Triggered auto assignment to @Christinadobrzyn (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[rdjuric]

We've decided to showing the day of the week instead of tomorrow/yesterday?

Modify our ParticipantLocalTime to also receive the timezone of the current user as a prop, and

1. In the getParticipantLocalTime method, check if the day of our timezone is different than the day of the reportRecipientTimezone using moment
2. If it is, display the day of the week before the time in our this.state.localTime

[johnmlee101]

Do we need to receive it as a prop? We get the timezone here:

App/src/pages/home/report/ParticipantLocalTime.js

Line 44 in f759618

const reportRecipientTimezone = lodashGet(this.props.participant, 'timezone', {});

[rdjuric]

Do we need to receive it as a prop? We get the timezone here:

This is the timezone of the other participant that we pass as a prop here

App/src/pages/home/report/ReportActionCompose.js

Line 436 in f759618

&& <ParticipantLocalTime participant={reportRecipient} />}

We didn't need to check our own timezone in the ParticipantLocalTime before (as we only cared if it was different, and we checked for that here), but now we need it to compare the days of the week.

[johnmlee101]

Ah, very fair. then that seems like a good solution.

[Christinadobrzyn]

Posted job in Upwork:

Internal job post: https://www.upwork.com/ab/applicants/1417732027235254272/job-details
External job post: https://www.upwork.com/jobs/~01e1259985646da02d

Invited @rdjuric to the job

[shuklaalok7]

I came here after looking at the Upwork job, but looks like it's almost fixed and @rdjuric is going to implement it. All the best.

[Christinadobrzyn]

Hired @rdjuric for this project! 🎉

[Christinadobrzyn]

I see the PR is merged - [HOLD - for payment Aug 5th]

[Christinadobrzyn]

I miscalculated the merge date - PR was merged 8 days ago today so paying this one.

[Christinadobrzyn]

Paid @rdjuric in Upwork! @johnmlee101 I think this can be closed - I'm curious why it didn't auto close when the PR deployed?

[Christinadobrzyn]

Closing issue - reopen if needed.