Skip to content

fix: 23369 back button navigation fixed for ondify steps #23864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 7, 2023
Merged

fix: 23369 back button navigation fixed for ondify steps #23864

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
001804d
fix: 23369 back button navigation fixed for ondify steps
vipin87 Jul 29, 2023
eb4b50b
Trigger Build
vipin87 Jul 29, 2023
c7fc624
getElementByClass replaced with querySelector
vipin87 Aug 1, 2023
5671c62
comment added in css file and args removed from function call
vipin87 Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/components/Onfido/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,3 +47,7 @@
height: 92% !important;
}
}

.onfido-sdk-ui-NavigationBar-back {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you could add the explanation comment why we are hiding this button

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

visibility: hidden;
}
12 changes: 11 additions & 1 deletion src/pages/ReimbursementAccount/RequestorOnfidoStep.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,16 @@ class RequestorOnfidoStep extends React.Component {
constructor(props) {
super(props);
this.submit = this.submit.bind(this);
this.goBack = this.goBack.bind(this);
}

goBack(...args) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't saw that one, onBackButtonPress is called inside HeaderWithBackButton without any args, so this spread is redundant in my opinion

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

const onfidoBack = document.querySelector('.onfido-sdk-ui-NavigationBar-back');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This caused deploy blocker - #24343.
document doesn't exist on native.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dang, I didn't encountered this during my testing on offline...
@vipin87 Can you rise the follow-up for the issue with proper platform handling?

if (onfidoBack && !onfidoBack.classList.contains('onfido-sdk-ui-NavigationBar-disabled')) {
onfidoBack.click();
} else {
this.props.onBackButtonPress(...args);
}
}

submit(onfidoData) {
Expand All @@ -50,7 +60,7 @@ class RequestorOnfidoStep extends React.Component {
stepCounter={{step: 3, total: 5}}
shouldShowGetAssistanceButton
guidesCallTaskID={CONST.GUIDES_CALL_TASK_IDS.WORKSPACE_BANK_ACCOUNT}
onBackButtonPress={this.props.onBackButtonPress}
onBackButtonPress={this.goBack}
/>
<FullPageOfflineBlockingView>
<ScrollView contentContainerStyle={styles.flex1}>
Expand Down