[HOLD for payment 2023-08-21] [HOLD for payment 2023-08-17] BA - iOS App crashes if user tap ‘Back’ on the Onfido start screen Offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Start iOS App
2. Login with Expensifail account
3. Go to existing or create new workspace
4. Go to Workspace > Connect bank account
5. Follow the flow for adding a VBA using the credentials [Company - Expensify, First name - First, Last name - Last] until you reach the Onfido screen
6. Onfido first screen loads
7. Go OFFline
8. Go next screen
9. User can’t go next from this 2nd screen offline
10. Tap 'Back' 2 times while staying offline

Expected Result:

User should return to the Personal Information page

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.52.2

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6159354_T3575395-iOS-Onfido-Crash-Offline.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[tgolen]

@lanitochka17 I see that you're able to reproduce it on iOS. Have you tried the same flow on other platforms and it's working on those platforms? Also, is this a brand new crash that hasn't been on previous versions of the app?

[lanitochka17]

Issue reproducible in only IOS

[situchan]

root cause: https://github.com/Expensify/App/pull/23864/files#r1289249208
I suggest to revert #23864

[tgolen]

@situchan Thank you for finding that! I agree, let's revert and have the code resubmitted with proper cross-platform support. Can you please take care of doing the revert?

[situchan]

@situchan Thank you for finding that! I agree, let's revert and have the code resubmitted with proper cross-platform support. Can you please take care of doing the revert?

Sure I can do that

[situchan]

@tgolen PR is ready

[tgolen]

Verified that the flow works now without crashing.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert "fix: 23369 back button navigation fixed for ondify steps" #24373

If no regressions arise, payment will be issued on 2023-08-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[situchan]

@tgolen am I eligible for payment here? As I found the root cause and raised PR for fix and merged.

[tgolen]

Yes, you are. I'm not exactly sure what the process is in this case. I have never handled the payment side of things. @dylanexpensify do you know how to handle it in this case?

[dylanexpensify]

Ah yeah, @situchan are you paid in NewDot? @tgolen would we be paying flat $1000 here?

[situchan]

I am using upwork. As I am the PR author, I'd say this is worked externally so no "flat" concept. Also, I am not sure if this applies timeline rule.

[dylanexpensify]

Ah perfect, yes timeline applies and you hit it! Nice one! Please apply here!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.53-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert "fix: 23369 back button navigation fixed for ondify steps" #24373

If no regressions arise, payment will be issued on 2023-08-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

📣 @krkrishnaraj11! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[krkrishnaraj11]

I have recreated the error issue in ios.
There is an issue error "document" doesn't exist.
Mostly due to api response and no network state

Need to console and find the error

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01bc44c7d52ff7f012

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[dylanexpensify]

@situchan bump on applying!

[situchan]

@dylanexpensify if possible, can you please invite me to the job or send offer?

[dylanexpensify]

Not a problem!

[dylanexpensify]

Sent!

[dylanexpensify]

offer sent!

[dylanexpensify]

payment sent! Thanks again @situchan!