[HOLD for payment 2023-08-17] [$1000] Web – Personal Information– Back button is not working accurately in "Personal information" section (step 3 of 5).

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open the "Settings" menu.
2. Click on "Workspaces."
3. Navigate to "Bank Account."
4. Click on "Connect bank account."
5. Proceed through all the steps until you reach the "Personal Information" section (step 3 of 5).
6. Click on "Save & Continue" in the "Personal Information" section (step 3 of 5).
7. Click on "Drivers License" in the "Personal Information" section (step 3 of 5) and proceed.
8. Click on "Get Secure link" in the "Personal Information" section (step 3 of 5) and proceed.
9. At this point, when you reach the page where "Scan the QR code with your phone" is written, click on the back button.
10. Observe that the user is directed back to the first page of the "Personal Information" section (step 3 of 5) containing the Personal Information form.
11. Note that steps 6 to 9 are skipped, while the expected behavior is for the user to go back one step at a time.

Expected Result:

The user should be able to go back one step at a time when using the back button.

Actual Result:

The back button does not allow the user to go back one step at a time, causing the skipping of steps 6 to 9.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.43-6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Bug.1.mp4

Recording.3823.mp4

Expensify/Expensify Issue URL:
Issue reported by: @usmantariq96
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689919860940239

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0128b834dee86c9fde
• Upwork Job ID: 1683868818971901952
• Last Price Increase: 2023-07-25

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ygshbht]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In the "Connect bank account" process, users are directed back to the beginning of the "Personal Information" page when hitting the main back button, which skips several steps.

What is the root cause of that problem?

The back button is presently programmed to take users to the start of the section, not back one step at a time, which is the underlying issue.

What changes do you think we should make in order to solve the problem?

There's already a mini back button which takes you one step back. If the header's back button is required to follow the same, its function can be modified to mimic the mini back button, enabling users to navigate back one step at a time.

New.Expensify.-.Google.Chrome.2023-07-22.03-09-35.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0128b834dee86c9fde

[melvin-bot]

Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new.

[bfitzexpensify]

External

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

[shubham1206agra]

I think the current behaviour is expected behaviour for Onfido flows. I don't think we can map the default back button of Onfido to the header's back button.

cc @robertKozik @bfitzexpensify

[vipin87]

Proposal

Please re-state the problem that we are trying to solve in this issue.

While adding/modifying back account in a Workspace, back button is not working as expected. Specifically on sub-steps of step 3, back button doesn't navigate back to sub-steps, instead take directly on first sub-step.

What is the root cause of that problem?

Back button in top header is coded to navigate browser's history. However, sub-steps of step 3 are part on ondify-sdk-ui, which do not register their steps in browser's history.

What changes do you think we should make in order to solve the problem?

We can programmatically click by finding back button provided by ondify-sdk-ui whenever top header back button is clicked.

What alternative solutions did you explore? (Optional)

Alternatively I tried to explore ondify-sdk-ui code, which I couldn't find.

Attaching screen capture after doing a quick fix.

Screen+Recording+2023-07-25+at+11.01.12+PM.mov

[melvin-bot]

📣 @vipin87! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[vipin87]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/vipin

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[mikesmnx]

Please re-state the problem that we are trying to solve in this issue

The back button doesn't enable the user to navigate back one step at a time when the OnFido form is open.

What is the root cause of that problem?

An additional third-party library, onfido-sdk-ui, is utilized in the third step, and it includes its own multi-step workflow. However, when the back button at the top is clicked by a user, onfido-sdk-ui doesn't register this click.

What changes do you think we should make in order to solve the problem?

The Onfido SDK doesn't provide an out-of-the-box method to programmatically navigate back to the previous screen. The navigation between steps is managed internally by the SDK

The quickest way to address this issue is to verify if there is a back button from onfido-sdk-ui on the page, and simulate a click on it, instead of navigating back on the main wizard.

What alternative solutions did you explore? (Optional)

The Onfido SDK also provides a lower-level API that developers can use to interact directly with Onfido's services, while managing the UI and navigation themselves, but this approach is more complex.

Fix:
ubu-screen0.webm

[melvin-bot]

📣 @mikesmnx! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[mikesmnx]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01ae736e03e7dce34c

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[bfitzexpensify]

@robertKozik couple of proposals for you to review - thanks!

[vipin87]

@bfitzexpensify thanks, yes it resolved.

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @vipin87 got assigned: 2023-07-28 22:13:54 Z
• when the PR got merged: 2023-08-07 23:25:07 UTC
• days elapsed: 6

On to the next one 🚀

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: 23369 back button navigation fixed for ondify steps #23864

If no regressions arise, payment will be issued on 2023-08-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @vipin87 requires payment
• @robertKozik does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@robertKozik] The PR that introduced the bug has been identified. Link to the PR:
• [@robertKozik] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@robertKozik] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@robertKozik] Determine if we should create a regression test for this bug.
• [@robertKozik] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[robertKozik]

This PR caused regression and was reverted. @vipin87 could you come up with the new PR with proper platform handling?

[vipin87]

@robertKozik new PR created with platform handling.

[melvin-bot]

This issue has not been updated in over 15 days. @francoisl, @vipin87, @bfitzexpensify, @robertKozik eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[robertKozik]

The first PR was reverted due to regression, and the second one has been open for three weeks now. I've tried reaching out to the author of the PR, @vipin87, to encourage progress, but so far, there has been no success.

[mikesmnx]

@robertKozik I can take over this task since I have a similar approach to the chosen one.

[melvin-bot]

@francoisl, @vipin87, @bfitzexpensify, @robertKozik, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[usmantariq96]

@bfitzexpensify @francoisl am I eligible for reporting bonus ?

[usmantariq96]

@bfitzexpensify @francoisl bump!

[bfitzexpensify]

Hey @usmantariq96 - we didn't end up addressing this, so this isn't eligible for the reporting bonus.

[usmantariq96]

@bfitzexpensify Thank you for your response, and I completely respect your decision. I had assumed that I would be eligible due to "Hold for Payment" status which was due in Aug.